Conflicts with the "AHAH Helper" module because of bad function name [#627538]

There is a function called "array_smart_merge()" in both modules, so there will be an fatal Error, when trying to activate both modules. The function must called "hierarchical_select_array_smart_merge()" to work proper with Drupal. See also: http://drupal.org/node/417448
Regards Jens

Comment	File	Size	Author
#3	hierarchical_select-716494.patch	1.21 KB	atheneus
#1	627538_array_smart_merge.patch	1.67 KB	reubenavery

Comments

Comment #1

reubenavery commented 9 January 2010 at 00:52

Status:

Active

» Needs review

Status	File	Size
new	627538_array_smart_merge.patch	1.67 KB

Hello,

Since the two functions are identical, I just added a function_exists check around the module.. patch attached

Comment #2

reubenavery commented 9 January 2010 at 01:41

probably would be better to just rename the function though..

moral of this story: if you're going to borrow a function from the comments at php.net, might want to assume that somebody else in a different module will borrow the same function.

Comment #3

atheneus commented 22 February 2010 at 13:13

Status	File	Size
new	hierarchical_select-716494.patch	1.21 KB

I had uploaded this patch to a more recent duplicate issue. I have renamed the function and all references within the module - putting it under the module namespace as _hierarchical_select_array_smart_merge(...). I believe both these projects are by Wim Leers, so maybe he will want to consolidate any shared code across his modules. This patch does nothing to address duplicate code across modules.