path alias not used in 'Translations' block

Same problem here...

In the 4.6 version, AFAIK (hope I'm correct now...), this didn't work either. At least, I had the same problems with URL aliasing; see these posts:
- http://drupal.org/node/32144
- http://drupal.org/node/34611

To solve translation of URL aliasing, in 4.6.6 I've always used this patch - with success:
- http://drupal.org/node/22345

The code needed to be patched against i18n.inc. However, the function where it was all about (i18n_l) became part of translation.module and got another name (translation_url). I've tried to patch the same code in the renamed function in translation.module, and really, something is happening with the URL's in the translation block, but it still isn't what I want.

Although I'm not a programmer, I'll look further. In the meantime, I hope this info might be a good starting point for others to help solving this issue...

Cheers,
Marc

Confirmation of exactly the same experience here.

I've changed the path processing to check always for path aliases before appending the language prefix.

Hi Jose,

Thanks very much mate, for repairing: it works pretty good now!!!

However, there's one error that keeps coming back (e.g. here and now, when testing the alias in language translation block and therefore switching and switching and switching), and that's the error:

Fatal error: Call to undefined function: drupal_lookup_path() in /home/example.com/public_html/modules/i18n/i18n.module on line 229

If you do a "delete from cache", it's fine again, but within a few clicks, the error comes back. Hope this explanation makes some sense...

Some additional info:

I get this error message also when I'm clicking through the primary links, AFAICS exactly then when I come back to a certain menu item for the second time.

So it seems it has something to do with rebuilding a full path, including alias, for a second time; whether it's a primary link or a link in the language translation block.

I can remember, to get i18n menu module working, a cache_clear_all($cid); was needed somewhere; maybe it's the same kind of issue? Or is it just the "undefined function" as the error says?

Yes, there was a problem with the bootstrap when cache enabled. It should work now.

Sorry Jose, for making active again... :\

Thanks for the efforts anyway, in the middle of the night! You're mad... The error message is gone, so that's the good news! However, there's a little bit of bad news too.

Everything is fine when English and Dutch url aliases are based on different words - because they're different in these two languages:

• English node "advertising", url alias "advertising"
• Dutch node "adverteren", url alias "adverteren"

Here, the links become respectively "en-US/advertising" and "nl/adverteren" which is good.

Things go wrong when English and Dutch url aliases are based on the same words - because they're the same in these two languages (and therefore need to get e.g. an additional language prefix in their url aliases in order to make them different and unique):

• English node "contact", url alias "contact" must become e.g. "en-US/contact"
• Dutch node "contact", url alias "contact" must become e.g. "nl/contact"

Here, the links become respectively "en-US/en-US/advertising" and "nl/nl/adverteren" which isn't good.

In 4.6.6 I got this thing working with a patch that can be found here: http://drupal.org/node/22345. This resulted in the following i18n.inc for 4.6.6 which AFAICS did the trick for me:

function i18n_l($text, $lang , $url = '' , $attributes = array(), $query = NULL) {
  global $i18n_langpath;
  // If !url get from original request
  if (!$url) {
    $url = _i18n_get_original_path();
  }
  // If url has lang_prefix, remove it
  i18n_get_lang_prefix($url, true);

	// Revision New Oceans starts here
	// Extra code to get correct link from language block
	// Got this patch from: http://drupal.org/node/22345
	//
	// If url is an alias, de-alias it

	$url = i18n_get_normal_path($url);

  //are we looking at a node?
  if (preg_match("/^(node\/)([0-9]*)$/",$url,$matches)) {
    if ($nid = i18n_node_l($matches[2], $lang)) {
      $url = "node/$nid";
    }
  }
  elseif (preg_match("/^(taxonomy\/term\/)([^\/]*)$/",$url,$matches)) {//or at a taxonomy-listing?
    if ($str_tids = i18n_taxonomy_l($matches[2], $lang)) {
      $url = "taxonomy/term/$str_tids";
    }
  }
  
	// Revision New Oceans starts here
	// Extra code to get correct link from language block
	// Got this patch from: http://drupal.org/node/22345
	//
	// If url has an alias, use it!

	$url = drupal_get_path_alias($url);

  return '<a href="'. i18n_url($url, $lang, $query) .'"'. drupal_attributes($attributes) .'>'. $text .'</a>';
}

I tried to patch function translation_url in translation.module 4.7 the same way (I suppose the function translation_url in translation.module 4.7 can be compared to the function i18n_l in i18n.inc 4.6?), however, this didn't work...

Wish I had some more programming skills, so I could help solving this little issues. Anyway, hope this all makes some sense and creates a good starting point for anyone with better skills...

Hi again. I've reworked the path rewriting to handle a lot more cases.

You mark this as 'fixed' if you finally like it ;-)

Hi Jose, thanks again!

I'm not in the position to test right now, but I will certainly do tomorrow.

Thumbs up,
keep up the good work!

Marc

Hi Jose,

Managed to test the latest cvs version from here (at my girlfriend's :)) and everything in translation block works like a charm now; excellent work, many thanks!

Marc