It looks like the Ooyala uploader triggers the "progress" event one last time after it triggers the "finished" event. This causes the phrase "Finished" to show up for just a second before being overwritten with "100%". This patch just checks to make sure that the text isn't going to be 100% before updating the progress.

CommentFileSizeAuthor
#2 ooyala_js_cleanup.patch4.18 KBquicksketch
#1 ooyala_show_finished.patch620 bytesquicksketch
ooyala_show_finished.patch894 bytesquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new ooyala_show_finished.patch620 bytes

Shoot, a stray console.log() left in there.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new ooyala_js_cleanup.patch4.18 KB

While poking around in the JS for the first time I found a bunch more coding style fixes that should be included too (whitespace, captialization, etc.) JavaScript is funny because it uses camelCase in Drupal, even though PHP is underscore_separated. Ah well. Here's the patch with all the cleanup too.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

I went ahead and committed this patch so that it would not cause conflicts with other feature patches.

heronog’s picture

heronog commented

perfect, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.