The module allows to set a maximum length, after which text will be collapsed inside a pane an can be expanded by clicking on a read more link.
Example:
http://www.ptext.de/pressemitteilung/paralympics-sieger-wolfgang-sacher-...
In the right column, there is a pane called profile. The profile consists typically of 1-2 sentences, but the customer has pasted a far to long description. Thanks to the module the text has been partly collapsed an can be expanded via a click on "ausklappen".
The pane underneath it also uses this functionality, but the limit there is higher, so everything appears unchanged.
Difference to other modules:
Panels Accordion: By definition only one element in the accordion can be expanded. No possibility to limit the size, depends on parsing the contents.
Collapsible theme functions in Drupal: It would be neccesary to modify the content sent to the pane, again creating potential other problems.
In the long run I am considering of releasing some bigger modules to Drupal or apply for co-maintainerships of existing modules. Right now, I do not really want to submit for example a patch to an unmaintained module, rewriting about 50% of the code base and not receiving the proper attribution.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | panels_expander.tar_.gz | 15.57 KB | digi24 |
Comments
Comment #1
digi24 commentedCode is attached as requested.
Can you please advise me, how to handle the licensing issue:
The plugin says:
1. In my understanding, I should by able to upload the plugin to Drupal. The plugin did not come with a copy of the GPL, I downloaded it to the appropriate directory, is this correct, is it necessary?
2. There is only indirect reference to the author of the plugin on its page. Should I include his name in the documentation and Drupal files additionally to linking to it everywhere it is used, or should I assume that he does not want his name to be spread accross the internet?
My suggested approach to these questions is already visible in the upload, so just tell me, in case I should do it in a different way)
Comment #2
avpadernoFiles available from third-party sites should not be included in Drupal.org CVS.
Comment #3
avpadernoAlso, the license for all the files committed in Drupal.org CVS is GPL License v2 or higher; it is not GPL v3+.
Comment #4
sreynen commentedThe rule for 3rd party code allows for GPL code, under specific conditions, one of which is a version that is hard to locate, with jQuery plugins offered as an example. Though I was able to find this version of the plugin eventually, it was not easy, and it was part of another project, so it's not clear if it will be maintained there at that version for long. The author's git repository doesn't go back as far as this version, so if the older version is necessary for the module to work, this might be permissible. Otherwise, just point to that repository, or write your own code that accomplishes the same goal; the jQuery plugin isn't very complicated.
Last I checked, 3 is higher than 2, so I don't think the GPL version is an issue.
Comment #5
avpadernoGPL License v2 text is different from the GPL License v3. As Drupal core code uses GPL License v2, the license for all committed code must be the same; when Drupal will use GPL License v3, then also third-party modules will use that license too.
Considering that the module is being developed now, it should use the latest available version of the plugin.
To make a paragon, it would be like if I would create a module that needs jQuery 1.0, and I would include it with the module; would not it be better if I would write a module that uses the version of jQuery currently included with Drupal?
About the difficult to find the plugin (I didn't have any problems to find it, though), users are not thought to search for the plugin; the author of the module is supposed to report from where to download the plugin, and where to install it.
Comment #6
sreynen commentedSome jQuery plugins require older versions to work with the older version of jQuery that comes with Drupal. One can use jQuery update to use a newer version of jQuery, but that has bugs and shouldn't be a requirement for modules. I don't know if that's the case here, but it's a legitimate reason to use older versions, which is why that exception exists.
It's been stated (e.g. by Crell and KiamLaLuno, though the latter was apparently unintentional) that Drupal is GPL 2 or later. If this is not true, those statements should be explicitly corrected so contributors aren't left confused.
[Edited by KiamLaLuno to fix a not closed HTML tag]
Comment #7
digi24 commentedThank you for the comments. I will rework the submission not to include the external files and I will check the compatibility of the plugin. Just give me a couple of days, so I can verify everything is ok.
@sreynen
thanks for pointing out the git repository, I really checked the module docs AND the jquery plugin pages, but I did not see this / look into this direction.
@Kiam:
Thanks for clarifying on the GPL issue. I was not sure about the importance of versions, one reason why I asked.
Comment #8
avpadernoThere have not been replies from the OP in the past 7 days. I am marking this report as .