If you click on the node, and are viewing the current revision, then click on the title to show the revision controls, you will see the list of revisions. Once there, if you click on any revision to actually view it, you get the results on the attached screen shot.

As reported by pumpkinkid, #627640: Revision controls disappear after a few days of working perfectly., comment #11.

CommentFileSizeAuthor
Two active tabs.PNG1.9 KBrdeboer

Comments

rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Needs work » Postponed (maintainer needs more info)

I can't seem to reproduce this one....
Does the behaviour change on your system when on the Site configuration >> Smart Tabs page you change Pages to include from * to blank? On my system it doesn't, it behaves correctly in both cases.
Does it continue to happen when you change the theme? Or log in a user with a different role permissions?
Do you have the Diff module enabled?

pumpkinkid’s picture

pumpkinkid commented

I don't think any of my answers can help you narrow it down any more.. but...

Does the behaviour change on your system when on the Site configuration >> Smart Tabs page you change Pages to include from * to blank? On my system it doesn't, it behaves correctly in both cases.
-On my site there is no change at all.

Does it continue to happen when you change the theme?
-Yes

Or log in a user with a different role permissions?
-Yes

Do you have the Diff module enabled?
-No

I will tell you this though, My personal site has the 6.x-2.7 version of both revisioning and module grants and it does not have the issue, which is why I felt it had to do with smart tabs... If you think it can help you narrow down the issue, I will upgrade my personal site to the Dev version.

pumpkinkid’s picture

pumpkinkid commented

Actually, just thought about this...

<li class="active">
<a class="active" href="/node/89/revisions/list">
<span class="tab">List all revisions</span>
</a>
</li>
<li>
<a class="active" href="/node/89/revisions/89/view">
<span class="tab">View</span>
</a>
</li>

If I'm in the view screen, shouldn't it be:

<li>
<a href="/node/89/revisions/list">
<span class="tab">List all revisions</span>
</a>
</li>
<li class="active">
<a class="active" href="/node/89/revisions/89/view">
<span class="tab">View</span>
</a>
</li>
rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks for your additional info pumpkinkid!
Re #3: yes that confirms in HTML what you see on the screen....
Re #2: "My personal site has the 6.x-2.7 version of both revisioning and module grants and it does not have the issue, which is why I felt it had to do with Smart tabs"
Not a bad assumption....
But why can I not reproduce it!
Just for my own sanity, if you go to the My account >> Edit >> Smart tabs page and disable Smart tabs altogether, what happens then?
Rik

pumpkinkid’s picture

pumpkinkid commented

When I disable smart tabs in the smart tabs page, the revisioning controls disappear... Isn't that the expected behavior though considering that revisioning is now dependent on smart tabs?

Anyways, did you check to see if you are getting the same html as I am? I am asking simply because I can see how the css for your installation may not be the same and cause you to not be able to reproduce it...

If the way my css shows an "active" tab is by using <a class="active"> then both would show as "active" as both have that class... however, if I would be using <li class="active"> then the wrong one would be selected based on the HTML being rendered...

Of course however, I'm just trying to help narrow down the issue, I have no idea what the modules is doing on the back-end.

Would you like for me to upgrade to the 2009-Nov-16 dev snapshot?

PK

pumpkinkid’s picture

pumpkinkid commented

Just so you know, I just upgraded to the latest dev due to the fix discussed here #549588: "View revision of own content" should also check node access and noticed that the issue still persists.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Without further info I'm going to have to close this one.

pumpkinkid’s picture

pumpkinkid commented

What other information could I provide you that can help?

rdeboer’s picture

rdeboer
Location Melbourne
commented

Hi pumpkinkid,
Ok... last ditch effort, as I'm completely baffled, especially since no one has subscribed to having the same issue and even you yourself experience it on one of your systems and not the other...

When I disable Smart tabs in the Smart tabs page, the revisioning controls disappear... Isn't that the expected behavior though considering that revisioning is now dependent on smart tabs?

That's not the expected behaviour... Smart tabs should not take away any functionality from you...

The only module I know that sometimes interferes with Revisioning is the Diff module. There's an outstanding issue on this that I hope to attend soon: #658550: Edit tab not displayed when Diff module installed and "Inline diffs" ticked for content type
But you don't have Diff enabled, so that rules that one out.

I'm still leaning to your theme having something to do with it... What theme is it again?

To accelerate a solution there is something you can do for us...
I recently created improved versions of all three modules in question: Module Grants, Revisioning and Smart menus, Smart tabs...
Let's establish a new base-line by using the latest versions of all three.

As a further improvement, Smart menus, Smart tabs has now been decoupled from Module Grants and Revisioning. You only have to enable Smart tabs if you want the Accessible content menu option to appear. The Accessible content functionality has been split off Module Grants into its own sub-module, named Module Grants Monitor. It will be obvious once you've downloaded the latest development snapshot.

So this allows you to test the latest version of Revisioning in two contexts: with and without Smart tabs.
Would you be able to try this and then we make a fresh debug start from there....

pumpkinkid’s picture

pumpkinkid commented

First off, I want to confirm that you are correct on the fact that we are not using the Diff Module.

Second, the theme I am using is a custom subtheme for Zen. The only issue I have been able to contribute to Zen has been #653342: Missing <span> tag comes back only when dumping the cache., however it seems to be that Smart Tabs has been breaking the span.

After upgrading all three modules to the latest dev snapshot or latest version in smart tabs' case, I disabled the smart tabs module as I have felt it was the issue all along. I was excited at first since it seemed to address the issues I have had since using the dev snapshots.
#653342: Missing <span> tag comes back only when dumping the cache.
#631540: Two tabs highlighted as active at same time(This Issue)

However, after looking around for a bit I see that the revisioning controls, ie: List All Revisions | View | Edit | Unpublish This, have disappeared again as reported on #627640: Revision controls disappear after a few days of working perfectly..

To attempt to trouble shoot these issues, I re-enabled smart tabs and the controls re-appeared, just as I mentioned on #5. I navigated to the smart tabs settings page and noticed that now there are three fields, the new one being "Specify the pages on which Smart tabs should not select a default tab when none is specified". I added an * to the field and got this:

    * content/curriculum-instruction is excluded from Smart tabs
    * No default tab is set for local task node/%.
    * Selecting default tab node/%/revisions for local task node/%.
    * No default tab is set for local task node/%/revisions.
    * Selecting default tab node/%/revisions/list for local task node/%/revisions.

I am assuming that this is the correct behavior, however it does not allow the controls to show as stated earlier. Removing the * from the field gives me this:

    * content/curriculum-instruction is excluded from Smart tabs
    * No default tab is set for local task node/%.
    * Not pre-selecting tab node/%/revisions, as auto-selection is switched-off for the tabs on page node/%.

More importantly however, it does allow the revisioning controls to show. The original issues still remain. I am still seeing two secondary tabs highlighted at once, and the missing span tag still seems to be coming in and out.

Now, as I stated at the beginning of this post... I thought all the issues had been resolved. The reason was because the node that we use as a homepage shows the revision controls always... Having the smart tabs enabled or disabled at all does not seem to have an effect. However performing the same test as above I get:

With the *

node/8/revisions/8/view is excluded from Smart tabs

Without the *

    * node/8/revisions is excluded from Smart tabs
    * No default tab is set for local task node/%/revisions.
    * Selecting default tab node/%/revisions/list for local task node/%/revisions.

Does this make any sense?

I really appreciate the help.
PK

rdeboer’s picture

rdeboer
Location Melbourne
commented

Hi PK,
Thanks for the elaborate analysis. Unfortunately I am none the wiser though....

I did notice that you must have remnants of an earlier Smart tabs exclusion list saved on your system, as out-of-the-box Smart tabs wouldn't exclude "node/8/revisions/8/view" etc...
So to clear all of this out:
o log out (this clears your session info) and log back in (as admin)
o go to Site configuration >> Smart tabs and press Reset to defaults
o "Enable debug info", if you so wish and press Save configuration

Other than that don't know what to suggest. I'm baffled.

What I'd like to establish is whether this is a theme issue or some module interference issue.

So, after you've done the above and with nothing else changed, could you please flick to one of the core themes and see if you're still having problems (both with the Smart tabs menu enabled and with it disabled on Site building >> Modules.

If the problems go away after switching to the core theme , then we have to dig deeper in your Zen-based theme.

Rik

pumpkinkid’s picture

pumpkinkid commented

I reset the settings on the smart tabs, however, I want to make sure I mention anything not core that I am doing to give you a full picture.

We are using Domain Access http://drupal.org/project/domain to control 11 sites. One for each school in our district plus our main site. So our "core" drupal installation (while still experiencing this problem) is our main site. I set the theme on one of our sub-domains to Garland. Going through the same troubleshooting steps I now get a similar HTML output as above.

<li class="active">
<a class="active" href="/node/196/revisions/list">List all revisions</a>
</li>
<li>
<a class="active" href="/node/196/revisions/196/view">View</a>
</li>

This of course results in two active tabs...

Topping it off, disabling the smart tabs causes the controls to disappear just like in the Zen theme.

I imagine your time online will be limited tomorrow so Happy New Year and see you on the other side!

PK

rdeboer’s picture

rdeboer
Location Melbourne
commented

I really don't understand how disabling Smart tabs causes the Revisioning-related tabs to disappear....
Smart tabs does not (well should not) grant or deny access to tabs, it merely renders these based on the info provided by the menu and node access sub-systems...

Module Grants may affect access to certain tabs as it channels through the cues its getting from enabled content access modules, including Domain Access.... Maybe we have two entangled issues... one of them being this old chestnut: http://drupal.org/node/627640#comment-2254268

I suggest you:
o disable the Smart menus, Smart tabs module altogether at Site building >> Modules
o enable a core them (preferably not Garland as it too has a couple of quirks like Zen, maybe use Bluemarine)
o do whatever it takes to get the "List all revisions | View | Edit | Publish this | Delete" tabs back, with or without double active ones; you may have to temporarily disable or reconfigure content access modules for this to happen
o then, still using Bluemarine switch on Smart tabs (without Smart menus) and observe what's happening re the tabs: are they still there and if so, with a single or double active tab?
o finally switch to your Zen-derived theme

Happy New Year to you too!

Rik

PS: to get a better view of which of your content access modules grants or denies access to certain content, you may want to uncomment (i.e. remove the leading double-slash) of the three occurrences of the lines in module_grants.module, function module_grants_node_access($op...) that start with:

    // drupal_set_message("'$op' access=....
pumpkinkid’s picture

pumpkinkid commented

Will Do this sometime next week. It's our Friday at work today and I rather not make changes or start troubleshooting until Monday when I can do the tests and keep at it non-stop.

Thanks!
PK

pumpkinkid’s picture

pumpkinkid commented

I still believe that the issue is with the theme I am using and the classes the smart tabs module assigns, however, I will do some testing and get back to you now that we figured out I was having issues with Node Hierarchy.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Cool.
Things to try are switching to another theme and switching Smart tabs off and back on (for both themes used).

pumpkinkid’s picture

pumpkinkid commented

It seems to have been resolved. Potentially something else fixed since the upgrade I did on Node Hierarchy.

I will let you know if I see this issue again.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

Ok!