OK, I've installed this module which sounded too good to be true, now my newly created accounts who didn't loggued in are gone and any new account who don't log in between the moment where I activate their account and the moment your module runs get its account deleted for this reason (note the wrong date)

Hello,

This automatic notification is to inform you that the following users have
been automatically deleted due to inactivity on Senserely Yours, for more than
6 months:

dust (xxxxxxx@gmail.com) last active on Thursday, January 1, 1970 - 01:00.

So yesterday I lost 7 accounts and today just one, I should have.. well I don't know what I should have done, but not installing it that's for sure, can anyone see why this behavior occurs?

account creation set to be approved by administrator

Cheers,

Comments

alliax’s picture

alliax commented

using drupal 4.7 and version 4.7 of module:
// $Id: inactive_user.module,v 1.4 2006/05/09 23:19:42 driesk Exp $

DriesK’s picture

DriesK commented
Assigned: Unassigned » DriesK

thanks for reporting this bug! Here's what happens.

In pre-4.7, there was a column in the user table called "changed". Inactive user used that column, although it did not reflect user activity correctly as the changed column was only updated upon login, and not upon each page request. On the other hand, the changed column was set to the creation date when a new account was created, so that's why this bug is new to 4.7.

In 4.7, the "changed" column has been renamed to "access", and is updated on each page request. Much better for the purpose of this module. However, if a user never logged in, this field remains 0 (its initial value). And "time 0" in Unix time is actually January 1, 1970 - 00:00h GMT.

The solution is to use the account creation date for inactivity checking when the user has never logged in.

DriesK’s picture

DriesK commented
Status: Active » Fixed

Fixed in HEAD and 4.7 (revisions 1.5 and 1.4.2.1).

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)