G2 should wrap term expansion and definitions in P elements

fgm - May 14, 2006 - 06:09
Project:G2 Glossary
Version:HEAD
Component:Code
Category:feature request
Priority:minor
Assigned:fgm
Status:closed
Description

Currently, on definition pages, the term expansion/translation (header) and definition (body) are contained in DIV elements.

However, it would be more convenient for themeing if they were contained in P elements instead.

(imported issue)

#1

fgm - May 14, 2006 - 06:46

In the current 1.16 version, both of these, as well as the term time period, are themed as simple boxes, which prevent easy themeing because this is a very generic container used throughout Drupal.

These boxes are the ones introducing the DIVs.

It is not possible to change the DIV used to wrap definitions for a P because most definitions will typically contain several P elements themselves, and P elements can't be nested, by the (X)HTML DTD.

#2

fgm - May 14, 2006 - 08:36
Status:active» fixed

G2.module version 1.17 introduces a more generic workaround: 3 new themeable functions have been added, for expansion (header), definition (body) and time period.

By default, they use theme_box, but can be overriden by themes.

The same version also removes some unneeded DIV wrapping in blocks.

#3

Anonymous - May 28, 2006 - 08:46
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.