Download & Extend
Node import » Issues

trouble with drupal_retrieve_form() in node import

Posted by medenfield on November 18, 2009 at 4:34am
Project:Node import
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi,

I'm receiving an error message on step 7 I believe may be due to running 6.14 on the latest version of XAMPP, which runs php 5.3:

warning: Parameter 2 to drupal_retrieve_form() expected to be a reference, value given in E:\webserver\xampp\htdocs\database\sites\all\modules\node_import\node_import.inc on line 1842

Just wanted to document it and see if anybody else is experiencing this issue.

Michael

Login or register to post comments

Comments

#1

Posted by medenfield on November 18, 2009 at 4:43am

Actually...this is an easy fix. I just changed line 1842 from

  $form = call_user_func_array('drupal_retrieve_form', $args);

to
  $form = call_user_func_array('drupal_retrieve_form', &$args);

I dunno if it merits a patch or not...but that's the fix for it.

#2

Posted by medenfield on November 18, 2009 at 4:43am
Status:active» closed (fixed)

#3

Posted by karthick62 on February 2, 2010 at 1:08pm

cool!! it works!! Thanks much~

#4

Posted by bneel on February 17, 2010 at 1:31pm
Status:closed (fixed)» patch (to be ported)

Yes It works and I think it needs to be ported, do you ?
B

#5

Posted by abbasmousavi on April 11, 2010 at 12:44pm

I have tested it and it works, please add it to cvs before RC5

thanks

#6

Posted by rodrixXx on April 11, 2010 at 6:30pm
Category:bug report» task
Priority:normal» critical
Status:patch (to be ported)» needs work

#7

Posted by OhSnapNo on April 18, 2010 at 7:53pm

I'm getting the same error and the fix by medenfield @ #1 DOES NOT work, it only introduces other errors.
So the problem is still: content is imported without errors/warnings but doesn't get saved to db.

EDIT:
i get four errors related to these "successful" imports:
ERROR 1
Location: http://localhost/drupal/admin/content/node_import/add
Referer: http://localhost/drupal/admin/content/node_import/add
Info: mb_strlen() expects parameter 1 to be string, array given in C:\xampp\htdocs\drupal\includes\unicode.inc on line 404.

Error 2
Location: http://localhost/drupal/admin/content/node_import/add
Referer: http://localhost/drupal/admin/content/node_import/add
Info: Parameter 2 to drupal_retrieve_form() expected to be a reference, value given in C:\xampp\htdocs\drupal\sites\all\modules\node_import\node_import.inc on line 1842.

Error 3
Location: http://localhost/drupal/admin/content/node_import/9/continue
Referer: http://localhost/drupal/admin/content/node_import/9
Info: Parameter 2 to drupal_retrieve_form() expected to be a reference, value given in C:\xampp\htdocs\drupal\sites\all\modules\node_import\node_import.inc on line 1842.

Error 4
Location: http://localhost/drupal/admin/content/node_import/9/continue
Referer: http://localhost/drupal/admin/content/node_import/9
Info: mb_strlen() expects parameter 1 to be string, array given in C:\xampp\htdocs\drupal\includes\unicode.inc on line 404.

#8

Posted by Robrecht Jacques on April 22, 2010 at 8:57pm

Could you try the fix in http://drupal.org/node/763036 ?

#9

Posted by kbk on October 5, 2010 at 2:38pm
Status:needs work» reviewed & tested by the community

Change outlined in #1 works for me. #7 looks like a different beast plus no response was given. Marking as Reviewed to keep this moving.

Thanks for your work on this module.

#10

Posted by mpflaging on October 15, 2010 at 11:11pm

#1 worked for me too.

#11

Posted by kbk on October 16, 2010 at 3:33am
Status:reviewed & tested by the community» needs work

I'll run a patch for this next week if no one beats me to it.

#12

Posted by watcha on October 21, 2010 at 9:07am

The World's smallest patch lives here

AttachmentSize
node-import-drupal-retrieve-form-635788-12.patch 513 bytes

#13

Posted by watcha on October 22, 2010 at 4:10am
Status:needs work» reviewed & tested by the community

#15

Posted by ss_truepal on November 16, 2010 at 11:36am
Title:trouble with drupal_retrieve_form() » trouble with drupal_retrieve_form() in node import

The solution posted by edenfield works well. Thanks dude.

#16

Posted by cannanso on November 21, 2010 at 8:25am

#12 patch works great. Thanks!

#17

Posted by micheleannj on December 2, 2010 at 5:29pm

subscribing

#18

Posted by levacjeep on December 15, 2010 at 5:21pm

#1 worked for me, but I had to apply to current dev version on line 1973.

#19

Posted by gateway69 on January 4, 2011 at 10:05pm

confirmed on my end as well php 5.3 issue :) prob should roll it into a new release

#20

Posted by notrab on January 6, 2011 at 4:11am

This fixed my issue as well. Thanks for the help.

#21

Posted by joe3zzz on January 16, 2011 at 6:52am

after applying this, blank white screen where import step 7 should be, when importing a CCK content type.
Fatal error: Cannot unset string offsets in .../image/contrib/image_attach/image_attach/image_attach.module on line 397
This fixed it http://drupal.org/node/952732

#22

Posted by puregin on February 4, 2011 at 10:13pm

It would be nice to see a new release with the patch (#12). As more and more people move to php5.3, this issue will prevent them from using this module.

#23

Posted by RoSk0 on February 6, 2011 at 9:22pm

#1 worked for me, but I had to apply to current dev version on line 1973.
php 5.3.5

#24

Posted by zaglick on February 11, 2011 at 6:25pm
Priority:critical» normal

#1's patch works for me

#25

Posted by Robrecht Jacques on February 27, 2011 at 9:47am
Version:6.x-1.0-rc4» 6.x-1.x-dev
Status:reviewed & tested by the community» fixed

#26

Posted by System Message on March 13, 2011 at 9:51am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here