Hi,

I'm receiving an error message on step 7 I believe may be due to running 6.14 on the latest version of XAMPP, which runs php 5.3:

warning: Parameter 2 to drupal_retrieve_form() expected to be a reference, value given in E:\webserver\xampp\htdocs\database\sites\all\modules\node_import\node_import.inc on line 1842

Just wanted to document it and see if anybody else is experiencing this issue.

Michael

CommentFileSizeAuthor
#12 node-import-drupal-retrieve-form-635788-12.patch513 byteswatcha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

medenfield’s picture

medenfield CreditAttribution: medenfield commented

Actually...this is an easy fix. I just changed line 1842 from 

  $form = call_user_func_array('drupal_retrieve_form', $args);

to

  $form = call_user_func_array('drupal_retrieve_form', &$args);

I dunno if it merits a patch or not...but that's the fix for it.

medenfield’s picture

medenfield CreditAttribution: medenfield commented
Status: Active » Closed (fixed)
karthick62’s picture

karthick62 CreditAttribution: karthick62 commented

cool!! it works!! Thanks much~

bneel’s picture

bneel CreditAttribution: bneel commented
Status: Closed (fixed) » Patch (to be ported)

Yes It works and I think it needs to be ported, do you ?
B

abbasmousavi’s picture

abbasmousavi CreditAttribution: abbasmousavi commented

I have tested it and it works, please add it to cvs before RC5

thanks

rodrixXx’s picture

rodrixXx CreditAttribution: rodrixXx commented
Category: bug » task
Priority: Normal » Critical
Status: Patch (to be ported) » Needs work
OhSnapNo’s picture

OhSnapNo CreditAttribution: OhSnapNo commented

I'm getting the same error and the fix by medenfield @ #1 DOES NOT work, it only introduces other errors.
So the problem is still: content is imported without errors/warnings but doesn't get saved to db.

EDIT:
i get four errors related to these "successful" imports:
ERROR 1
Location: http://localhost/drupal/admin/content/node_import/add
Referer: http://localhost/drupal/admin/content/node_import/add
Info: mb_strlen() expects parameter 1 to be string, array given in C:\xampp\htdocs\drupal\includes\unicode.inc on line 404.

Error 2
Location: http://localhost/drupal/admin/content/node_import/add
Referer: http://localhost/drupal/admin/content/node_import/add
Info: Parameter 2 to drupal_retrieve_form() expected to be a reference, value given in C:\xampp\htdocs\drupal\sites\all\modules\node_import\node_import.inc on line 1842.

Error 3
Location: http://localhost/drupal/admin/content/node_import/9/continue
Referer: http://localhost/drupal/admin/content/node_import/9
Info: Parameter 2 to drupal_retrieve_form() expected to be a reference, value given in C:\xampp\htdocs\drupal\sites\all\modules\node_import\node_import.inc on line 1842.

Error 4
Location: http://localhost/drupal/admin/content/node_import/9/continue
Referer: http://localhost/drupal/admin/content/node_import/9
Info: mb_strlen() expects parameter 1 to be string, array given in C:\xampp\htdocs\drupal\includes\unicode.inc on line 404.

Robrecht Jacques’s picture

Robrecht Jacques CreditAttribution: Robrecht Jacques commented

Could you try the fix in http://drupal.org/node/763036 ?

kbk’s picture

kbk CreditAttribution: kbk commented
Status: Needs work » Reviewed & tested by the community

Change outlined in #1 works for me. #7 looks like a different beast plus no response was given. Marking as Reviewed to keep this moving.

Thanks for your work on this module.

mpflaging’s picture

mpflaging CreditAttribution: mpflaging commented

#1 worked for me too.

kbk’s picture

kbk CreditAttribution: kbk commented
Status: Reviewed & tested by the community » Needs work

I'll run a patch for this next week if no one beats me to it.

watcha’s picture

watcha CreditAttribution: watcha commented
FileSize
node-import-drupal-retrieve-form-635788-12.patch513 bytes

The World's smallest patch lives here

watcha’s picture

watcha CreditAttribution: watcha commented
Status: Needs work » Reviewed & tested by the community
ss_truepal’s picture

ss_truepal CreditAttribution: ss_truepal commented
Title: trouble with drupal_retrieve_form() » trouble with drupal_retrieve_form() in node import

The solution posted by edenfield works well. Thanks dude.

cannandev’s picture

cannandev CreditAttribution: cannandev commented

#12 patch works great. Thanks!

micheleannj’s picture

micheleannj CreditAttribution: micheleannj commented

subscribing

levacjeep’s picture

levacjeep CreditAttribution: levacjeep commented

#1 worked for me, but I had to apply to current dev version on line 1973.

gateway69’s picture

gateway69 CreditAttribution: gateway69 commented

confirmed on my end as well php 5.3 issue :) prob should roll it into a new release

notrab’s picture

notrab CreditAttribution: notrab commented

This fixed my issue as well. Thanks for the help.

joe3zzz’s picture

joe3zzz CreditAttribution: joe3zzz commented

after applying this, blank white screen where import step 7 should be, when importing a CCK content type.
Fatal error: Cannot unset string offsets in .../image/contrib/image_attach/image_attach/image_attach.module on line 397
This fixed it http://drupal.org/node/952732

puregin’s picture

puregin CreditAttribution: puregin commented

It would be nice to see a new release with the patch (#12). As more and more people move to php5.3, this issue will prevent them from using this module.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 commented

#1 worked for me, but I had to apply to current dev version on line 1973.
php 5.3.5

zaglick’s picture

zaglick CreditAttribution: zaglick commented
Priority: Critical » Normal

#1's patch works for me

Robrecht Jacques’s picture

Robrecht Jacques CreditAttribution: Robrecht Jacques commented
Version: 6.x-1.0-rc4 » 6.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.