Closed (fixed)
Project:
Quotes
Version:
5.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
15 May 2006 at 14:36 UTC
Updated:
1 May 2008 at 18:02 UTC
Jump to comment: Most recent file
You currently cannot disable the "my quotes" entry in the menu. You should be able to.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | quotes_myquotes2.patch | 2.69 KB | seanbfuller |
| #5 | quotes_myquotes.patch | 1.58 KB | seanbfuller |
Comments
Comment #1
jhriggs commentedDrupal's menu system does not currently allow administratively-controlled dynamic menu items like this. So, just as you cannot disable 'my account', 'my blog', etc., you cannot disable 'my quotes'.
Comment #2
solipsist commentedSo how do I get rid of it? Hacking core?
Comment #3
jhriggs commentedYou can just edit the quotes.module file and remove that entry in the array() created in quotes_menu(). That is, simply delete or comment out lines 65-70:
Comment #4
solipsist commentedThank you very much for your help and for the module! :)
Comment #5
seanbfuller commentedhere is a small patch that adds a setting option to disable or enable the "my quotes" menu link.
Comment #6
seanbfuller commentedSorry, forgot to mark this for review.
Comment #7
solipsist commentedThanks Sean!
Comment #8
seanbfuller commentedUpdated version that also includes a setting for turning on/off the %name's quotes link at the bottom of nodes.
Seemed like these two were similar functions, so I put them in a fieldset and rolled them both into this one patch.
Comment #9
fm commentedMight these changes be incorporated into the module proper?
Thank you in advance for a promptly updated module!
Comment #10
fm commentedDoes this patch work on release 5.x-1.1?
This is a great module and a much appreciated patch. Just out of curiosity, why wasn't the patch incorporated into the new release?
Comment #11
alexandreracine commented+1 for this.
Can the author patch this?
Comment #12
nancydruJust go into the module. Locate the the last line of that menu entry (line 70), which says "'type' => MENU_DYNAMIC_ITEM". Put "//" in the first two columns. Save the module.
Now your menu item is no longer "locked" and you can disable it.
Comment #13
beginner commentedthe patch is the wrong approach.
The menu item should be put in
if (!may_cache) {}and the menu type should beMENU_NORMAL_ITEM.It is actually a bug.
Comment #14
mariagwyn commentedWhere does this stand? Is it a patch or a bug that will be fixed? I would like to be able to disable 'my quotes' without modifying the module if possible.
Thanks,
Maria
Comment #15
sunfish62 commentedI, too, would like to know what action to take to fix this problem. It's been three months since Maria's message received no reply.
Comment #16
nancydru#12 is very easy even if you don't know php.
Based on the statistics (http://drupal.org/project/issues/statistics/quotes) for this module, I'd say it is close to being abandoned.
Comment #17
nancydruThe fix in #13 is done. I will look further at Sean's suggestions.
Comment #18
nancydruMarking http://drupal.org/node/244555 as a duplicate of this.
Comment #19
nancydruThe full patch has been committed to both of the -dev versions.
There are new settings to disable the "My quotes" menu item and the "xxx's quotes" links.
Note: The 6.x version includes a link to the performance settings page where the menu can be forced to be rebuilt (the "clear cache" button) if you change the menu setting.
Comment #20
samirnassar commentedAbandoned? Personally speaking I just started using it and am loving it.
Comment #21
nancydruNo, this module is no longer abandoned. I am actively maintaining it.
Comment #22
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.