Drupal 7 port

subscribing

subscribing

I have not looked at whether fields API could/should be leveraged for D7.

There are no plans on porting this to D7 at present. It is all driven by community volunteers. So if someone wants this to happen for D7 sooner, please submit patches that convert the module to D7 AND several of the most important contributed modules should follow as well (an API alone is not very useful).

Also, the following features are nice to have for D7, rather than in D6 because they impact lots of modules:

#417830: float support
#668284: hook_userpoints pass $params by reference

Subscribing...

+1 subscribing. It would be great to have D7 version of userpoints available for testing in D7 alpha.
Would anyone be able to help with the porting? I can help with testing as soon as patches are available.
Many thanks!

subs

Another one that should go in D7

#524104: Replace "insert" in userpoints_txn with a more descriptive operation

Drupal 7 alpha 2 has been released =)
http://drupal.org/drupal-7.0-alpha2

This effort needs volunteers, it will not happen magically.

I hope to be able to contribute by being available for testing asap.
I'm sorry I can't help with the actual porting bc I am not familiar with programming.
I'm very excited about Drupal 7 (currently installing drupal 7 alpha 2) and can't wait to test User Points module.

Thanks for your continuing hard work!

Is anyone else subscribing on this thread able to do some of the initial coding on this? I'm willing to help, but still quite new to the Userpoints module (need it for an upcoming D7 project). We just need someone with experience to get the ball rolling...

@kbahey - I realize that you don't need Userpoints upgraded to D7 for any of your active client work, but I'm wondering if you're open to a paid bounty (whatever you think is appropriate) to at least get the ball rolling on the Userpoints API.

If you don't have the time or interest to do the work (in exchange for the bounty) is there anyone else who has been active in the Userpoints issue queues who you might suggest?

I just know that with a module of this level of complexity, it's helpful to have someone who is already familiar with the code. Any suggestions on who to contact or how to go about this would be much appreciated.

Thanks,
Ben

subscribe

@BenK

Paid bounties are fine, but from past experience, they take a long time to raise, and by the time that happens, our schedule may not allow us to start immediately. The other drawback is that there will be whiners who will balk at how expensive this is, and that they can do it for less.

Let me be clear: anyone can create a patch, however they want, paid or unpaid. This is what happens for the D5 to D6 upgrade. So whichever way it happens, I will review the code after it gets tested enough and confirmed to be working, and will commit it.

I can event grant CVS access to such a person. It happened before with jredding and others. All I ask for is quality: someone with a proven track record of contributing good code, and a responsible maintainer. Someone who will be mindful of a migration path, and not leave existing users high and dry, nor introduce bugs along the way and then disappear.

If you find such a person, and pay them, I am fine with that.

One more here: #786382: Now incompatible with last DEV release from UserPoints module

Subscribe.

I will look into porting the module to D7 in ~2 weeks. I'm not yet sure if I find the time to maintain the ported branch, maybe... (@kbahey: As you know, I'm maintaing the Privatemsg module, am currently porting User relationships to D7 and have ported a quite big part of Drupal core to DBTNG, so that shouldn't be an issue :) )

I had to free my mind before my exams are starting so I did an initial port of the module...

BenK already knows the drill, the code is on my github account for now. I will provide a patch when it's stable but for now, it's easier to share and work on github for me. URL: http://github.com/Berdir/userpoints

If you don't have git installed, you can click on the download source link in the top right.

Nothing fancy yet, just a plain port, mostly DBTNG, theme and arg() changes, most basic stuff seems to work, what's not yet working: user profile view (strange warnings/notices and doesn't show up as expected), taxonomy integration (vocab was created but tags are not integrated altough core seems to have bugs there anyway...).

Hey Berdir,

That's awesome! I'll start testing right away...

--Ben

No need to hurry, I worked a bit on the tests today but there are still a few tests fails, something is not yet working correctly when counting together the points.

I have now fixed the remaining tests, so you can go ahead with testing.

If you had the module already installed, you need to uninstall and re-install as I had to change an index to an unique to make the merge query work At least until a related core issue is resolved.

However, without the userpoints_contrib modules being ported too, there isn't much to test, you can just add some points manually :) Will start with that later...

Sounds good. Okay, I'll test whatever I can and report back.

Also, a primary use case for me is using the Rules module to award userpoints (for any events supplied by other modules that also integrate with Rules). So if you have a chance to take a look at the userpoints_rules submodule, it might make things a bit easier to test since it'll be easier to award points.

Cheers,
Ben

Not yet, but I will look into that soon.

What's a bit strange is that the userpoints_rules.info file is missing in DRUPAL-6--1, while the .module and .rules.inc files exist. Any reason for that?

Hmmm.... I just downloaded the userpoints 6.x-1.x-dev tarball (http://drupal.org/node/239092) and found the userpoints_rules.info file inside. Did you get your code from somewhere else?

The module appears to be in the repository for this tag. Check the link.

Hey Berdir,

I just completed some preliminary testing of your initial D7 port. First of all, thanks again for all of your hard work on this. For a first pass, quite a lot of things seem to be working well. Nice job.

So here is a list of the initial bugs I found:

A. On the Site Permission's page (admin/people/permissions), there are three rows for Userpoints permissions, but the actual names of the permissions are entirely blank/missing. I still see the category name "Userpoints" and the checkboxes for each role, but names and descriptions of each permission are missing.

B. I'm getting a new error message when visiting the Site Permission's page (admin/people/permissions):

"Notice: Undefined index: title in user_admin_permissions() (line 692 of /home/sandboxes/sandbox10/public_html/modules/user/user.admin.inc).
Notice: Undefined index: title in user_admin_permissions() (line 692 of /home/sandboxes/sandbox10/public_html/modules/user/user.admin.inc).
Notice: Undefined index: title in user_admin_permissions() (line 692 of /home/sandboxes/sandbox10/public_html/modules/user/user.admin.inc)."

I'm not sure if this is related to the Userpoints module, but I didn't notice this before. So it likely could be related to "A" above.

C. Non administrator users can't access either the My Userpoints page (/myuserpoints) or the All Points page (/userpoints). This could be related to the permission page bugs (only the administrator role has any permissions checked), but since I can't view name of each permission, I can't see if this needs to be set for a certain role.

D. In the site's "Navigation" block, the "My Points" link and "Users by points" links are not being shown for users who don't have the administrator role. This could be related to the permissions page problems described in A, B, and C.

E. On the settings page (admin/config/people/userpoints/settings) under "Points Categorization," the link to the Userpoints taxonomy is wrong. Currently the link is pointing to "admin/content/taxonomy/2" but it should instead be pointing to "admin/structure/taxonomy/userpoints".

F. When points are in moderation and you click the "edit" link to change some of the points information, the following error message is printed on the screen:

Notice: Undefined variable: expirydate in userpoints_admin_txn() (line 1128 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).

Note that I did not specify an expiration date for the points (I left that field blank), so the error is probably related to that.

G. The word "Array" is being printed at the top (above the table) of the "List" page (admin/config/people/userpoints), the "Moderation" page (admin/config/people/userpoints/moderate), and the "All points" page (/userpoints).

H. On the "Moderation" page, the "User" column is incorrect. "Anonymous (not verified)" is being displayed instead of the actual user being awarded points.

I. There is a field for "Operation Type" when editing points in the moderation queue (you can change the operation type while it is in moderation), but this field is not present when you visit the add points page (admin/config/people/userpoints/add). The administrator should be able to specify this field from the beginning.

J. On the "Moderation" page after clicking "approve," the following error message is displayed on the top of the approval confirmation page:

"Warning: htmlspecialchars() expects parameter 1 to be string, array given in check_plain() (line 1473 of /home/sandboxes/sandbox10/public_html/includes/bootstrap.inc)."

This same bug occurs if you click "decline" instead.

K. On the "Moderation" page after clicking "approve," the following title is being displayed on the approval confirmation page:

"Are you sure you want to txn approve"

Obviously, "txn" shouldn't be there... but is "txn" meant to be replaced by something else? There should also be a question mark at the end of the line. This same bug occurs if you click "decline" instead.

L. On the approval confirmation page, I can't actually approve a points award after clicking "Confirm." Instead, the page reloads and the following duplicate errors are displayed:

"Warning: htmlspecialchars() expects parameter 1 to be string, array given in check_plain() (line 1473 of /home/sandboxes/sandbox10/public_html/includes/bootstrap.inc).
Warning: htmlspecialchars() expects parameter 1 to be string, array given in check_plain() (line 1473 of /home/sandboxes/sandbox10/public_html/includes/bootstrap.inc)."

The points are not approved and the points award stays in the moderation queue. This same bug occurs if you click "decline" instead.

M. For a points award in the moderation queue, points can be successfully awarded by clicking "edit" and then manually changing the radial buttons from "pending" to "approved." However, when the points are approved in this manner, the following error message occurs on the confirmation page:

"Notice: Undefined variable: expirydate in userpoints_admin_txn() (line 1128 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).
Notice: Undefined variable: expirydate in userpoints_admin_txn_submit() (line 1277 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module)."

This error also occurs if the radial buttons are manually changed to "declined."

N. When viewing a user's points at /myuserpoints/[uid], the "Description" field reads "None" even though a description was entered when the points were created.

Thanks again for all of your help, Berdir. Let me know if any of this is unclear or requires more testing....

Cheers,
Ben

Berdir,

I recently noticed some additional errors when displaying the module's "User's points" block:

O. When displaying the "User's points" block to a user with administrative permission, the following errors are displayed:

    *  Notice: Undefined variable: user in userpoints_block_view()  (line 1519 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).
    * Notice: Undefined variable: user in userpoints_block_view() (line 1521 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).
    * Notice: Trying to get property of non-object in userpoints_block_view() (line 1521 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).

Additionally, the following code displays on the page to the administrator in place of the actual block:

"<span class="username" xml:lang="" typeof="sioc:UserAccount" property="foaf:name">Anonymous (not verified)</span>'s points   Points are visible to logged in users only"

So it appears that the block thinks the user is anonymous even when he is logged in...

The error message is different when non-administrative users view the block:

    *  Notice: Undefined variable: title in userpoints_block_view()  (line 1557 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).
    * Notice: Undefined variable: content in userpoints_block_view() (line 1558 of /home/sandboxes/sandbox10/public_html/sites/all/modules/contrib/userpoints/userpoints.module).

As always, I look forward to hearing your thoughts!

Cheers,
Ben

A-D: I used the wrong key for the permission name. Should be fixed now, and the links should be visible once you given permissions.

E: fixed

F: Should be fixed too

G: fixed

H: fixed

I: This is working as supposed to from what I see from the source code, similiar to the other fields which are only displayed when editing. I don't want to change the *behavior* of the module (at least not for now)

J: fixed

K: Again, this is working as supposed according to the source code. Well not exactly, after fixing J, approve/decline is now before txn: t('Are you sure you want to @op txn @txn_id', array('@op' => $operation, '@txn_id' => $txn_id)). This is a bug, especially since this makes it impossible to correctly translate into languages like russia. There are actually many translation bugs, starting with t($term_name), which is not how t() is supposed to be used.

L: Same bug as above, fixed.

M: Also, same bug as one above, should be fixed now.

N: fixed

Also fixed the block related notices and moved the "My points" menu item to the user menu (as I did with My relationships and Messages).

Pushed to github, happy testing.

Re: the missing userpoints_rules.info file. Something seems to be broken with the CVS status of that file, as you can see here: http://drupalcode.org/viewvc/drupal/contributions/modules/userpoints/?pa... (no revision, commit info, ...) and has probably not been imported by git because of that. I will add it myself but I guess the patch will then not apply cleanly because of that.

I've pushed a first version of the rules integration. action/event should work but the configuration forms are not very usable yet.

Subscribing

Looks good, Berdir.
I'd move the admin pages to a separate include.
Thought about using the Field API for points, but since it's not just the points, but other info too (tid, timestamp, max_points), it would have to be a userpoints entity, and not a field attached to the user (because of the extra tid), so I'm not sure the extra work required would even be beneficial (points probably don't need fieldability or revisions)...

I will be doing userpoints integration with Affiliate-NG, and when that happens I'll have more feedback.

Hey Berdir,

Thanks for your latest fixes (described in comment #28). Things are working a lot better. I went through all of your fixes and here are the outstanding issues I found. If I don't mention the issue below, then I have confirmed it is fixed. So here are the remaining issues:

C. Users who don't have any points yet can't access their /myuserpoints page even though they have "View own UserPoints" permission. Instead, they receive an "Access Denied" error. This page should probably be accessible to all users with this permission even though they may not have any points yet (such as new users).

D. Users who don't have any points yet don't see the "My Points" link in the User Menu (even though they have "View own UserPoints" permission).

K. Do you want to hold off on changing this for now?

New Issues:

1. When an administrator approves points in the moderation queue, the confirmation message printed to the page is not an actual sentence. Here's what's printed (depending on whether it is approved or denied):

Declined: "User editor 6 points Total now is 0 points."

Approved: "User editor 8 points Total now is 8 points."

Instead, it should be a complete sentence like it is for when points are added to moderation ("User editor earned 8 points, pending administrator approval."). A possible sentence structure could be: "User editor has been approved for 6 points. User editor now has 6 total points."

2. The printed message described above has the wrong points total. The total points listed appears to be only for the category being awarded points at the time. So if a user already has 10 points in Category A and is awarded 5 points in category B, the total will show only 5 points. So either the message should indicate that this is a total only for the category ("User editor now has 5 total points in the Category B category.") or else all categories points should be totaled. What do you think?

3. If you have defined a points category ("New Category") and assigned the points block for that category ("Highest New Category Points") to a region, but no points in that category have yet been awarded on the site, then the following error message is displayed on every page with the block:

Notice: Undefined variable: rows in userpoints_block_view()  (line 1562 of /Users/benkaplan/git/drupal/sites/all/modules/contrib/userpoints/userpoints.module).

4. A user with "View all UserPoints" permission still can't view the myuserpoints/[uid] page for any user. This is despite the fact that the user with "View all UserPoints" permission does see a "View" link next to a user's points total on the user's profile page (user/[uid]).

Let me know your thoughts and if you need any more details. I'll now begin testing the Rules integration and the Userpoints Contrib sub-modules.

Cheers,
Ben

@bojanz: I guess if we make userpoints to a field, we could actually drop the whole taxonomy/category stuff. Because if you want different categories of points, you can simply add multiple fields which different names and so on. However, this is certainly something that needs some thinking and should only be done once it is ported.

C: According to the current code, that seems to be by definition, so it's not a "bug". It's rather strange though, but I suggest to postpone that. However, the check is wrong anyway because it always looks if the currently logged in user points, not the user we are viewing.

D: That is the same as C. Menu links are visible if access is allowed.

K: Yep.

1. That is not nice, but I haven't changed the strings, so that was there before. If we make this a straight port, then it is going to be easier to port bugfixes to other branches.

2. I don't really get the whole category stuff yet. But yes, it usually only shows points of a single category.

3. Fixed

4. This is inconsistent, but I'm not sure how it is supposed to work. The access callback checks the 'View userpoints' permission, but in the page callback, the administer userpoints permission is required. The whole stuff is strange anyway. I'm pretty sure though that this is nothing that I've introduced in the port....

There's something strange going on in CVS for userpoints/userpoints_contrib...

Files which did not have a recent commit (as in, during the last 20 month or so), don't have a revision/age/anything. It seems that because of that, they are not mirrored with git.

In userpoints_contrib, most files don't show up because of that, see for example
http://drupalcode.org/viewvc/drupal/contributions/modules/userpoints_con... (all missing)
http://drupalcode.org/viewvc/drupal/contributions/modules/userpoints_con... (.install missing)

Hmmm... Are you planning on adding the files manually to github? I was planning on doing more testing this week.

--Ben

Berdir

I can give you CVS commit access.

We can create a DRUPAL-7--1 branch and you can do with it what you want, even have a -dev tarball being generated daily from it. This will make testing easier.

Do you want that?

That sounds great, yes.

I just said to BenK yesterday in IRC that we're at a point where it is getting easier to fix the remaining bugs in single issues. And I know that he is going to open *lots* of issues ;)

I can also backport bug fixes to 6.x where applicable but will leave any decisions about committing those to you.

What do you think about enabling automatic testing for userpoints?
There are already a few tests (I think some fail on D6 too, that would need to be fixed first) and automatically tested patches are a real timesaver, not to mention that having the number of test assertions below every patch is a big motivator to write more tests ;) The number of tests for Privatemsg has pretty much exploded...

I won't be able to maintain userpoints like I'm trying to maintain privatemsg but I'll do what I can :)

Berdir

You have CVS commit access now.

Go ahead and create a DRUPAL-7--1 branch, and commit your code to it. Close this issue when you have a "mostly working" branch (some bugs left is acceptable).

Please be careful with the port: focus on getting it working for D7, and avoid the urge to add new features. Think twice before breaking compatibility, or impacting the API too much.

Hey everyone,

Berdir and I had a nice chat in IRC. He requested that before he creates the official 7.x branch that I summarize the current state of the D7 port (what currently works and what doesn't yet work). So that's what I'm doing below. Note that I plan to create individual issues for all of the items that don't work once we have the new 7.x branch (unless Berdir fixes some of the easy ones before he creates the branch).

So I apologize for the length of this message. But I promise that it is fairly comprehensive! ;-)

WHAT CURRENTLY WORKS (PLEASE THANK BERDIR!)

* POINTS MODERATION: You can approve, decline, and edit points. This works great!

* POINTS AUTO APPROVAL: If moderation is turned off, everything works well, too.

* PERMISSIONS: User permissions (View all UserPoints, View own UserPoints, and Administer Userpoints) seem to be cleaned up and working well.

* POINTS EXPIRATION: You can set points to expire when adding them manually. You can also set points expiration defaults on the module configuration page. Both expiration methods seem to be working well.

* POINTS BRANDING: Changing the name "Points" to some other branded term works throughout the UI (with just a couple exceptions).

* POINTS CATEGORIES: You can use D7's taxonomy system to easily create points categories. This works well.

* BLOCKS: All of the Userpoints supplied blocks seem to work fine. (This includes the current user's points block and blocks for the highest point earners in each category.)

* MENU: Links inserted by Userpoints into the User Menu and Navigation Menu seem to work fine.

* MESSAGES: Messages displayed to user when points are awarded seem to work fine. There are some bugs here that already existed in the module (and are not from the D7 port), which we can fix later.

* USERPOINTS RULES EVENT: The "User was awarded points" rules event (Userpoints Rules sub-module) seems to be working well.

WHAT DOESN'T YET WORK

A. FORM ERROR MESSAGES: On a couple forms (notably the Add Points form), error messages aren't displayed when the user fails to enter certain required fields.

B. EXPIRATION DATE AND USERPOINTS RULES: When points expire, the expiration process appears to change the datestamp on the initial award date. Instead, it should only affect of the date of the expired points transaction. Basically, the initial award is being re-added at the time of expiration. This causes added problems because the Userpoints Rules sub-module triggers actions when points are awarded... thus, rules actions that should only happen on the initial points award are being triggered again on expiration of the points.

C. EXPIRATION CATEGORY: When points expire, the expired points transaction does not retain the original category. Instead, all expired points transactions are part of the "Uncategorized" category (which may have been re-named by the site administrator). It is important that the expired points transaction use the same category as the initial points award because rankings of users by points per category (such as in the many blocks supplied by the module) are incorrect otherwise.

D. FILTERING BY CATEGORY: Filtering user point totals by category does not appear to work at /userpoints (the "Users by Points" page) or admin/config/people/userpoints/moderate (the Points Moderation page).

E. ZERO POINT USERS: Some blocks do not appear to acknowledge the "Display zero point users?" setting on the module configuration page.

F. USERPOINTS RULES CONDITIONS: None of the four Userpoints-related conditions appear to be working. When using "Check the transaction category," there is no field to specify which category to check. When using "Compare userpoints before the transaction," "Compare current userpoints," or "Compare the transaction amount," there is no field to actually input the number of points to be compared. As a result, when executing rules with these conditions it results in the following error message: "Notice: Undefined index: type in userpoints_rules_amount_before() (line 205 of /Users/benkaplan/git/drupal/sites/all/modules/userpoints/userpoints_rules.rules.inc)."

G. USERPOINTS RULES CONDITIONS BRANDING: There are a few strings in Userpoints Rules Conditions that are not properly branded with the admin's branded points terminology. Pretty minor stuff.

H. USERPOINTS RULES ACTIONS: The "grant points to a user" action is not yet working. In particular, a lot of data selectors seem to be incorrect and there seem to be a lot of extraneous fields on the configuration form.

I. USERPOINTS SERVICE SUB-MODULE: We haven't tried to port this. I don't have any experience with the Services module and I'm not sure if Berdir does either.

So the bottom line is that there aren't many items left to fix: Much more is working than isn't working. What I haven't yet tested is the current state of the D7 port of User Points Contributed modules (userpoints_contrib), but I will do so shortly. One question for Berdir is whether he wants 7.x commit access for userpoints_contrib (so that we can work in the issue queue) or if he would rather continue to work on that via github.

Cheers,
Ben

subscribing - thanks for the great work Berdir and BenK!

I was wondering about User Points-Views Integration in D7? Fields to show userpoints, categories, add points, remove points, clear points, etc.
I'm also hoping for D7 port of Ubercart User Points #731026: Ubercart Userpoints Port to Drupal 7 but I think that's totally different?

Thanks!

That's a good point about Views Integration... I hadn't tested it yet. I just now completed a round of Views integration testing and it mostly does not appear to be working yet. So let me add one more item that needs to be fixed:

J. VIEWS INTEGRATION: Trying to add Userpoints-related fields to views doesn't work yet. In particular, trying to add fields like "Userpoints: Points," "Userpoints: Max points," and "Userpoints: Userpoints Category" to a view results in the following fatal error:

PHP Fatal error: Call to undefined function vpr() in /Users/benkaplan/git/drupal/sites/all/modules/views/handlers/views_handler_field.inc on line 99

Also, I'm getting the following warning message within the Views admin area when adding the above fields:

Debug: 'Missing join: node users' in views_get_table_join() (line 95 of /Users/benkaplan/git/drupal/sites/all/modules/views/includes/handlers.inc).

However, a few fields do seem to be working. These are mostly ones in the "Userpoints Transactions" group including:

* (Users) Userpoints Transactions: Description
* (Users) Userpoints Transactions: Changed
* (Users) Userpoints Transactions: Points
* (Users) Userpoints Transactions: Timestamp

Some other Userpoints Transaction fields, however, are reporting "Broken/missing handler" in the Views UI.

Also, I can't seem to find any Views fields that provide links to add and remove points. Were these fields in the latest 6.x version?

--Ben

BenK, thank you for you testing, it's awesome

Thanks for the test!

Changes:
- split the code into admin.inc, pages.inc and theme.inc. userpoints.module now has only half the size it has before.
- Verified that all tests pass

A. Made user and points filed required in the add points form.
B + C. Should be fixed too. I don't really like the current single-api-function-with-one-huge-array-argument-to-do-everything approach but I'm certainly not going to change in on the first 7.x branch :)
D. Fixed.

E. The problem is probably that "having zero points" and "not having points" is not the same thing. The first one does have an entry in {userpoints} and can be queried, the second case does not have that. Not sure what to do, it's not really a bug, technically speaking. The only way to solve this would be to either add 0 points entries for all users or always select on users and left join userpoints. Both are a bad idea performance-wise. Feel free to open an, though.

F-H. Let's handle rules integration in a single, separate issue. I need more time for that.

I. I never used it and it hasn't been ported yet (but the maintainer pledged, so a release should come sooner or later). Postpone until services.module is ported to D7.

J. At least the category field wrongly re-uses term_node views handler, that obviously doesn't work. And vpr() seems to be an internal views debug function that was removed and that call has been forgotten to remove. I suggest you open a bug report for Views 7.x-1.x. If that line is commented out, then at least the Userpoints (Haven't tested transactions) points work except category which is empty. And no, I don't think there are such links.

Most if not all of the above bugs (except the integration stuff) probably exist in D6 too. Can you verify and open separate bug repots (For bugs fixed in D7, directly for D6 and for bugs still open on D7 and then it can be backported).

I have pushed the changes to github and I'm going to create a new branch in CVS now...

Ok, I've commited everything to DRUPAL-7--1.

Hint: When switching from the old version to the new one, make sure to clean the cache and rebuild the menu so that it picks up the new files.

Thank you all for the great collaboration! This is how things should be ...

Berdir, you have commit access to userpoints_contrib now.

From now on, all D7 issues should be opened as new issues, and nothing further posted in this issue.

Thanks again.

Awesome! I just wanted to let everyone know that I created a new issue in the Userpoints Contrib module queue to summarize the current state of the D7 port of Userpoints Contrib. You can find the issue here:

http://drupal.org/node/869770

We'll have to ask Berdir if he wants to continue working on the D7 port of Userpoints Contrib on that thread or if he'd rather open up an official 7.x branch and start filing individual issues. At the very least, we could probably fix the bugs I reported with the Role Exempt and Userpoints Roles sub-modules.

Cheers,
Ben

I just wanted to let everyone know that I've created individual 7.x-1.x-dev issues for the two big outstanding bugs discussed above (F-H and K in the above list). These individual issue threads can be found here:

Fix Bugs in Views Integration
http://drupal.org/node/871126

Port Rules Integration
http://drupal.org/node/870268

--Ben