Fix Bugs in Views Integration

Try the attached patch. Make sure to empty the cache and submit admin/modules.

Field display, filter and argument seems to be working. By choosing the taxonomy term validator, you can even convert the term name to an id and use the category name instead of the id in URL's.

subscribing

I'm looking for the views category field fix for d6 version. Will this patch possibly be back ported in the future?
Regards

@robby.smith: Looks like the fix for d6 is simple, see #990620: UP Views: Broken/missing handler: userpoints_txn > tid

A. The patches fixes this. No idea why it's necessary, this all seems strange.

B. Can't reproduce, works for me. They fields are displayed and they work.

C. Confirmed, that seems to work sometimes and then it's broken again. But it has nothing to do with userpoints, it happens in all views and with alll integer fields. I looked for a existing views bug but didn't find one, I suggest you open one.

D. There is a separate feature request for that already existing.

E. That's something that you need to take care of when building the view, I don't think we should add any special cases and I wouldn't know how to anyway :)

F. Another issue that seems to work sometimes and doesn't anymore right now. No idea why that is, the all the fields can be sorted on with a static sort...

Term Validator: Add Category argument, Validator: Taxonomy Term, select Userpoints vocabulary, Argument type: Taxonomy name/synonym converted to Term ID. Note that it will for example not work for everything, for example General because that's not actually a term.
Attaching a new patch.

PS: Remember to clear the cache..

Can't create a proper patch, cvs is messing around.

Unzip this into the userpoints folder, clear cache and try again.

Commited!

Sorry to set it back active. Should I create a new post to request a 6.x backport? The title applies, but changing version to reflect a request for backport if allowed.

Thanks

For what exactly do you want a backport?

Did you see #990620: UP Views: Broken/missing handler: userpoints_txn > tid which seems to solve the broken/missing handler error for 6.x-1.x?

Ah, I must have missed the obvious. Setting it back to fixed now. Sorry for interruption.

Thanks.

Looks like this needs to be backported, the referenced issue does not seem to actually fix the problem.

This backport will save the world! (http://drupal.org/node/1018984#comment-3976896)

Thanks in advance!

Subscribe.

Also subscribing.

Ok, please test the attached patch.

Remember to clear the cache.

No one else is using this? This is great! Many many fixes!
You guys make a great team BenK and Berdir!

I only posted the patch 24h ago, so it's not surprising that nobody else is using it yet (or at least reported back).

Anyway, thanks for testing!

I will test it today or tomorrow... I will report asap.

Thanks for this patch!

Commited.

@Berdir, I still can't show categories in this simple view... please, did I miss something?

Versions:
Drupal 6.14
Views 6.x-2.11
Userpoints 6.x-1.x-dev (February 21, 2011)

It looks like it always shows the default category, will have to investigate.

Setting back to active.

I have just run into the same problem with the latest dev.

It looks to me like views_handler_field_term_node_tid.inc joins are not working correctly.

If I comment out query() function I get a users_userpoints__userpoints_txn.tid AS users_userpoints__userpoints_txn_tid field in my SQL, with the query() function in I don't get a tid field.

I think the joins need to be re-looked.

I am not very good at views development and have very little experience but I played around with things a little and I think maybe the tid fields (userpoints and userpoints_txn) should have a relationship added to their filed definition.

EG:

  // Describe the tid column of the userpoints table.
  $data['userpoints']['tid'] = array(
    'title' => t('Userpoints Category', userpoints_translation()),
    'help' => t('The categories (terms) of userpoints used', userpoints_translation()), // The help that appears on the UI,
    'field' => array(
      'handler' => 'userpoints_views_handler_field_category',
    ),
    'argument' => array(
      'handler' => 'userpoints_views_handler_argument_category',
      'numeric' => TRUE,
      'name field' => 'category', // display this field in the summary
    ),
    'filter' => array(
      'handler' => 'userpoints_views_handler_filter_category',
    ),
    'sort' => array(
      'handler' => 'views_handler_sort',
    ),
    'relationship' => array(
      'handler' => 'views_handler_relationship',
      'base' => 'term_data',
      'field' => 'tid',
      'label' => t('Userpoints Taxonomy Category'),
    ),
  );

I also removed the query() function from views_handler_field_term_node_tid.inc.

All this only started having an effect once I added the Category/Taxonomy relationship to my view and then setting the fields to use the relationship and in some configurations the category worked. In other configurations I also got errors for many of the userpoints_txn fields.

EG: "Column 'entity_id' in field list is ambiguous query" and "Column 'expired' in field list is ambiguous query".

I also tried adding the Entity id relationship but for some reason I could not use it as expected.

I feel like this views integration is so close to being complete/usable, but unfortunately I don't have skills or knowledge to complete it.
Hopefully somebody else will have better luck.

I think you need to add the term_data join to the actual term_data table, since userpoints is the base table. I could be wrong, but adding:

function userpoints_views_data_alter(&$data) {
  $data['term_data']['table']['join']['userpoints'] = array(
    'field' => 'tid',
    'left_field' => 'tid',
    'left_table' => 'userpoints'
  );
}

to the patch above worked perfectly for me. Rerolled patch from #26 to incorporate this change.

Yeah, that's what I had to do for the in the 7.x patch too.

Note that you can also define this in hook_views_data(), it will automatically be merged.

Also please add the same for the userpoints_txn table.

I have had another look at this and here are some of the changes I have made.
I wanted to submit a patch, but WinMerge and I are having issues, I think its an encoding issue (creating patches on Windows is retarded compared to Linux/BSD), so here are my changes the stupid way.

In userpoints.views.inc I added the a join on userpoints.uid, I don't know if this was needed but I was getting some SQL errors.

  $data['userpoints_txn']['table']['join'] = array(
    'userpoints' => array(
      'left_field' => 'uid',
      'field' => 'uid',
    ),
    'users' => array(
      'left_field' => 'uid',
      'field' => 'uid',
    ),
    'term_data' => array(
      'left_field' => 'tid',
      'field' => 'tid',
    ),
    // This goes to the node so that we have consistent authorship.
    'node_revisions' => array(
      'left_table' => 'node',
      'left_field' => 'uid',
      'field' => 'uid',
    ),
  );

In userpoints.views.inc I added a join on userpoints_txn as suggested.

/**
 * Implements hook_views_data_alter().
 */
function userpoints_views_data_alter(&$data) {
  $data['term_data']['table']['join']['userpoints'] = array(
    'field' => 'tid',
    'left_field' => 'tid',
    'left_table' => 'userpoints'
  );
  $data['term_data']['table']['join']['userpoints_txn'] = array(
    'field' => 'tid',
    'left_field' => 'tid',
    'left_table' => 'userpoints_txn'
  );
}

In userpoints_views_handler_field_category.inc I removed the init() function and altered my query() function to added the txn name field. I dont know why the init() function additional fields was not working, but moving it to query() fixed my problems. Maybe its because I am using views2.

  /**
   * Add this term to the query
   */
  function query() {
    $this->additional_fields['name'] = array('table' => 'term_data', 'field' => 'name');
    $this->ensure_my_table();
    $this->add_additional_fields();   
  }  

I hope that helps.

Well, I found the bug working with:

• Userpoints (userpoints) - 6.x-1.2
• Views (views) - 6.x-2.12

I solved redefining 'tid' with a simple relationship to term_data in userpoints.views.inc and using the fields from the new relationship ('Terms') :

  $data['userpoints']['tid'] = array(
    'title' => t('Userpoints Category', userpoints_translation()),
    'help' => t('The categories (terms) of userpoints used', userpoints_translation()), // The help that appears on the UI,
    'relationship' => array(
      'base' => 'term_data',
      'field' => 'tid',
      'label' => t('Terms'),
      'handler' => 'views_handler_relationship',
    ),
  );

I'm wondering if this could be a better approach: less code, less problems...

subscribing...

I apologize in advance for making this posting in the middle of what appears to be a hot and heavy search for a fix, but I am confused trying to follow all these comments. I don't write php code and am just trying to get the userpoints module to work with views.

I need to get the Points Category to display (using a userpoint transactions view as my starter) and only the default category seems to show no matter what I try. It's hard to tell from all the chatter here but has this been fixed through a patch or something? I am using Drupal 6.22, PHP 5.2.17, userpoints 6.x-1.x-dev and views 6.x-2.12.

Is there something about the 'relationships' settings under view that I need to do to make the categories work?

If this has not been fixed yet, I'll wait patiently but if it has been addressed, please let me know where to look to apply a patch or whatever.

Thanks,

Marc

@marcn
I got it working using the code posted at #37. The files were these changes are is userpoints_views_handler_field_category.inc and userpoints.views.inc.

It looks like the suggestion at #38 could work but I did not try it. With the code from #38 you will need to add a relationship for it to work. In this case the suggested code is changing the $data['userpoints']['tid'] tid field array definition.

There is no consensus on what would be best yet. I would try #38 first because it is simpler.

We can't just make it a relationship. Because that breaks the default category, that is not actually a term and will therefor not display anything.

Hi, Any updates on a D6 working patch?

Thanks!
Alejandro

Hi,

Just my 2 cents. Not a fix, but workaround for those who need this to work.
I needed to show the points splitted into categories, and any user could see each other points. I couldn't make this work through views and the category relationship after applying the patches and code above.

I could show categories and points per category in views by using the http://drupal.org/project/views_php module and executing the code below.
Steps:
1) add a relationship or a field that includes the uid so you get the uid variable available
2) add a Global: PHP field
3) In the Output code, added this code

$uid = $row->sender; //check for your available variables to get the uid
$up_categories = userpoints_get_categories();
$total_points = userpoints_get_current_points($uid, 'all');
print "Total points: " .$total_points. "<br />";

foreach ($up_categories as $category => $value){
  // don't show uncategorized points
  if ($category != '0'){ 	
    $points = userpoints_get_current_points($uid, $category);
    print $value . " " . $points . "<br />";
  }
} 

I know this doesn't fix the bug in any way, but it might help someone needing this now.

Any news regarding this bug?? I'm not a coder, but I really need the categories to work in views under Drupal 6.2. Is there anyone who could find a more or less clean solution? I've tried the code patches in the thread, and I get this message when trying to create a category field:
"Error: handler for userpoints > tid doesn't exist!"

Really, any help would be appreciated!

Closing this as outdated, 6.x version is no longer maintained.