Read More link not inserted properly when Smileys is enabled

djs_core: Can you verify that you're using RC5 and that you have selected the "Inline" option and have saved the settings page?

I'm not seeing a closing </p> in your screenshot of the code in your site. Could that have a bearing on it?

Yes. I see your tag closed, now how can this be explained...
My settings are the same as yours, but my read-more link falls between the two <p> tags.

I'll see your 3 screenshots and raise you one of my own, lol:

djs_core: Regarding the inline setting, you're sure you have saved the settings page? It's possible you are seeing a default value populating a settings form without it actually being saved to the database.

Also, have you run update.php since upgrading the module?

djs_core: This is a difficult problem to diagnose, as several modules could be altering the teaser by the time it reaches this one. Can you post a list of modules you have enabled?

djs_core: That's a long list! :)

Do you have a development instance of your site that you could use to diagnose this problem? The only thing we can try is disabling all non-core modules (except Read More link), seeing if the problem is fixed, and re-enabling each module until the problem reappears.

djs_core: Thank you for looking into this! When I have some spare time this week, I'll try to replicate the problem.

Changing the issue title to reflect recent findings.

I think I am having the same problem with rc7 and the inline module. If I attach an image to a node and display it with [inline:file.jpg] the read more link is not where it should be. Like the referenced bug report, it seems to calculate the position before the inline filter is run but substitutes the text after the inline filter expands into a much longer string.

I did some investigating into my issue. What's happening is that the module is calling preg_match() against the body to calculate the insertion point but then modifying the teaser at that point. These don't necessarily match if some other module or filter has modified the teaser but not the body.

bkat: We're calculating the insertion point using but applying it to the teaser in order to support the display of CCK fields. (If we calculate the insertion point using the full teaser, the link gets added after the CCK fields instead of the end of the node body.)

I realize the logic seems a bit twisted, but it's the best way we've found so far to support the display of CCK fields in the teaser. This is a work in progress, though, so this may change in a later release.

Couldn't you add a callback to the $node->content['#pre_render'] array that modifies the $node->content['body'] ? (called in drupal_render()) Since the $teaser isn't passed into the callback, perhaps you could set the callback in node's view callback if $teaser is true in the view callback?

I'm not super versed in the drupal API so please pardon any glaring holes I may have missed.

bkat: If you're still experiencing problems with the Inline module, can you open a separate issue for it? I want to stick to the Smileys issue in this thread. (It'll save me a headache! :)

djs_core: I was not able to duplicate this problem using 6.x-5.0-RC7.

However, when I first enabled Smileys, it caused the Read More link to move to a new line (i.e., it got wrapped in a <div> instead of a <span>). I was able to fix this by rearranging my input filters so that the Smileys filter was run before "Line break converter" and "HTML corrector."

Can you try rearranging your input filters to find something that solves it?

djs_core: Does this mean you'd consider this issue fixed?

After further testing, it's clear this is an input filter ordering issue. We've been able to solve all problems by rearranging filters and making sure the HTML filter allows <p>, <br>, and <img> tags.

I am having an issue with the Read More module using and

I have solved my issue of the <span> vs. <div> problem.

If you enable HTML corrector in the input filter, the issue seems to go away.
I still had to go back and insert the <!--break--> tag via the wysiwyg editor, but
they all seemed to be placed in <span>'s now.

Final settings:
Read More: - inline <p> and <span> tag acceptable
Input Filter: HTML full - enabled filters are only HTML corrector and URL filter.