Closed (fixed)
Project:
AdaptiveTheme
Version:
6.x-2.0-beta2
Component:
Subtheme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Nov 2009 at 20:11 UTC
Updated:
19 Dec 2009 at 16:10 UTC
There's quite a lot of stuff to clean up in theme.css since 6.x-2.x-beta2. Rather than issues and patches for each little thing, I'll just list them in comments here, as I find them...
Comments
Comment #1
andrewmacpherson commentedI'll refer to theme.css line numbers from from beta2
Comment #2
andrewmacpherson commentedline 154 refers to sidebar-inner, which has gone:
/* Target a specific sidebar, inner or sidebar-inner. */change to:
/* Target a specific sidebar. */Comment #3
andrewmacpherson commentedline 195 says "remove display:block..."
Remove implies there's something to delete; a better wording would be:
/* Over-ride display:block if you want the site name inline with the logo. */Comment #4
andrewmacpherson commentedline 451: What is
.tags {}used for? I can't find the class in the HTML. The name suggests taxonomy, but it doesn't appear in the node taxonomy output.Comment #5
andrewmacpherson commentedlines 479-482 and 484-487:
.article ul.linksselectors are repeated, only need one set.Comment #6
andrewmacpherson commentedline 511-513:
.first and .last classes for ul.links ?
These don't seem to be produced any more. Could we have them back, please? Perhaps another theme setting...
Comment #7
andrewmacpherson commentedline 496 refers to
.article h3.vocab-name {}However it would be a h2 element on standalone node/* pages. Perhaps it should be generalized to:
.article .vocab-name {}starter.css (line 55) just uses this form.
Comment #8
andrewmacpherson commentedline 497-499:
replace
ul.termswithul.vocab-listComment #9
Jeff Burnz commentedCheers, I've nailed everything so far and committed it so its in DEV.
I cant remember when I last used .tag, gawd, I think that was way back when...
Adding back in first and last just for node & comment links, hmm, not even sure how to do that, but if you enable .first and .last for Menu items in the theme settings these apply to the links lists.
Comment #10
Jeff Burnz commentedI think we can call this fixed for now, if more are found we can reopen it.