controls & image counter output order wrong in ThumbnailHover

BeatnikDude - November 28, 2009 - 23:53
Project:Views Slideshow
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

6.x-2.x-dev, I picked this up in another thread, thanks strands

The output for the controls and the image counter in ThumbnailHover mode is in the wrong order if you choose "Bottom" for either of them.

This patch for views_slideshow/contrib/views_slideshow_thumbnailhover/views-slideshow-thumbnailhover.tpl.php fixes that. I hope this is how you like it.

--- views-slideshow-thumbnailhover.tpl.php 2009-11-16 21:55:19.000000000 -0800
+++ views-slideshow-thumbnailhover-NEW.tpl.php 2009-11-28 15:42:36.000000000 -0800
@@ -31,11 +31,11 @@
     $output .= $view_teasers;
   }
   if ($options['thumbnailhover']['controls'] == 2) {
-    print theme('views_slideshow_thumbnailhover_controls',$id, $view, $options);
+    $output .= theme('views_slideshow_thumbnailhover_controls',$id, $view, $options);
   }
  
   if ($options['thumbnailhover']['image_count'] == 2) {
-    print theme('views_slideshow_thumbnailhover_image_count', $id, $view, $options);
+    $output .= theme('views_slideshow_thumbnailhover_image_count', $id, $view, $options);
   }
   print $output;

AttachmentSize
controlsImageCounterOrder4ThumbnailHover.patch709 bytes

#1

redndahead - March 16, 2010 - 04:09
Status:active» needs review

Marking needs review to look at it later. There have been some changes in this area so it may be fixed already.

 
 

Drupal is a registered trademark of Dries Buytaert.