Arianek and I decided to split up #632716: Help File Fixup: field*, file, filter, locale, translation, trigger into smaller issues/patches. Please review the relevant sections of the last patch for this can be found at http://drupal.org/node/632716#comment-2285200

Post review / screenshots and rerolled patches here -- thanks!

Comments

arianek’s picture

Status: Active » Needs review
StatusFileSize
new21.18 KB

manually cut this from the mondopatch

Status: Needs review » Needs work
Issue tags: -d7help

The last submitted patch failed testing.

Status: Needs work » Needs review

arianek requested that failed test be re-tested.

Status: Needs review » Needs work

The last submitted patch failed testing.

Status: Needs work » Needs review

arianek requested that failed test be re-tested.

Status: Needs review » Needs work
Issue tags: +d7help

The last submitted patch failed testing.

lisarex’s picture

Assigned: Unassigned » lisarex

OK, will reroll this

lisarex’s picture

Status: Needs work » Needs review
StatusFileSize
new14.48 KB
new116.57 KB
new129.84 KB

Please review

Modifications to both:
- added caps to modules and linked pages
- minor text revision

Content translation:
- cleared up the bit about enabling translation support
- removed references to the word post/replaced with content per new ui text guidelines
- updated the section about Language switching blocks

Now I have questions.

1) How does Drupal know "When a translation of the text is available in the language to be displayed"

2) We need to add link to Content translation section of the Permissions page. Not sure how to do this.

3) "Provide new or edit current translations for existing posts via the Translation tab." I couldn't find this... will have a look...

4) I enabled Swedish and the blocks but the Switcher wasn't visible. Hrm..

Status: Needs review » Needs work
Issue tags: -d7help

The last submitted patch failed testing.

Status: Needs work » Needs review

arianek requested that failed test be re-tested.

Status: Needs review » Needs work
Issue tags: +d7help

The last submitted patch failed testing.

jhodgdon’s picture

StatusFileSize
new20.15 KB
new39.19 KB
new35.45 KB

Here's a new patch.

Note to lisarex: You can only see the "Translate" tab if the content type is set to be translatable. See help screen (new one anyway), which explains this.

jhodgdon’s picture

Status: Needs work » Needs review
arianek’s picture

Status: Needs review » Needs work
StatusFileSize
new12.35 KB
new7.76 KB

Reviewed this with @webchick - the Translation patch is not consistent with the rest, as it currently contains step-by-step instructions, which should really live in the handbook. It's ok to have some level of instructional text, but not in a list step-by-step format.

If someone has the energy/time, pls modify the Translation help Uses text into paragraphs rather than lists.

The Locale one on the other hand, I'd RTBC. I've split the 2 so that we can have Locale committed while Translation is still being worked on.

arianek’s picture

Status: Needs work » Needs review

setting to review for testbot, someone (or me) should set back to needs work after.

arianek’s picture

Status: Needs review » Reviewed & tested by the community

actually, setting to RTBC for @webchick - JUST LOCALE IS RTBC

please set back to "needs work" after for translation module.

jhodgdon’s picture

Status: Reviewed & tested by the community » Needs work

Setting to needs work now, as webchick says she will not be committing patches until later this evening.

jhodgdon’s picture

Status: Needs work » Needs review
StatusFileSize
new27.16 KB
new8.34 KB

Here's a patch for the translation module, for review. Note that the patch for locale is in #14 and is RTBC.

arianek’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new12.35 KB
new8.53 KB

@jhodgdon you are a master, that is SOOOOOO much better! made a couple little tweaks to the language, but i think this is majorly improved and ready to go.

reposting both patches for an RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Committed Content Translation to HEAD!

Locale, unfortunately, no longer applies. :(

Could someone do up a quick re-roll, while also fixing (under admin/config/regional/language):

....ns')) . '</p>';      return $output;

move "return $output;" to the next line?

arianek’s picture

Status: Needs work » Needs review
StatusFileSize
new11.29 KB

i was going to do a quick reroll but i *think* i discovered why it didn't apply - it seems the section under case 'admin/config/regional/language/configure': had been modified and broken down from being one big chunk to being split up for all it's subpages of /configure (if that makes sense).

i get the sense i shouldn't remove all that and make the main page have a huge chunk of text since we like smaller bits across more pages generally...

so i made the code fix requested above, applied the main help page changes, and then just combed through the /configure ones and updated them to conform to standards formatting wise.

hope this works!

lisarex’s picture

Assigned: lisarex » Unassigned

Would review, but I'm getting mysterious rejects again.

arianek’s picture

bah, what the heck?

webchick’s picture

Status: Needs review » Fixed

It applies fine for me. I glanced through and didn't see anything horrible that bit my face off. :)

Committed to HEAD!

Status: Fixed » Closed (fixed)
Issue tags: -d7help

Automatically closed -- issue fixed for 2 weeks with no activity.