Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Nov 2009 at 03:30 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
arianek commentedmanually cut this from the mondopatch
Comment #7
lisarex commentedOK, will reroll this
Comment #8
lisarex commentedPlease review
Modifications to both:
- added caps to modules and linked pages
- minor text revision
Content translation:
- cleared up the bit about enabling translation support
- removed references to the word post/replaced with content per new ui text guidelines
- updated the section about Language switching blocks
Now I have questions.
1) How does Drupal know "When a translation of the text is available in the language to be displayed"
2) We need to add link to Content translation section of the Permissions page. Not sure how to do this.
3) "Provide new or edit current translations for existing posts via the Translation tab." I couldn't find this... will have a look...
4) I enabled Swedish and the blocks but the Switcher wasn't visible. Hrm..
Comment #12
jhodgdonHere's a new patch.
Note to lisarex: You can only see the "Translate" tab if the content type is set to be translatable. See help screen (new one anyway), which explains this.
Comment #13
jhodgdonComment #14
arianek commentedReviewed this with @webchick - the Translation patch is not consistent with the rest, as it currently contains step-by-step instructions, which should really live in the handbook. It's ok to have some level of instructional text, but not in a list step-by-step format.
If someone has the energy/time, pls modify the Translation help Uses text into paragraphs rather than lists.
The Locale one on the other hand, I'd RTBC. I've split the 2 so that we can have Locale committed while Translation is still being worked on.
Comment #15
arianek commentedsetting to review for testbot, someone (or me) should set back to needs work after.
Comment #16
arianek commentedactually, setting to RTBC for @webchick - JUST LOCALE IS RTBC
please set back to "needs work" after for translation module.
Comment #17
jhodgdonSetting to needs work now, as webchick says she will not be committing patches until later this evening.
Comment #18
jhodgdonHere's a patch for the translation module, for review. Note that the patch for locale is in #14 and is RTBC.
Comment #19
arianek commented@jhodgdon you are a master, that is SOOOOOO much better! made a couple little tweaks to the language, but i think this is majorly improved and ready to go.
reposting both patches for an RTBC.
Comment #20
webchickCommitted Content Translation to HEAD!
Locale, unfortunately, no longer applies. :(
Could someone do up a quick re-roll, while also fixing (under admin/config/regional/language):
move "return $output;" to the next line?
Comment #21
arianek commentedi was going to do a quick reroll but i *think* i discovered why it didn't apply - it seems the section under
case 'admin/config/regional/language/configure':had been modified and broken down from being one big chunk to being split up for all it's subpages of /configure (if that makes sense).i get the sense i shouldn't remove all that and make the main page have a huge chunk of text since we like smaller bits across more pages generally...
so i made the code fix requested above, applied the main help page changes, and then just combed through the /configure ones and updated them to conform to standards formatting wise.
hope this works!
Comment #22
lisarex commentedWould review, but I'm getting mysterious rejects again.
Comment #23
arianek commentedbah, what the heck?
Comment #24
webchickIt applies fine for me. I glanced through and didn't see anything horrible that bit my face off. :)
Committed to HEAD!