I have commit access to http://drupal.org/project/override_node_options but the instructions it shows me there are for the anon CVS user.
This doesn't seem to be because I don't own the project node, as for image module the instructions have my username.

CommentFileSizeAuthor
#2 646586-project-maintainer-check.patch1.63 KBdamien tournoud

Comments

joachim’s picture

joachim commented

Very very weird.
This has been resolved by the fix to #647048: Cannot edit project page.

In other words, if a user can't edit the project page because of input format restrictions, they don't get the CVS instructions they perhaps need!

damien tournoud’s picture

damien tournoud commented
Title: instructions showing for anonymous user in some cases where it shouldn't » Detection of the maintainership of a project broken
Status: Active » Needs review
StatusFileSize
new 646586-project-maintainer-check.patch1.63 KB

It also happen that if a user can edit all the nodes (ie. have the administer node permission), he is always presented the instructions for maintainers.

The root of the problem is that $is_maintainer = node_access('update', $project); is not the correct way to determine is a user is the maintainer for a project. Sadfully, the project module doesn't have a decent API to extract this information, so we will have to implement some manual checks.