signature for 4.7.0

By ultraBoy on 20 May 2006 at 20:04 UTC

Signature.module is updated for drupal 4.7.

Features:

Makes user signatures dynamical, that is, if user change his signature in his profile, after each of his/her posts will be the new signature!
Usability benefits - 'cause each time a comment is posted, user don't have to pull down signature to the end of his/her comment.
Comments can be styled another way than the post itself, and it's customizable from 'administer->settings->signature'.
Shows signatures not only after comments, but also after nodes (the only limitation that some html tags will be stripped out).
Allows define content types (and at once comments for them) where signatures should be seen and where not.
New: If the module is enabled, but signatures are disabled for all content types, signature field isn't displayed at user profile settings (So, if you use comment.module but don't want you users to have a signature in their profiles, you need this module too).

New: No patching is required now!

Actually, this is a kind of a hack of the comment.module, and if you like it, please let us know (here). More people will use it, more possibility that the module will become nice, clean and separate from comment.module.

Tested with Drupal 4.7.0.
Download link: signature-4.7.0.zip .

Comments

perfect - thanks

tobyspark commented 22 May 2006 at 12:32

i would think this functionality should be part of core

Yes, we like it :)

Ignas commented 22 May 2006 at 14:50

But there are some problems:
1. When there are pictures in the comment, signature appear near picture instead bottom. You shoud insert clear-both style, I think.
2. Input filters. Comment signature do not pass through default (any!) filter. Therefore links, images etc appears unformated (if appears). Node signature looks OK. (filter settings are the same for my nodes and comments)

thanx for feeedback

ultraBoy commented 22 May 2006 at 19:18

As for 1) : As for style, you can set it up what you want in administer/settings/signature. Please let us now if you'll fix that with "pictures" (avatars?)

As for 2) "Therefore links, images etc appears unformated" - you mean, you want links and filters to be filtered out? Yes, I'll try to do some configurable filtering settings.

PS: for 2) Now images are filtered out from comment signatures, please check once again.

Explanation

Ignas commented 22 May 2006 at 19:57

http://www.photoart.lt/images/signature.png
1. In node signature (dogs and link below line) appears near node image (landscape). I'm not sure that its the right place. Signature must have this own CSS file to configure I think. But this is feature request :) <br style="clear-both" /> before signature must help. But I'm not sure if this universal solution.
2. Take a look how the same signature looks in node and comment. In coment my default link and img_assist filters dont work. I cant find where to setup these filters for signature module.
3. Tried. No changes. I'm not sure what to do with images in signature. The best solution would be to specify max XY size in signature configuration or disable images at all. Or posibility for administrator to specify filter for signature? This could be nice solution.
There is no rush. I can fix it itself, but othere are some problems to fix someday in this module. Usefull module.
Edit patch works. Thanks :)

One more seriuos problem:

Ignas commented 22 May 2006 at 15:28

One more seriuos problem: can't edit comment - it appears empty in edit window. Node edits fine. Use D4.7 and TinyMCE

wow

ultraBoy commented 22 May 2006 at 16:32

You're right. *shocked*

fixed

ultraBoy commented 22 May 2006 at 18:08

I'm sorry about that. Just now I've fixed it. Please download the file again.

haha ........................

5pu commented 23 May 2006 at 02:48

haha

...........................................
webhosting-site
webhosting-speak
webhosting-bbs
webhosting-blog

Thank You!

sjfarrar commented 7 June 2006 at 23:08

Just creating a new site with drupal 4.7/tinymce and have been getting rather frustrated with the awful default 'put signatures into the text entry box for comments' system. This looks like it should do the job, will be trying it out today.

Thanks Again!

sprintf() error

sjfarrar commented 8 June 2006 at 04:42

Well... installed it on my site, and it seems to be working... mostly. The signature isn't showing up (in the edit box) when they go to post new forum topics or add comments. And user signatures are displaying on their posts.

However, it isn't using the format set in admin/settings/signature, presumably because of my next problem.

Whenever I go to view a forum (all test forums atm, site isn't live - fortunately :P) I get a bunch of the following error:

warning: sprintf() [function.sprintf]: Too few arguments in C:\Documents and Settings\CMSDemo\Desktop\webhome\Apache\drupal\modules\signature.module on line 119.

Seems to be n+1 of the error where n is the number of posts in the thread.

I'm using drupal 4.7/php5/mysql4, any other info which might be of help, just ask. Any ideas?

Could you please write which

ultraBoy commented 8 June 2006 at 08:05

Could you please write which format you set in admin/settings/signature ?
________________________________________
It's a longtail.

Signature Template

sjfarrar commented 8 June 2006 at 08:49

Sure thing (and thanks for responding so quickly :D)

<hr width="75%" />
<br />%s

That's exactly what I have in the box, and upon typing that in here.. it occured to me that the quotes "" could be causing issues, so I went back and escaped them, like so:

<hr width=\"75%\" />
<br />%s

Which definitely helped something on my site (much of my forum formatting worked like it should - just started using the flatforum module) :P But unfortunately I still get the same sprintf() errors like before.

Hopefully that helps.

try this

ultraBoy commented 8 June 2006 at 09:31

<hr width=\"75%%\" />
<br />%s

P.S. I think this helps, but all these escapings are not nice. I'll change the code so no escaping will be necessary.

________________________________________
It's a longtail.

That Worked

sjfarrar commented 8 June 2006 at 10:15

Awesome stuff, that got rid of the errors. Makes sense to me now that the % might have been causing issues, didn't think of it before.

Now I have another strange issue with getting the signature generated by signature.module and the one generated by Drupal, which I think could be linked to the issue documented here: http://drupal.org/node/62746 I will try out that fix and see how I go.

Thanks heaps for your help, and hopefully if you update the module with the fix for escaping, no-one else will have this problem in future :)

But with my fix you'll need

ultraBoy commented 8 June 2006 at 10:31

But with my fix you'll need to jump back to one % sign.

2 signatures?? what is your drupal version? When do you have 2, after editing comments may be? Or just after adding a new comment?
________________________________________
It's a longtail.

Yeah I guessed that I would

sjfarrar commented 8 June 2006 at 10:57

Yeah I guessed that I would need to do that. After all that however I've got rid of the width altogether, because it was being centered for some reason, so I decided to go back to a line all the way across (no need for the width tag at all).

Drupal 4.7.0, haven't upgraded yet. You can see here what's happening: http://sjfworld.orcon.net.nz/forum2sig.jpg I get it on every single forum post on the site. I even have really old posts where I get one, that I left the one in the edit box from the comment module, and the two dynamic ones now generated by the signature module and the comment module, that's really fun (fortunately this is all development testing stuff so I'll just purge them all once I'm ready to go live)

Haven't tried out their fix, but have made further comments on the thread I linked above: http://drupal.org/node/62746#comment-127520

Did you patch comment.module

ultraBoy commented 8 June 2006 at 11:17

Did you patch comment.module or anything else? AFAIK comment.module doesn't generate dynamic signatures. Disable signature.module, will one or both sig's disappear?
________________________________________
It's a longtail.

No patching...

sjfarrar commented 8 June 2006 at 12:16

As far as I'm aware I haven't made any patches to comment.module. And regarding comment.module doing dynamic signatures, agreed, that's what I thought.

When I disable signature.module the signature from comment.module remains.

Are you sure it's

ultraBoy commented 8 June 2006 at 12:21

Are you sure it's dynamic?

________________________________________
It's a longtail.

Weird

sjfarrar commented 8 June 2006 at 12:34

Yep just tested to make sure...

Created new post, both sigs match.
Changed signature in account.
Looked at post again, both sigs match.

Fix

sjfarrar commented 14 June 2006 at 12:54

Found a fix for the weird behaviour, have posted a description and results here: http://drupal.org/node/62746

Signatures in Forum posts

Steel Rat commented 23 June 2006 at 18:03

Hi Ultraboy,

Does this module place signatures in Forum posts as well as comments, and other content types? I don't have a problem with the current signature functionality, except for the fact that it doesn't include forum posts.

p.s. Why doesn't this mod show up in the 4.7 modules list?

Steel Rat
Drupal Site: RPGMapShare.com

solution of duplicate sig with quote module

yngens commented 10 July 2006 at 06:17

If you have quote modeule activated, when pressing to "quote" link you get your signature added beneath the quoted message and if you submit like that you will get diplicate signature.

The problem solved by changing line 146 in quote.module:

$form['comment_filter']['comment']['#default_value'] = '[quote='. $author .']'. $quote ."[/quote]\n". $form['comment_filter']['comment']['#default_value'];

$form['comment_filter']['comment']['#default_value'] = '[quote='. $author .']'. $quote ."[/quote]\n";

Another fix that I just did

dahli.llama commented 26 August 2006 at 15:26

Another fix that I just did for this exact problem (that'll teach me to look here first :p )

In function "function signature_form_alter($form_id, &$form)" of signature.module, change the following

    //Removed because it didn't work with Quote module
if ($form['comment_filter']['comment']['#default_value'] == $user->signature ) {
     $form['comment_filter']['comment']['#default_value'] = '';      
}

    // New Form replacement that works with Quote module.
    $form['comment_filter']['comment']['#default_value'] = str_replace($user->signature, "", $form['comment_filter']['comment']['#default_value']);

That will just replace the signature portion in the text are. Anything else should be left alone.

Any reason this isn't an official module?

zach harkey commented 17 August 2006 at 18:25

Any reason this isn't an official module?

It took me 30 minutes of searching to track this down (and I even knew what I was looking for).

-zach
--
harkey design

: z

great module but there're a couple of issues

drurian commented 26 August 2006 at 14:56

First, as has been noted before, if using with flatforum results in duplicate signatures. Can be dealt with by a CSS hack or maybe hacking flatforum (didn't check that out).

Second, if you disable signature for all content types and the texarea disappears from the user account settings it still shows up while posting comments. It seems that the module only hides the setting but doesn't delete any existing signatures from the users table so they show up anyway.

Signatures after nodes

Psikik commented 6 October 2006 at 00:43

Is there any way to get an option to disable signatures after nodes? I'd like them still on all of the comments. Any help would be greatly appreciated.

yes look http://drupal.org/no

hedac commented 7 October 2006 at 11:02

yes
look
http://drupal.org/node/62746#comment-149818

Any fix for xtemplate ?

satos commented 9 October 2006 at 15:44

Any fix for xtemplate ? Maybe i need to change something in signature.module?

Sorry, no idea about

ultraBoy commented 10 October 2006 at 07:32

Sorry, no idea about xtemplate. It needs debugging. If it was kind of "serious" module, I would fix it to work with xtemplate, but it's just a quick and dirty solution; it won't be necessary when current problems with signatures will be resolved in the core.

----------------------------------------------
Just like I like!

Has that been committed to

Toe commented 10 October 2006 at 08:42

Has that been committed to core for 5.0? I remember webchick saying she wanted to work on that, but I never heard anything afterward.

Seems like it is postponed.

ultraBoy commented 10 October 2006 at 13:08

Seems like it is postponed. =(

Too bad, I don't have time for this. IMHO such patches require a lot of time, not only for coding and designing the best possible solutions, but also to argue your solution is the most correct.
----------------------------------------------
Just like I like!

where's the file?

cyberk-1 commented 7 November 2006 at 08:52

hi, i need the 'signature-4.7.0.zip'-file or a newer version.
it seems link the link is broken...

somebody who has it? thanks a lot!

New location of the module

ultraBoy commented 7 November 2006 at 09:48

New location of the module is http://like-i-like.org/signature-4.7.0.zip .

----------------------------------------------
Just like I like!

Website appears offline.

ericatkins commented 2 January 2007 at 07:04

Website appears offline. Can anyone else host the .zip file?

mirror

Holie@drupal.be commented 2 January 2007 at 19:02

A mirror would be nice idd!
Maybe you could try sf.net ?

empty comment :)

ultraBoy commented 7 November 2006 at 09:51

*empty comment :)*

Thanks to the author. This

fluxrider commented 7 December 2006 at 14:06

Thanks to the author. This works brilliantly on 4.7.4. No issues at all to date. I'm using bbcode and quicktags for picture insertion , and only using this so far in forum posts and comments, and its working brilliantly displaying avatar and text all wrapped in the bbcode 'code' tags.

This really should be added to the modules page.
Well done.

edit- I should add that on my site I have totally disabled the use of html including filtered for all users and only allow bbcode. If filtered html is used , images are not displayed of course. I've replaced all use of html with bbcode including in the quicktags module. Very happy with this . Images , avatars and text all displayed in forum sigs . Woohoo.

Where can I download the module?

remi commented 3 January 2007 at 17:47

The download links are dead... :(

Rémi
remino.net

...

remi commented 4 January 2007 at 11:02

Is there someone who can upload that module somewhere reliable? I'd really like to get that module, but I can't download it from anywhere.

Thanks.

Rémi
remino.net

I think this feature is

Xabi commented 16 January 2007 at 03:27

I think this feature is essential for the functionality of Drupal forums and comments. I would ask for an extra feature: exclude signatures from searches, because signatures are repeated useless content for searching. Yesterday I tried to search at drupal.org for "snap" (thinking in the snap preview technology) and... see by yourself: I got a lot of messages without relation to my search, becasue there was an user using "snap" at his signature in a lot of posts.

We really need this for Drupal 5.0!

If you use the module,

ultraBoy commented 16 January 2007 at 10:44

If you use the module, signatures are not included in search index. They are automatically attached at display-time.

One of the download links is

Xabi commented 17 January 2007 at 22:49

One of the download links is working again. Just in case, I have mirrored the file here:

****

Anyone wants to try a 5.x version?

Xabi, please edit your post

ultraBoy commented 17 January 2007 at 22:16

Xabi, please edit your post and remove your mirrored link. The module will be available for dl from the old address for long time from now, so it's not needed to mirror it.

----------------------------------------------
Just like I like!

Ok but... why don't you

Xabi commented 19 January 2007 at 00:08

Ok but... why don't you release this as a module? This is a much needed feature for Drupal.

Do we have Drupal 5.0

yngens commented 21 January 2007 at 02:30

Do we have Drupal 5.0 version of Signature?

___________
www.akyl.org

Drupal 5.0 version

jonaswouters commented 26 February 2007 at 10:27

I converted the module to drupal 5.0..
You can download it here: signature-5.0.tar.gz

Works fine!

AdrianB commented 10 March 2007 at 23:25

Thanks, it works just fine. All I wanted was to remove the signature from the profile page and that's what I used this module to do. I did not test any other feature. I noticed that it didn't use t() for all text (like the description on line 48), but that's not a big issue.

It would be nice if it was released as a module on drupal.org. Until they rewrite the whole signature handling (for Drupal 6) I guess there's others out there who wants to get rid of the signature completely. (Personally I really can't stand signatures, they mess up the flow and doesn't add any real value, other than promotion value for the users.)

signature for 4.7.0

Comments

New forum topics