When no email address is supplied in the admin interface, the module should use the e-mail address supplied by the person who fills in the form.

Currently the outgoing e-mail's FROM field contains the name of the person who sent the mail ('yname') and an empty e-mail address (so it looks like "foo <>" ). This triggers some spam filters to mark the email as spam (no toplevel domain, no email address in from) This patch uses the admin setting if filled, otherwise uses 'yemail' field.

CommentFileSizeAuthor
#1 forward-email.patch901 bytesPeter Bex
forward-email.patch841 bytesPeter Bex

Comments

Peter Bex’s picture

StatusFileSize
new901 bytes

Sigh, PHP doesn't work that way. Here's a patch that actually works :)

willvincent’s picture

The patch in comment #1 works for me.

Emails come through as being from the site-wide email address on behalf of user_name

Maybe not perfect, but they're addressed from somewhere now, which is good. :)

seanr’s picture

Status: Needs review » Fixed

This has been fixed, albeit slightly differently. It'll be out in the next release. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -invalid email address

Automatically closed -- issue fixed for 2 weeks with no activity.