The download/play counters are shown as long as long as download/play are enabled. I think they should honor the 'view post access counter' permission under access control, since download/play are "accesses" too.

CommentFileSizeAuthor
#5 honor_access_counter_permission.patch_1.txt1.06 KBluperry
#3 honor_access_counter_permission.patch_0.txt1.06 KBluperry
honor_access_counter_permission.patch.txt1017 bytesluperry

Comments

drewish’s picture

drewish commented

what module provides the "view post access counter" permission? because it's not in core... i don't think we should really be worrying about other modules permissions...

luperry’s picture

luperry commented

It's provided by the statistics module, it is included in core.

luperry’s picture

luperry commented
StatusFileSize
new honor_access_counter_permission.patch_0.txt1.06 KB

added a check for the statistics module, if it's enabled, it'll honor the permission, otherwise, the counter will be displayed regardless.

drewish’s picture

drewish commented

ah, sorry, statistics isn't enabled by default so i didn't see it listed. does it make sense to test if the module is enabled before checking the acccess permissions? that seems like it'd make the purpose more obvious.

but, does anyone else think this is a problem?

luperry’s picture

luperry commented
StatusFileSize
new honor_access_counter_permission.patch_1.txt1.06 KB

You are right, it should be checked before checking the permission. I was being a little sloppy there.

For me, it's more of a matter of consistency than a problem, though I would love to have some kind of control over it, whether it's re-using the access control from the statistics module or providing the access control from the audio module itself.

drewish’s picture

drewish commented

can i get a +1 from someone else?

q0rban’s picture

q0rban commented

I guess it makes sense to me... If i'm understanding the issue correctly: have it keep a count of views/downloads without actually showing it in the links?

If that's the case... +1

Otherwise, I think I need some more explanation..

luperry’s picture

luperry commented

to q0rban,

yes, that's basically it.

drewish’s picture

drewish commented
Status: Needs review » Reviewed & tested by the community

i'll probably add a comment explaining what the extra test is for.

marlowx’s picture

marlowx commented

for a band website...

its kinda cool to show how many downloads or plays the songs have gotten but you down't want to show other statistics to everyone...

any chance of having this be optional feature?

rawk on dudes!

q0rban’s picture

q0rban commented

its kinda cool to show how many downloads or plays the songs have gotten but you down't want to show other statistics to everyone...

as I understand it, that's exactly what this patch accomplishes...

drewish’s picture

drewish commented

oh, right yeah so maybe we need our own permission? or is it worth that much trouble?

luperry’s picture

luperry commented

if that's the case, then it might be better to have a seperate permission for it.

drewish’s picture

drewish commented
Status: Reviewed & tested by the community » Needs work

when i get some time next week (it's finals) i'll look at modifying this.

drewish’s picture

drewish commented
Version: 5.x-1.x-dev » 4.7.x-1.x-dev
Status: Needs work » Fixed

a fix got committed: http://drupal.org/node/73286

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)