Active
Project:
Plugin Manager
Version:
6.x-1.9
Component:
Code
Priority:
Critical
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Dec 2009 at 01:12 UTC
Updated:
26 Oct 2010 at 11:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
toddgeist commentedI should add that I am using SSH as the download method.
Comment #2
Anonymous (not verified) commentedI'd say that this is critical to add. I'll add it to my list of things to work on... unless someone else wants to start coding a patch (which would be faster and ridiculously awesome. :)
Comment #3
scottop commentedThis issue was very important to me as well, so I made a quick fix on my installation. I could make a real fix if you have not gotten to this yet and send it, but I don't know how to do the patch files.
Basically, I just changed all of the 'sites/all' to conf_path() . Simple. Two things would have to be added, however, for a real fix, and a third would have to be thought about.
1) It dies if the directories do not already exist. It should probably check if they exist and create them if they do not.
2) It should have another setup parameter for "install just for this site" or "for all sites." While I agree that for security it should default to "just this site", it probably needs to be default to "all" to make it backward compatible... unless you can make the code sense the change and move modules and themes. That sounds more difficult, though that is why you have upgrade scripts. My own preference would be to not have this option, copy all of the things this module has previously installed to the more local directories with the upgrade script, and be done with it. However, this seems more than I want to code, since I don't know how to get the list of things it has installed. (I suppose it can't be that difficult... but... um....)
3) To be really bullet-proof, would it need to reconcile the modules in /sites/www.mysite.com/modules with those in /sites/all/modules ? What happens when I want to use this to upgrade a module that also appears in the /all directory? Does Drupal prefer the more local version, so this module doesn't have to worry about it? That would be nice.
In any case, THANKS FOR THE FABULOUS MODULE, and for recognizing this real problem.
Comment #4
Anonymous (not verified) commentedAwesome! I'll take a look at this sometime this week to see what we can make it do. :)
Comment #5
paul@poetsma.nl commentedGreat module, and I look forward to the multi-site support.
Comment #6
meet.h.thakkar commentedeven if you dont support multi site , you can give custom destination for themes and modules , just two fields .....