Both FeedsDataProcessor and FeedsNodeProcessor generate items that are older than expiry time and then later expire them on cron time. That's wasteful and leads to unexpected results.

Once this is fixed, we can remove display time horizons like the one in Managing News: #651996: show items regardless of date in the mn_news View

CommentFileSizeAuthor
#3 653412-3_expiry.patch1.23 KBalex_b
#1 FeedsDataProcessor.ExpireFix.patch758 bytesrbrandon

Comments

rbrandon’s picture

rbrandon commented
StatusFileSize
new FeedsDataProcessor.ExpireFix.patch758 bytes

Needed a fix so I went ahead and created a patch. Didn't like the feed items being created and deleted on alternating cron runs :-)

Patch Attached

Thanks,
Richard Brandon

alex_b’s picture

alex_b commented
Status: Active » Needs review

Thanks - at first glance, this patch is looking good. Setting to NR to keep this on my radar. I will circle back to this issue once I have some time.

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 653412-3_expiry.patch1.23 KB

This patch is what I am going to commit now. It is passing all tests. I've simplified the if clause - please take a quick look whether I am not missing anything here.

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

alex_b’s picture

alex_b commented
Title: Do not create items older than expiry time » FeedsDataProcessor: Do not create items older than expiry time

I just broke out a separate issue for node processor:

#784756: FeedsNodeProcessor: Do not create items older than expiry time

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.