uploading of files fails when adding new releases

I can confirm this.

There's no upload code!

There's just a note: "/* TODO: pending final fileapi" which has been there since I first looked this module 2 years ago.

Since this part of the module has no use on drupal.org. It's not likely to get done anytime soon. :(

moggy: Since this part of the module has no use on drupal.org. It's not likely to get done anytime soon. :(

a) as the new project maintainer, one of the things i'm trying to do is make project useful for sites other than drupal.org again.

b) if you care about this issue and have the skills to debug this further and generate a patch that adds the missing functionality, i'll be more than happy to review, test, and apply the patch.

c) i can't promise i'll be able to work on this myself in the near future, since i'm doing all of this work as a volunteer, and i have other commitments in my life to deal with, too.

so, don't dispair, please help by writing the code that adds the functionality you need. i guarantee this issue will be resolved sooner if you do that than if you throw up your hands and wait for me or someone else to solve it. ;)

thanks!
-derek

I've looked at this several times since I started using drupal and have yet to work this bit out.

don't worry, if I work it out I'll post a patch.

great, thanks! wish i could help more in the short term on this one...

can you attach your changes as a patch, as described at http://drupal.org/patch ? that'll make it a lot easier for me (and others) to review.

thanks!
-derek

I tried the patch and all "chunks" succeeded except #1 and #2

#1 failed at 1
#2 failed at 117

try this one.

I used the previous patch as a guide. I've used more drupal api's and editing works.

re project releases directory, if we want to upload to there we've got a big problem. Project has been written around the assumption that if the releases directory is set we're not going to be manually uploading files. To undo this would be a LOT of work.

sorry, forgot to change status.

Tried the patch and 1 out of six hunks failed. It seems a mod has been made in the CVS version that conflicts with code in that hunk (2).

I've attached a patch that, I believe, fixes hunk 2 failure.

It all seems to work except for "delete" which "blank screens". Nothing appears in the error_log and it appears the file isn't deleted. It's 1:50am here for me so to tired to look futher but I will if I get a moment over the weekend.

regards
--AjK

sorry, this won't do:

+  // TODO: read dir name from settings, actually doesn't work
+  //(Project would need a lot of work if this part was to use the project_release_directory)
+  //(Just hardcode it for now)
+  //$releases_dir = $files_dir.'/'.variable_get('project_release_directory', 'project_releases');
+  $releases_dir = $files_dir.'/project_releases'; 

someone has to figure that out before this can be committed.

also, i don't personally care *that* much, but this isn't proper coding style:

+      } else { 

should be:

+      }
+      else { 

a quick skim of the patch didn't reveal any other major problems, but i haven't had a chance to test this yet.
if someone posts a new patch that addresses the first of these concerns (the variable_get('project_release_directory' ...) stuff), i'll do a more thorough review and test it out locally.

thanks again for everyone's help trying to get this working!
-derek

I tried last patch sent by AjK, and it didn't worked for me.

In fact, the module stopped even the "false upload" in which only an entry for the release on table "project_releases" were created (thus, searching the "uploaded" release file in drupal root directory).

Somebody have a hint on how to change just the directory where the module searches the "uploaded" file? I intended manually upload releases to files/projects_releases/ directory instead root.

I've did an über hard code to send to the database a custom path to the release file on insertion and update of a release.

For some reason, if there's any value in variable.project_release_directory on the database, the link to "upload" a release in project summary does not shows itself. So, I add the complete path in project_releases.path.

In the file release.inc source file, find the project_release_save function. Add after this line:

$node = node_load($release->nid);

... the code that follows:

$release->path = 'files/projects_releases/' . $release->path;

The path "files/projects_releases/" is just an example.

this is now totally fixed and happy if you use the 4.7.x-2.0 version of project.module, where releases are now represented as real nodes (using the new project_release.module). i'm not going to fix this in 4.7.x-1.*, since it's already massively better in the 4.7.x-2.* series.

thanks for all the help, anyway!
-derek