Closed (fixed)
Project:
Project
Version:
4.7.x-1.x-dev
Component:
Issues
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
25 May 2006 at 23:38 UTC
Updated:
4 Jul 2006 at 01:00 UTC
care of revision 1.110 in issue.inc:
revision 1.110
date: 2005-06-23 13:16:20 -0700; author: killes; state: Exp; lines: +186 -31;
*** empty log message ***
issue.inc defines a function called project_issue_nodeapi(). however, this function is never getting called, since hook_nodeapi is on a per-module, not per-type basis. i added a dprint_r() in there and that's never firing, no matter what i do. i also tried adding a project_project_nodeapi() as part of my hacking on http://drupal.org/node/64221. that was never called, either. once i renamed it to just project_nodeapi() it started working just fine. it's trying to do some kind of validation, but it's not happening. we should remove this dead code, and if this validation is still important, implement it for real somewhere where it counts. ;)
Comments
Comment #1
dries commentedThe hook is used for the status-field restrictions Nedjo implemented a couple months ago; see
?q=admin/settings/project/status. Looks like a bug. Fortunately, we're not currently using this on Drupal.org. ;)Comment #2
dwwthanks to http://drupal.org/node/69349, this is now fixed on all branches, and project_issue_nodeapi() is being called as originally intended. ;)
Comment #3
(not verified) commented