It adds the class to the header, but the row isn't opened. Firefox 3.something

For a quick fix, added

          $triggers.filter(':eq('+rowstartopen+')').addClass(activeClass).next().show();
          jQuery('.'+activeClass, context).next().show(); // this

as a quick fix; my jquery isn't the best

CommentFileSizeAuthor
#11 views_accordion-656434.2.patch936 bytesmanuel garcia
#8 views_accordion-656434.patch879 bytesmanuel garcia

Comments

hefox’s picture

hefox commented

The option to autoclose is going cross- view and closing one after opening the one in the other view; ie not sticking to it's view. I guess this is won't fix, accordion issue?

hefox’s picture

hefox commented

The left (first) views accoridon, other then closing at the begining, works as expected. The right closes the left (ie the left does not effect the right, where the right effects the left). Looks like something was attached to the left when attaching to the right so it treats it as one accordion, whereas the left does not have that issue.

KingOfMyCastle’s picture

KingOfMyCastle commented

Hi! Can you let me know where you put that code? I can't see any part of any file in the module download that matches your code.

Thanks!

hefox’s picture

hefox commented
Title: Opening row on load with 2+ accordians doesn't open all » 2+ accordions do not play nice togeather.

Look for th first line;

However this is not a good fix; the real issue needs to be solved; it's causing more stuff to happening, like closing one accordion closses the unrelated accordion when it's set to only have one open at a time.

manuel garcia’s picture

manuel garcia commented
Status: Active » Postponed (maintainer needs more info)

On my site I have two views_accordion display blocks on the front page, with different settings, playing perfectly well together.

If you expect this to ever be fixed, like with any other issue, you need to provide the maintainers with enough information to duplicate the issue:

  • How exactly are you using both accordions? How are you printing them out to the page?
  • Are you using the latest version of the module?
  • Can you provide a screenshot of how your view is setup, including the views_accordion's options?

I hate to be forced to say this, I feel you should all know this, but hacking the module outside the scope of providing a patch is not a good idea, for any module. This is software libre, and as such the development should take place between all of us. If you don't have the coding skills, at least work with the maintainers to improve the software, so that everyone benefits, and you can take advantage of further development.

KingOfMyCastle’s picture

KingOfMyCastle commented

Hi Manuel, here are my circumstances:

Version 6.x-1.2 - 2009-Dec-01

Browsers: FF3, IE7, IE8

I'm sorry I can't give you a link nor screenshots but I'll try to explain.

The problem: Two or more accordions on the screen work fine apart from one thing. If I have two or more that have the 'Start with a row opened' turned on then only one accordion will have its first item open.

In the Accordion Views settings I also have 'Use the group header as the Accordion header' enabled, but none of the other options at all.

I'm using these as block views and if I hide either one using block visibility settings, leaving just a single accordion view, then the first row is opened as expected. If I add another accordion views block (to any region) then on page load only the second accordion view on the screen has the first row opened.

I suppose you call it a 'conflicting start with row open' issue.

Also, just FYI, if I set the first accordion to have row 2 open and the second to have row 1 open then the same issue stands. First accordion has no rows opened.

Anyway, I hope that's enough information.

Thanks.

manuel garcia’s picture

manuel garcia commented
Title: 2+ accordions do not play nice togeather. » Conflict with Use group header and start with first row opened when two accordions in the same page
Version: 6.x-1.2-rc2 » 6.x-1.x-dev
Assigned: Unassigned » manuel garcia
Status: Postponed (maintainer needs more info) » Active

Thanks KingOfMyCastle, I have just confirmed this bug, it seems to only happen exactly on your case, using the grouped by field as the header to open the accordions, having 2 or more accordions in the same page.

Thanks for the detailed bug report, there was no way I could have found out what was the problem with the original bug report.

I will try to debug this, though I am at the moment quite busy with work. Please stand by for testing a patch (hopefully soon).

manuel garcia’s picture

manuel garcia commented
Status: Active » Needs review
StatusFileSize
new views_accordion-656434.patch879 bytes

OK, it was a bit tricky to figure out what was going on, but I think I've found it.

When using grouped results, we were using too broad of a selector, thus picking every views-accordion content on the page to work with, and so these displays were controlling the rest of the accordions on the page.

Please test the patch provided, if possible change the settings on the accordion, and see if anything breaks =)

You should place it into the views_accordion directory to apply it.

KingOfMyCastle’s picture

KingOfMyCastle commented

Hi Manuel, yes this works perfectly.

Thank you very much for the quick update of this amazing module.

Nothing seems to be broken at all.

manuel garcia’s picture

manuel garcia commented
Status: Needs review » Fixed

I have tested the patch a bit more, and it introduced a bug if you weren't using the group by field as the accordion header. The attached file removes the reported bug, but doesn't introduce any more.

I have already committed this. Thanks all.

manuel garcia’s picture

manuel garcia commented
StatusFileSize
new views_accordion-656434.2.patch936 bytes

Forgot to attach the committed patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.