Hi,
I installed the module in combination with Module Grants like http://drupal.org/node/408968
Now as autor and corrector I have the folloging problems:

- I can edit an article just once
- at "view current" I dont see the current articel, I see the very first version of an article
- in the tab "versionen" i see two versions. if I click on the current one it shows me this version . but, if I click on edit current I see the very first version, not the current one.

manybe you know what my mistake is.

Comments

rdeboer’s picture

rdeboer
Location Melbourne
commented

So I presume you're using Revisioning 6.x-2.7 with Module Grants 6.x.2.6... not the development snapshots...
For what content type does this happen? Page, story, blog....?
You say, as an "author and corrector" you hav these problems. Does that mean that everything is ok as an admin?
If things are ok for the admin this may point in the direction of the "author and corrector" not having the right permissions... I suppose this role has the "view revisions" permission?
Do you have any other modules enabled that may affect access control?

chris_bbg888’s picture

chris_bbg888 commented

thanks for helping me to make the problem more clear:

- versions of modiles: Revisioning 6.x-2.7 with Module Grants 6.x.2.6

- I did a new content type. there i have the following options ticked (i translate from german)
---standard
---- create new revision
---- New revision in draft, pending moderation
---- (publish is not ticked)
--- New revision in draft
---- Every time revision content is updated, even when saving content in draft/pending moderation
--- Enable revisions page
---- Enable the Versionen page for this content type

- also for the root user (the one who installed drupal) I have the same problem. if I click on "view current" I just see the very first version on the article which i cannot edit

- its a fresh drupal installation. no other modules included. its 6.14 (i made a new installation to test revisioning) I just installed these 2 modules

well, do you know what it might be. with permissions it might be not the answer as the user that has all rights has the same problem... many thanks and best regards

rdeboer’s picture

rdeboer
Location Melbourne
commented

After further investigation I've established that there's an interference between the Diff and Revisioning modules, when the "Inline diffs " box is ticked (the side-by-side comparison DOES work).

I noticed also that with this latest version of Diff the link "Compare to current" ("Mit aktueller Version vergleichen") results in a "Fatal error: Call to undefined function diff_diffs_show()..."
This never used to be the case, so I suspect it's because something has changed in the Diff module. I will look into this.

In the mean time, for the content types that you want to use Revisioning on make sure that "Inline diffs" is off and you should be fine.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Category: task » bug
Status: Postponed » Active

Update: "Fatal error: Call to undefined function diff_diffs_show()..." doesn't appear when latest development snapshots of Module Grants, Revisioning and Diff are used.
When Diff 6.x-2.0 is used (the official release) the tabs are present and everything seems to be ok (using latest dev versions of Module Grants and Revisioning). However Diff 6.x-2.0 doesn't feature the Inline diffs feature.

While the fatal error no longer occurs when you press "Compare to current", the Edit tab (and all other Revisioning-related tabs) still disappear in 6.x-2.x.dev when Inline diffs is active.
I've tracked this down to the culprit, which is in the Diff module, version 6.x-2.x-dev, function diff_nodeapi(..):

      // @TODO: This is a bad hack that should instead be a patch against the node module.
     menu_set_active_item("node/{$node->nid}");

This line effectively hijacks the tabs introduced by Revisioning.

I don't fully understand why it should be there. In fact, if you comment out the above line (i.e. put a double-slash in front of it) the tabs reappear.
A question for the Diff module maintainers...

chris_bbg888’s picture

chris_bbg888 commented
Title: in the tab "view current" i doent see /cannot edit the current version just the very first » Edit tab not displayed when Diff module installed and "Inline diffs" ticked for content type
Assigned: Unassigned » rdeboer
Category: support » bug

Thanks RdeBoer for your time and effort. I'm out so I doent really get the problem as I'm just using drupal and the modules (not into programming yet). So I know this problem in good hands. Thanks very much.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Category: bug » task
Status: Active » Postponed

Following up from #4, this issue is now logged against the Diff module: #670378: Don't prevent other modules from doing their stuff

rdeboer’s picture

rdeboer
Location Melbourne
commented
Category: bug » task
Status: Active » Closed (won't fix)

Diff module issue.