Thanks for an excellent module. I would like to see a feature that allows the admin to indicate exactly which content types can be forward. For example, on my site at www.musicbuggy.com I only want to forward audio and blog content types.

Thanks for your efforts.

Rob Safuto

CommentFileSizeAuthor
#11 formignoresshowflag.patch580 bytesbudda
#5 contenttypeform.patch2.25 KBbudda

Comments

seanr’s picture

Will look into it. I like the idea, but I've got a lot going on right now and am focusing more on bugs at the moment. If anyoner has more time than I and wishes to submit a patch, that'd make me very happy. ;)

Anonymous’s picture

Understood. I appreciate anything that can be done. I'd give it a shot myself, but I'm just getting up to speed on installing/configuring Drupal and would be foolish to try out any code yet ;)

budda’s picture

I too need this configurability. If it's not been worked on by anybody I could submit a 4.7 patch for it.

seanr’s picture

I'd love a patch - I've been meaning to work on it but have just been too busy and never needed it myself so it wasn't a high priority.

budda’s picture

Assigned: Unassigned » budda
Status: Active » Reviewed & tested by the community
StatusFileSize
new2.25 KB

The attached patch adds a new option on a per-node type basis.

Each node page (example /admin/settings/content-types/story) will feature a new checkbox in the "workflow" group.
Selecting the checkbox will make the forwarding form/link appear on nodes of this type.

I've patched against the 4.7 version of the module, as that's what I'm using and the CVS version has the new re-worked hook_links() code in which isn't much use for the majority of people.

Anonymous’s picture

Thanks for giving this a shot. I will check it out and let you know how it goes.

Rob

Anonymous’s picture

Title: Forwarding By Content Type » Seems To Work Fine

I've applied the patch and have done a bit of cursory testing forwarding items. The new function seems to work just fine.

Thanks for the effort.

Rob

budda’s picture

Title: Seems To Work Fine » Forwarding By Content Type
seanr’s picture

Status: Reviewed & tested by the community » Fixed

Had to clean a whole bunch of imagedrop crap out of your patch, but it's working and committed to both HEAD and DRUPAL-4-7. Thanks.

budda’s picture

LOL. Yes, there is a lot of crap I didn't notice from my blind copy n paste from a module I was working on :)
Glad the feature has got in to forward.module anyway.

budda’s picture

Version: 4.7.x-1.x-dev » 7.x-1.x-dev
Category: feature » bug
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new580 bytes

The previous patch didn't work because a check in _nodeapi() was missing to see if the setting had been made to show the forward form or not.

So whatever the setting - the forward form showed anyway!

Patch attached to fix this.

seanr’s picture

Status: Reviewed & tested by the community » Fixed

One of the versions was missing the check before, but I fixed it yesterday. If you look at your patch, you'll otice your code does the exact same thing as the current version in CVS (just with slightly different code). ;-)

Anonymous’s picture

Status: Fixed » Closed (fixed)