Closed (fixed)
Project:
Forward
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Anonymous (not verified)
Created:
27 May 2006 at 16:42 UTC
Updated:
27 Jul 2025 at 01:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
seanrWill look into it. I like the idea, but I've got a lot going on right now and am focusing more on bugs at the moment. If anyoner has more time than I and wishes to submit a patch, that'd make me very happy. ;)
Comment #2
Anonymous (not verified) commentedUnderstood. I appreciate anything that can be done. I'd give it a shot myself, but I'm just getting up to speed on installing/configuring Drupal and would be foolish to try out any code yet ;)
Comment #3
buddaI too need this configurability. If it's not been worked on by anybody I could submit a 4.7 patch for it.
Comment #4
seanrI'd love a patch - I've been meaning to work on it but have just been too busy and never needed it myself so it wasn't a high priority.
Comment #5
buddaThe attached patch adds a new option on a per-node type basis.
Each node page (example /admin/settings/content-types/story) will feature a new checkbox in the "workflow" group.
Selecting the checkbox will make the forwarding form/link appear on nodes of this type.
I've patched against the 4.7 version of the module, as that's what I'm using and the CVS version has the new re-worked hook_links() code in which isn't much use for the majority of people.
Comment #6
Anonymous (not verified) commentedThanks for giving this a shot. I will check it out and let you know how it goes.
Rob
Comment #7
Anonymous (not verified) commentedI've applied the patch and have done a bit of cursory testing forwarding items. The new function seems to work just fine.
Thanks for the effort.
Rob
Comment #8
buddaComment #9
seanrHad to clean a whole bunch of imagedrop crap out of your patch, but it's working and committed to both HEAD and DRUPAL-4-7. Thanks.
Comment #10
buddaLOL. Yes, there is a lot of crap I didn't notice from my blind copy n paste from a module I was working on :)
Glad the feature has got in to forward.module anyway.
Comment #11
buddaThe previous patch didn't work because a check in _nodeapi() was missing to see if the setting had been made to show the forward form or not.
So whatever the setting - the forward form showed anyway!
Patch attached to fix this.
Comment #12
seanrOne of the versions was missing the check before, but I fixed it yesterday. If you look at your patch, you'll otice your code does the exact same thing as the current version in CVS (just with slightly different code). ;-)
Comment #13
(not verified) commented