Link to home

I like this idea a lot ... what is the argument against this?

Yes please! I like this idea a lot as well! This is one of the few reasons I really prefer using admin_menu over core toolbar in D7 right now.

Thanks for opening this issue. I came up with this because I do find myself scrolling back up on an admin page to click the 'home' link in the breadcrumb. Relying on breadcrumbs for this is not a good thing me thinks.

here is a first go at it... note that you need the attached home_icon.png image in your toolbar module directory

screenshot: http://img.skitch.com/20091215-f46nwbc1utegddktriapqbkhp.jpg

Instead of introducing a new home_icon.png, we should try to put this in the existing sprite (i.e. modules/toolbar/toolbar.png). Let's try to get it in, but it is not critical. Critical bugs prevent Drupal from working.

@Dries: I tried that... problem is that the current behavior of the toolbar uses the existing sprite image to show the gray bg on rollover. That means that when you roll over the "home" link, the house is replaced by the gray bg. Make sense?

Sooooo remember when I just said I couldn't figure out how to reuse toolbar.png instead of introducing a new img ... I lied. Here we go.

EDIT: see #9 for the correct toolbar.png

The toolbar.png that you attached in#7 does not seem to add a home icon?

Ooops ... thanks Dries. Please use the png attached to this comment instead

Doh! You attached the same toolbar.png

No he didn't :)
It's hard to see but it's there now.

+1 on this. relying on the breadcrumb is ridiculous.

+1 on this. relying on the breadcrumb is ridiculous.

Committed to CVS HEAD. Thanks!

Ooh, had to refresh my browser cache on toolbar.png to see the icon.

This was committed way too soon yeah. Guess we continue here with follow ups…

subscribe, I was happily surprised when I saw this! :)

Critical bugs prevent Drupal from working.

Dries: bugs that prevent *People* from working should be regarded as critical too. I'd consider this a small but critical flaw in the default IA.

We could do it like this.

And the updated toolbar.png…

fancy-schmancy. I like it!

For the overall impression of visual weight of this approach:
active: http://skitch.com/yoroy/nm9mg/d7
not active: http://skitch.com/yoroy/nm9mq/hello-world-etc-d7

+1 on yoroy's #19.

I don't think it was committed too soon -- it is OK to follow-up with refinements. :)

The new icon in #20 is much better than the old one so I committed that one.

Feel free to mark this 'fixed' if we're all happy with it. If not, I'll check in in a couple of days.

Keep up the great work. Love the new icon!

By the way, I think the home button (the background, not the house itself) could be a few pixels less wide. That might be personal taste though.

And I agree. I tried, but:

If somebody knows how to make the rounded corners slide in *below* the icon I'm all ears.

#toolbar div.toolbar-menu ul#toolbar-home li a {
-moz-border-radius-bottomleft:10px;
-moz-border-radius-bottomright:10px;
-moz-border-radius-topleft:10px;
-moz-border-radius-topright:10px;
padding:0 4px;
}

i tried this.

coming patch to the last sprite png

Fancy-smanchy sounds nice but doesn't match the overall basic esthetic of Seven. Must. practise. restraint.

Sprite for this iteration attached.

I mean this one of course…

this patch addresses #26

patch for #31

Awesome. Thank you both!
Lets get some reviews :)

I'm not sure about #19. The icon for when you're not at home does NOT look like a button you can click on, but the button for when you are at home DOES look like a button you can click on. That seems backward to me. i.e, the highlight does not say "You are here" to me, it says "I am a button, click on me".

@merlinofchaos ... #19 does match the convention for the rest of the toolbar options though

I only have the skitches that yoroy linked to go on, but the feeling I get about that is pretty strong. In the actual linked images, where it IS in isolation, I didn't really think about it. When I clicked through the skitch links yoroy did, I did a doubletake because I thought the images were reversed at first. Maybe it won't ultimately be confusing but it certainly confused me initially.

By way of example, look at http://skitch.com/yoroy/nm9mg/d7 and look at the home icon on the left and the arrow down icon on the right. The visual distinction between them is very small. Both look button-like to me. I know it doesn't seem that way when there is text there in the highlight, but with the icon it does seem button like.

#663126: Active items in top level IA don't have the light gray background when overlay is enabled is the reason the active state for the icon looks like an exception.

Disagreeing and agreeing with Merlin. I too think the design is a bit backwards, but that's the way it works across the entire toolbar. If there's a request to change this, I think that's a new issue. Regarding this issue, I think yoroy's design is a huge improvement. +50

If my concerns are an issue with the entire IA, that's definitely another issue and it shouldn't block the icon.

This patch should make it look like this:

Uses toolbar.png in http://drupal.org/node/658726#comment-2386346

Let's see what Earl thinks?

I think my issue is with overall IA on the hilighting and should not block the icon from going in with yoroy's choices.

@merlinofchaos, I'm slightly confused because your original feedback was very visual, and had nothing to do with the IA. Are you able to articulate your confusion relative to the IA? Would love to better understand the relation to the home icon.

Well, as Noyz points out in #40 the visual styling of the hover and active states *for any link in the top level IA*, isn't optimal. Merlinofchaos rightfully points out that the current styling makes things look like a button. Using an icon just makes this a bit more obvious to see and I assume that's what triggered Earls comment.

The current styling is not the issue at hand here though. Nor can we afford another text link in there, it would take up too much space. So for now, we choose to live with it. Having a link to the front end in there at all is far more important than the styling.

BTW, the former comment was written after talking about it with merlinofchaos. Patch in #43 and toolbar.png in #30 are RTBC, somebody mark it as such please.

Committed to CVS HEAD. Thanks.