(D6 backport) syslog_watchdog() using theme()

Setting to needs review

If syslog_watchdog() is called early in bootstrap, the theme() function does not exist yet, which results in a fatal error.

In case anyone else hits this issue, this is the patch I applied to work-around the fatal error so I could access my site:

Index: modules/syslog/syslog.module
===================================================================
RCS file: /cvs/drupal/drupal/modules/syslog/syslog.module,v
retrieving revision 1.33
diff -u -p -r1.33 syslog.module
--- modules/syslog/syslog.module	27 Jan 2010 11:29:51 -0000	1.33
+++ modules/syslog/syslog.module	29 Mar 2010 19:07:15 -0000
@@ -80,7 +80,9 @@ function syslog_watchdog(array $log_entr
     openlog('drupal', LOG_NDELAY, variable_get('syslog_facility', $default_facility));
   }
 
-  syslog($log_entry['severity'], theme('syslog_format', array('entry' => $log_entry)));
+  $variables = array('entry' => $log_entry);
+  $message = function_exists('theme') ? theme('syslog_format', $variables) : theme_syslog_format($variables);
+  syslog($log_entry['severity'], $message);
 }
 
 /**

One thing about syslog-d7-theme.patch: If syslog_watchdog is called early in bootstrap, we have the same problem with drupal_alter() as with theme(): the function is not yet defined.

Here's the fatal error for anyone experiencing errors/warnings during bootstrap and using syslog: PHP Fatal error: Call to undefined function theme() in /modules/syslog/syslog.module on line 83

Removed drupal_alter() so syslog works in early bootstrap. Also changed the tokens to use "!" rather than "%" to match those in plain-text e-mails (the variables are not HTML-encoded).

Looks reasonable to me. Would be good to get another pair of eyes.

Reroll due to #716496: Theme functions group needs some updates

Looks good to me. Nice work!

Committed to CVS HEAD.

Hey, should we get a back port of this?

Seen this bug on D6 sites as well, I agree this'd need a backport.

The same problem during CRON run with Drupal 6.20
Cron shouldn't init theme functions.

But:
drupal_cron_run() calls:
watchdog('cron', 'Attempting to re-run cron while it is already running.', array(), WATCHDOG_WARNING);
which calls syslog_watchdog()
then theme('syslog_format', ) syslog.module:86
which init the whole theme by: init_theme()

The same with: drupal_cron_cleanup()
it's registered as shutdown function in common.inc (drupal_cron_run())
which cause: watchdog($type = 'cron', $message = 'Cron run exceeded the time limit and was aborted.')
and the same problem with init_theme() which is just beginning of the problems, because when doing shutdown on Apache, the whole Drupal is broken, because current path is not pointing to Drupal core, causing lots of other weird errors.

Here is a D6 version of the same. Of course there is no backwards compatibility for people using the theme() call, but it's still worthwhile.

Warning: openlog() has been disabled for security reasons in syslog_watchdog() (line 94 of /home/name/domains/sitename.com/public_html/modules/syslog/syslog.module). This is my problem that show me when I just installed and enable Syslog module.

@anusornwebsite: Please do not hijack existing issues for new bugs. Instead, please file a new issue. Thanks.

syslog-d7-theme.patch queued for re-testing.

patch #16 worked for me but I had to do patch < syslog_format_0.patch for it to apply.

Here is an updated patch that should apply this

patch attempt

Hi All

After i change my hosting and update my database everything seem to work properly but there some error occur here :

warning: openlog() has been disabled for security reasons in /home/user/domains/mysite.com/public_html/modules/syslog/syslog.module on line 83.
warning: strtr() [function.strtr]: The second argument is not an array in /home/user/domains/mysite.com/public_html/modules/syslog/syslog.module on line 113.

any idea ?
Thank in advance

Oranjer

oranjer: disable the syslog module.

thank you bfroehle

I will do as your advice.

regards
Oranjer

I do not understand #22 and #24. Are they made just the wrong way (new->old), or is there something different inside the logic.

Logic from #16 works for me.

subscribe.

this also lets the block administration page (admin/build/block) fail to switch theme.
(just to mention it)

Subscribe

This is broken enough it should be major.

Huh? This has already been fixed in 7.x and above in http://drupal.org/node/659784#comment-2871880. This is about backporting this to 6.x now.

Doh, this is a backport, but I got very confused by the hijacking.

Maybe adding to the title will help prevent the same confusion. :)

syslog-d6-theme.patch queued for re-testing.

This is a straight re-roll of Jacob's patch in #16 (subsequent patches were reverts for some reason), just for the git migration.

Also marking RTBC.

Actually marking RTBC this time.

syslog-d7-theme.patch queued for re-testing.

Worked for me. Seems like this is RTBC!

not sure why this was switched to needs backport