Posted by mfb on December 23, 2009 at 8:58am
12 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | file.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | acouch |
| Status: | needs review |
| Issue tags: | needs backport to D7, regression |
Issue Summary
Core has supported the RSS enclosure element since Drupal 4.6 via Upload module hook_nodeapi() implementation. This has allowed Drupal sites to syndicate media to various apps and sites (iTunes, Miro, Odeo, etc.) out of the box. Now that Upload module has been axed we should try to restore this feature to core, for example, via a file field formatter that generates RSS enclosure elements.
Comments
#1
Ideally this field formatter would only apply to RSS build mode(s). And ideally this would be the default format for RSS build mode. But I'm not yet sure how to do this...
#2
That is to say, RSS view mode :)
#4
subscribing
#5
#1: enclosure.patch queued for re-testing.
#6
subscribe
#7
Nobody referenced #872488: Regression: no way to get taxonomy tags into RSS feeds here yet. Hopefully these issues have a common solution. (subscribe)
#8
My thought is that contrib modules could define additional view modes that output RSS, in addition to the built-in
rssview mode. So, we'd want to have each view mode indicate its output format -- HTML, RSS, plain text, etc., -- and each field formatter indicate which ouput format it supports. This would allow us to add a field formatter that can only be selected for RSS view modes. Also, modules should be able to define a default_formatter for each output format, so in this case the RSS enclosure formatter would be enabled by default for any RSS view modes.#9
Suppose view-mode should be inherited from entity to field. What rss-formatter means while entity viewed in search-resulot mode?
#10
I've been looking at format_xml_elements() today, and I glanced over node_feed(), format_rss_channel(), and format_rss_item(). What stands out is that format_xml_elements() renders an array, but it's not a drupal_render-able array.
The structure of this array when dealing with a large document is hard to grok and falls when handling XML nodes that are not XML elements (nodes such as comments, CDATA, etc.).
If format_xml_elements() were refactored to handle renderable arrays, field formatters and alter hooks could be used to intervene in the rendering of RSS XML.
Forgive me if this is naïve. I admit it doesn't look like a simple fix.
#11
Seems like a bug (regression) to me.
#12
Sheesh. I'm sorry. I was looking at node_feed in Drupal 6 again. Drupal 7 is already doing something quite along the lines of what I was imagining.
#13
Fixing the priority.
#14
#1: enclosure.patch queued for re-testing.
#15
I made a tiny module, which is more-or-less just this patch, to restore this functionality for a site. I could add it to d.o. if there's no movement on this issue.
#16
ok here's a contrib module to restore this feature: http://drupal.org/project/rss_field_formatters
#17
Since there's a contrib workaround, demoting to normal.
#18
Working on a reroll and test for this.