The options to control which fieldsets are collapsible and/or collapsed seem out of place for this module:
1. They only control 4 fieldsets and only the core fieldsets. A solution should work for any fieldsets on the node edit pages.
2. We should probably support a better and more helpful solution, like the Vertical tabs module back-ported from D7.

Comments

timmillwood’s picture

This was originally added because it was something I needed at the time and sort of fitted within this module.

I'd be open for suggestions and thoughts, I know there is a better solution.

joachim’s picture

The collapsing options are pretty much outside of this module's declared scope; I was going to suggest we pull that out too.

What would we need to do to support Vertical Tabs? Now we're using the same form names, do we need to do anything in fact? won't installing Vertical Tabs just take over?

rootwork’s picture

Title: Remove fieldset handling code and support a generic alternative » Remove fieldset handling code, support generic alternative and Vertical Tabs
Issue tags: +vertical tabs
StatusFileSize
new21.7 KB

Not entirely. I just ran across this after installing vertical tabs on a site with this module.

The use case is that a node author has ability to change the date of their node, but not its author.

Normally, vertical tabs takes what's usually in the "authoring" section (author + post date) and displays the author's name in the tab title.

With the ability to change the author disabled, upon creating a new node, the "authoring" vertical tab displays "By Anonymous" as the author (see attached screenshot), even though if one saves the node, it is indeed created by the correct author.

There may be other similar vertical tabs displays that this affects, but this is the one I noticed.

dave reid’s picture

This should probably actually be fixed in core's handling of vertical tabs summaries to not output that summary if the field is not present.

rootwork’s picture

opdavies’s picture

Issue summary: View changes
Status: Active » Closed (won't fix)