Posted by Narhir on December 29, 2009 at 9:37am
7 followers
Jump to:
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | other |
| Category: | task |
| Priority: | normal |
| Assigned: | Narhir |
| Status: | active |
| Issue tags: | D7 theme, Needs design review, theme design |
Issue Summary
Hello,
Please take a look for my idea for Drupal 7 theme and let me know what do you think? should I code it? should I change something before coding it? what should I do next ?
http://i47.tinypic.com/bjiqtx.jpg
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| sample2.jpg | 136.32 KB | Ignored: Check issue status. | None | None |
Comments
#1
Hmm, not sure how well this would work as a core theme:
* The logo text is an image (and thus can't take on the Site Name easily)
* There are images in the mockup that obviously won't be there on a live site (you can't hardcode images into a core theme)
* Same with the two column block-ish layout. You could put in two side-by-side block regions I suppose (content-bottom-left and content-bottom-right or something) but it just seems like a strange idea if we're going for the flexibility that a core theme demands.
* Welcome message and time at the top must be removed (can't hardcode stuff like that into a core theme)
* Three links at the top must be removed (the top should just be a block region so people can add menus if they'd like, but it must also look good if they don't add anything to this block region)
Thoughts on the above comments?
#2
#3
I don't think we can add in a new base core theme at this time, and even if we did, it would have to be put through so many reviews that it would hold up reviews in other areas of theming for Drupal 7... Your theme would be excellent, though, to have as a contributed theme on the http://drupal.org/project/Themes page!
#4
Tagging
#5
I see nothing that hints at this being a *base* theme. There are other proposals out there that are active and were submitted later than this. Setting back to active.
edit: oh, I see the original title mentioning it. Keeping status active regardless :)
Also, read http://drupal.org/node/686410#comment-2528610. Time is getting *very* short.
#6
IMHO, this design does not (yet?) have the quality that is needed for a core theme. The combination of colors, typography, positioning, graphic elements, navigation etc. simply don't add up to a coherent unity.
Also, if you want this to be a core theme, there is much more to design. Think of all those things you see in a typical Drupal site: tabs, messages, html lists, tables, admin pages, forms, the login block, comments, nested menu items...
If we want one or more new themes in D7, I think we should spend our time and efforts on the proposals that are closer to being RTBC:
#683026: Add a new theme to D7 core: Bartik
#695292: Add new theme to core: Busy
#686410: New core theme for Drupal 7: Corolla
#7
Seems the other issues for adding core themes to D7 are assigned to the "other" component, so doing the same with this one.