Adsense - Please port to Drupal 7

Hi,

I can't speak for kbahey, but as the guy who maintains the code nowadays, I can tell you my plans which are:

1. Wait until Drupal 7 gets an official release, so that I don't have to keep changing the code, and:
2a. Have some free time (not in great supply nowadays) to do it for free.
2b. Do it in my 'work time' if someone decides to sponsor it..

João

Following

Subscribe.

Thank you for porting this module to Drupal 7 beta 1

Subscribing.

following too ;)

Did Danvy in #4 say that this module has been ported?? I see only the 6.x. Can you teel me where I can find it please?

Hi stehope: I think Danvy's comment was meant as "thank you (in advance) ... ". The process of porting the Adsense module to D7 does not appear to have been begun yet, but I suspect people will begin that task soon. ;-)

OK thanks. I would like to collaborate. But now I'm not yet able to code php. Maybe I can help with the italian translation.

subscribe

Just started a port to drupal 7 for a new site, AdSense core, managed and CSE working. If anyone wants to help or take a look here's the github adress : https://github.com/takeova/Adsense-Module

It would be a lot better if you shared a patch here.

Ok, no problem jcnventura here's the patch, everything except Revenue sharing basic (old) and Search (old) are done.

Little cleanup of the patch

#13: Thank you Takeova.
In the post linked below jcnventura said that adsense injector will be integrated in adsense with its next release, too.
http://drupal.org/node/486316

Would be great to download a drupal 7 release of this module

Subscribing.

+1

+1

Im getting a bunch of "1 out of 1 hunk FAILED" when I do a test patch on patch 7 or patch 8. Im pretty green when it comes to patching, so Im not sure if Im doing something wrong.

For now I guess I will just get the working module from your site as Im not a rocket science programmer. Thanks for the good work!

oh and I also have a question. Is it possible to use tags in order to show ads within the content with this drupal7 version? Or have you not patched that functionality yet?

Moved back to needs work since the patch is old and that Drupal have seen some changes that may or may not affect this port.

Also, I believe that none of the ”(old)” modules should be updated, as they are deprecated.

Feel free to move it back to “needs review” if no changes are required.

I will test this patch (or any new one) later.

+1 on not updating old deprecated modules.

+1 for not upgrading the old modules.
Here's a patch for core, managed, cse and click. Everything is I think working properly.

#15 : I think we need first to update 6.x-1.x-dev to 7.x before adding new feature

I cannot test this today, but thanks for the patch.

I figured out what my problem was. I was trying to patch the released version of the adsense module instead of the dev version. So now I got adsense_8.patch to work fine....

However adsense_9.patch gives me a bunch of (Stripping trailing CRs from patch.)
Then at the end it says "patch unexpectedly ends in the middle of line" and "Hunk #2 succeeded at 32 with fuzz 1."

Im not sure if it patched or not. :(

#26 :
CRs errors are due to the fact I did this patch on Windows and forget to add Linux ending line. For the second error, for some reason the patch was truncated, I've uploaded a new one.

Not sure what is the problem with adsense_9.patch, but when I update and install the module, I can no longer edit any configurations. Clicking on configure or permissions just causes the screen to grey out, but the edit screen doesnt show up.

Looks like you are using the wrong patch. Please try adsense_10.patch available in comment #27.

I meant patch 10. It just hangs when you click on permissions or configure. Is it working for you xmacinfo?

Discovered the problem!!

If you are viewing the modules via the default drupal popup style...
http://www.myurl.com/#overlay=admin/modules

Then if you click on any configurations, it just hangs. However if you go direct to the modules page by typing the url in like this
http://www.myurl.com/admin/modules

Then it works. so something must be wonky with the javascript in the adsense module.

#31 : One of my client had the same problem turns out it was caused by Adblock Plus. Maybe your problem is related ?

DOH! That was the issue. As soon as I disable adblock plus in my firefox, all is well again! Sorry for being such a dolt.

Hello, i can not find the Adsense Module for Drupal 7. Can someone post a Link to the code.

Regards
peterherman

Following

Hi Peter
For my D7 site.
I've downloaded 6.x-1.x-dev
Used NetBeans to apply the latest .patch to the Module folder and contents. Location of the latest .patch is in the thread above.

Following

following

following

Subscribe

Im still curious on how to turn on the "adsense tag filter" so that we can put adsense tags inside out nodes. Does anyone know how to do this?....or is this feature not part of the new patch?

subscribing

#42 : Go to admin/config/content/formats and chose which format you want to activate the tag format and click configure and then you will see "AdSense tag".

Watching

Subscribing

#1
...
3. have a new/co-maintainer
Adsense is still a popular module and should be maintained in the best possible way. So, if you don't have time (which is fully understandable) that might be a proper solution.

Subscribing

I've built on #27, fixed a bunch of issues, fixed coder errors and warnings, removed dead directories (old and translations) and other minor things. One thing to note is that the config menu is now in admin/config/system/adsense . I couldn't think of any other suitable place for this item and went with the decision that the Google Analytics module appears to have made.

I only really use the core and managed ads modules and have only done some perfunctory testing on everything. Ergo, please test and update this ticket. Besides the patch, I've also attached the ported module in .zip format which should be ready for use for those of you who have not discovered the benefits of VCS.

Thanks,
-K

A D7 release will appear here in about 4 hours from now #1055594: adsense 7.x-1.x-dev.

Thanks Zen and takeova.

Indeed. Here we go:

http://drupal.org/node/1055594

I was wondering when will the adsense revenue sharing basic be ported to drupal 7

It's never a good idea to reopened closed and fixed issues.

Please create a new issue.

Just to let everyone here know that I've updated the module making the following changes:

1. Moved the module configuration path from "System" to "Web services"
2. Synced the generated ad javascript with the current output from Google
3. Synced the CSE watermark javascript with the one from Google
4. Ported the "old" modules to D7 (necessary for revenue sharing)
5. Started work on porting the revenue sharing to D7.

I'm planning to make a beta1 or rc1 in the short term.

@jcnventura I keep track of issues here and if you grant me commit access I can commit patches after review and keep things moving forward plus contribute were possible. Thanks for starting the port of revenue sharing!

@likewhoa: maintainership status is a large responsibility that requires some proof.. I realize and apologize for my long hiatus on doing this port, but I don't remember having seen any patches from you. Feel free to help in the issue queue, and to test the module, but I think the next chance for commit rights will be the port to Drupal 8 :)