Node Form Rearrange alters a node's data structure via hook_form_alter and then puts it back via hook_nodeapi on presave. But, Simplenews, in the meantime, validates the node ( via hook_nodeapi on validate) and, not finding the structure it expects, throws an error unavoidably, every time:

No newsletter term is selected, the newsletter taxonomy term is probably not configured correctly.
Check and save the Simplenews general settings.

In other words, installing Node Form Rearrange will render it impossible to add or edit any Simplenews nodes on your site. Until this is fixed, there should probably be a compatibility notice added to the Node Form Rearrange project page. A simple, short-term workaround might be to add the ability apply the module's functionality on a per-node-type basis (which might be nice to have anyway). As to actual solutions, the data structure either needs to be replaced sometime before the hook_nodeapi validation routine, or, more preferably, the functionality needs to be accomplished in a way that doesn't fundamentally change core structures like that. I'm afraid diagnosing the problem is all I've got the chops for at the moment. :) Anyone care to take a crack at fixing it?

Comments

chiddicks’s picture

chiddicks commented

Please try the latest dev version, which has per-content-type settings.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It's still a problem with the latest code. The root problem is it changes form elements that don't get changed back before validation.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Actually it might be worth deprecating this module in favor of http://drupal.org/project/content_taxonomy which is much better for allowing you to configure where the taxonomy terms go.

chiddicks’s picture

chiddicks commented
Status: Active » Closed (won't fix)

This module is not compatible with everything, nor is it a long-term solution to node-form layouts. It is known to have compatibility issues with numerous modules, like simplenews and forum. It's really only for the particular case where Content Taxonomy does not provide the taxonomy widget needed, and the standard taxonomy field does. I'm adding a link to Content Taxonomy on the module's main page to highlight this.

The only solution to this problem I can forsee is changing this module from modifying forms at the hook level to modifying them on the theme layer. I have made several attempts at this and have not yet found a good way of making this work. I can post code I have if anyone's interested.

idevconsulting’s picture

idevconsulting commented

Hi,
I don't use Form rearrange and I've got also this pb. I can't create a newsletter because when I try to save I've got the message : "No newsletter term is selected, the newsletter taxonomy term is probably not configured correctly."
In fact I have a multilinguale site with i18n.
I remark that I haven't the vocabulary fields in the content creating screen.
Does anyone got an idea ?
Thanks a lot
claire