With views 3, handler::options(&$options) to define the options for a handlers is not supported anymore.

I have noticed that flag use option_definition for relationships handler but still use options() for field and filter handlers. This produce that options for these handlers were not configurable when views 3 is used.

This patch fix that, views 2 integration should work without problems.

CommentFileSizeAuthor
flag-views-3.patch1.2 KBdagmar

Comments

quicksketch’s picture

quicksketch
he/him
commented

Thanks dagmar! So if I'm understanding this correctly, the options() method still works in Views 2, even for field and filter handlers?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

Hi quicksketch, yes options() works for views 2 (but not for views 3), however options_definition works for views 2 and 3 without problems.

Bilmar’s picture

Bilmar commented

Patch applied smoothly and the issues I was experiencing with Flag in Views 3 was resolved.
Flag is definitely an essential module and I'm glad that this patch will allow me to move to Views 3 when released.

@dagmar - If possible, could you please look into if User Relationships module http://drupal.org/project/user_relationships requires updating for Views 3 as well? Thanks for the great work!

For quicksketch's reference, below are links to other modules updating to options_definition for Views 3.
CCK - http://drupal.org/node/670344
Content Profile - http://drupal.org/node/670092

rburgundy’s picture

rburgundy commented
Status: Needs review » Reviewed & tested by the community

tested and works great. i'm really wanting to move to Views 3 even as dev version as the new features are great.
hope we can get these patches committed with the help of the community

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed

Tested with Views 2 and it continues to work just fine. Thanks dagmar! Committed to both 1.x and 2.x versions.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.