http://drupal.org/node/64590 is not getting releases added to the project_releases table, even though the nightly tarballs are being built. everything else looks reasonable in this project node. local testing can't reproduce any problems. at this point, some additional watchdog entries and another release scan on drupal.org seems like the only way to try to figure out what's going wrong. as per discussion with killes in IRC, here's a patch to add these new watchdog logs...

Comments

dww’s picture

StatusFileSize
new3.19 KB

slight improvement: calls project_release_scan_directory_results(t('error')) so the summary after the scan shows a total count of errors (though not the ones caught in file.inc, which i suspect are what might really be nailing this module...)

dww’s picture

StatusFileSize
new8.26 KB

alas, my suspicious about where the problem was caused the previous round of debugging to not reveal the bug. here's a new version that:

  1. checks for errors in the db_query() calls where we're trying to save records into the {project_releases} table
  2. prints tons of verbose messages at many steps along the way if we're looking at the 'version' tarball (sorry it's a little confusing, 'version' is the name of the project that's not getting released...).
  3. now includes the name of the project being unpublished whenever we unpublish a release (we'll probably want to keep this for real longer term, but i'll clean up these watchdogs for the official version another time).

hopefully this will reveal the true problem...

p.s. the extra watchdog in includes/file.inc isn't needed, since that's not where the problem is. therefore, this patch doesn't include it.

dww’s picture

Title: temporary watchdog messages for debugging problems with releases » better watchdog messages for debugging problems with releases

yay! killes and i found the problems with the "version" module (and Lightbox V2, the turkish translation, node agregator, and the paypal framework). apparently, all of these had old (or newer) project nodes that were created. see http://drupal.org/node/67877 for explaination (and solution) for the underlying bug.

however, we should make some of the errors reported by my earlier temporary debugging patches real, permanent watchdog events, just in case there are ever problems with any of this in the future. here's my todo-list for improved logging and error propagation:

  1. log a WATCHDOG_ERROR if we fail to insert/update a record in project_release, with the name, nid, path, and mysql error string.
  2. keep the more useful messages when we unpublish a release
  3. keep the watchdog record whenever we can't find a project node that matches a given tarball
  4. keep the watchdog record if we find a duplicate nid/version pair and aren't going to publish it

on the summary page after the scan completes:

  1. list all the path/nid/version tuples that we failed to update/insert
  2. list all the unique project names for tarballs that we didn't publish b/c we couldn't find a project node for them
  3. continue to publish the "had no project" total

that should be pretty good. i'll roll a patch in the near future that can be reviewed and committed to the official release of project in cvs.

dww’s picture

Status: Active » Closed (won't fix)

this is now obsolete thanks to the new release system. ;)