db_rewrite_sql() DISTINCT(n.nid)

Hello Kate,

I have fixed the issues regarding the blocks from Gallery Assist.
I need your help. Can you test the module with the fixes.
Only if you find a time for that.

I dont know, why people not protest before about the GA-Block issue. Crazy.

I thank you in advance
If this is not possible for you let me know it please.

Regards and tahnks again
Juan Carlos

PS
I hope the issue is gon after the update to this version I send to you here.
I want release it as rc2 because the currently rc1 version is a little bugy. I have commited the fixes to the dev but the most users dont read the notes and download the wrong versions also is better I release a working version.

I give your opinion huge importance.

here the package.

Regards

Thanks Kate,

I am using in my dev machine the MySQL version 5.1.37 and at http://ga-6.x-1.9.puntolatinoclub.de the MySQL Server version 5.0.51a-3.
By me works.

In your installation you use a module that created the issue, maybe a access module.
I not use in my sql-statement the code DISTINCT(n.nid). Through the function db_rewrite_sql() other modules rewrite my statement, unfortunately with a wrong statement. The question is which. I find it someday. It is difficult to find something so, from one day to another.

Similar but much more critical case is http://drupal.org/node/682562.

The function db_rewrite_sql() must be used because I get data from the node table and:

Use db_rewrite_sql to respect node access restrictions.
Most SQL statements which refer to nodes or the {node} table should be wrapped in a db_rewrite_sql() function call.
from the site http://drupal.org/writing-secure-code

The last thing I wanted was, you with such matters to harass.

Many thanks to you.
Juan Carlos

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DISTINCT(n.nid) FROM gallery_assist_item p JOIN gallery_assist_translate' at line 1 query: SELECT p.pid, p.uid, p.tpath, p.opath, f.timestamp, t.ptitle, g.gid, g.data, n.title, n.type, DISTINCT(n.nid) FROM gallery_assist_item p JOIN gallery_assist_translated t ON p.pid = t.pid JOIN files f ON p.fid = f.fid JOIN gallery_assist g ON p.gid = g.gid JOIN node n ON g.nid = n.nid WHERE p.uid = 1 GROUP BY g.gref ORDER BY f.timestamp DESC in /var/www/drupal_website/modules/gallery_assist/gallery_assist.module on line 2778.

how do i fix it?

Hello people, Hello fluxrider,

can you test my first attempt to fix the DISTINCT issue???

I thank you in advance.
Of course if you can.

Regards
Juan Carlos

PS
I send to you that what should be the 1.9-rc3 version from GA.

I had the same error message* whenever I tried to use the downloaded lightbox2.04 version uploaded in "gallery_assist_lightboxes/lightboxes/lightbox". The error message apeared at the top of the page after the title but the gallery and the lightbox did work despite the error message. Although with some problems. Double X (close) icons in firefox e.a. I saw via firebug that the system was loading the css files from both the lightbox subfolder and the lightbox2 module.
While looking at a gallery_assist_lightboxes file named "for Kate" somewhere in these posts I saw that empty lightbox folder and I gave it a try. And it worked!
Just an empty "lightbox" folder in gallery_assist_lightboxes/lightboxes/ made the whole system work for me (with Lightbox2 module already installed).

By the way that site where the documentation, examples etc links show to is not working "Site off-line" it says for at least a few days now.

* The error message: "file_get_contents(sites/all/modules/gallery_assist_lightboxes/lightboxes/lightbox/js/scriptaculous.js?load=effects,builder) [function.file-get-contents]: failed to open stream: No such file or directory in /home/freckses/public_html/includes/locale.inc on line 1689."

Hi,

I have tested the rc3 (gallery_assist-BACKUP-01.03.2010.tar_.gz)

With rc2 I get this error when i try to open the gallery in the profile

•user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DISTINCT(n.nid), n.created, n.title FROM gallery_assist_item p ' at line 1 query: SELECT count( * ) as items, DISTINCT(n.nid), n.created, n.title FROM gallery_assist_item p JOIN node n ON n.nid = p.ref WHERE p.uid = 4 GROUP BY p.gref ORDER BY created DESC in C:\inetpub\wwwroot\new500club\modules\gallery_assist\gallery_assist.module on line 383.
•warning: Invalid argument supplied for foreach() in C:\inetpub\wwwroot\new500club\modules\gallery_assist\gallery_assist.module on line 390.

1. Rc3 resolves this problem, but only the admin can view the gallery in the profile (http://mydomain.com/user/X/user_galleries).
2. It seems, that "Gallery Public Status" does not work correctly. Anonymous user can see the gallery (xy, see below) of the userX although user X set his gallery as "private".

Settings for 2.:
Permission: Anonymous can see "gallery assist content"
../admin/settings/gallery_assist# --> "Gallery Public Status:" --> privat
node/xy/edit --> Gallery Public Status: privat

Possible, that gallery assist has a conflict with my used "Nodeaccess 6.x-1.3 " module! Normally i have a tab with "grant" in my content types (article and so one). Only gallery did not have this tab!

Regards Jakob

Hello Jacob,

I will investigate the issue "Nodeaccess and GA" first.

To satisfy your interest to the issue "xy" the whole status functionality is not implemented in this version, only the form is created.
It will be implemented by the "coming soon" release. :-)

About "xy". I have a problem to understand the issue. Maybe it is the filosophy of GA what people not understand. It is caused (my opinion) through the missing of information, documentation.

Can you explain what you want/need or what do you suggest/expect? (In Deutsch auch)

I thank you in advance
Regards
Juan Carlos

Hello Juan Carlos,

in german is better to explain for me.

Erstmal Kompliment für das Modul. Ich habe lange nach einem vernünftigen Galerie-Modul gesucht und bin letztendlich bei GA gelandet.

Auf die Implementierung "Einstellungen für diese Galerie" ("Veröffentlichung") bin Ich gespannt.
So wie Ich das sehe kann die Einsicht auf das Galerie-Node aktuell nur über Berechtigungen verhindert werden und freu mich deshalb auf die neuen Veröffentlichungsoptionen.
Eventuell kann man das sogar mit Nodeacces kombinieren, so dass Benutzer nur bestimmten Benutzern erlauben die Galerie zu sehen

Hier ein paar Anregungen und Wünsche für das Modul:

1. Bestimmten Editor als Standard für Galerie setzen. Bei mir kommt immer der FCK-Editor (bei mir Standard), und der nimmt viel Platz ein.
   Für galerie würde Ich gerne den Standard-Editor nutzen, gerade für das Nachbearbeiten
2. Neue Option in Berechtigung zum Anzeigen der Optionen wie Teaser, Container, Download-Link und
   "Zeige diese Galerie als". Sind alles Optionen, die einen normlen User verwirren. Für Admin oder versierte User aber eine tolle Option!
3. PHP Upload Einstellungen werden nicht berücksichtigt
   In meinder Testumgebung waren nur 2 MB erlaubt. Bei Klick auf Aktualisieren ist aber nichts passiert und es kam keine Meldung
4. Ach ja, hier fällt mir schon nichts mehr ein. GA ist einfach und gut!

Super finde Ich auch, das GA im Gegensatz zu den anderen Gallerien nicht unbedingt zusätzliche Module erfordert und trotzdem schon sehr gut aussieht!

Gibt es ein Handbuch für GA? Gerne helfe Ich auch dabei, ein Handbuch zu schreiben bzw. zu erweitern!
Deine Seite ist gerade offline. Wann geht die wieder online?

Gruss Jakob

To find proper topics in the future, different topics should not be discussed in the same thread. anandax, you should better open a separate ticket for each of your requests/offers.

Bestimmten Editor als Standard für Galerie setzen. Bei mir kommt immer der FCK-Editor (bei mir Standard), und der nimmt viel Platz ein. Für galerie würde Ich gerne den Standard-Editor nutzen

This does not need to be addresses by Gallery Assist. I would recommend to install Better Formats and set the default input format for the "Gallery" node type to "Filtered HTML", while the global default input format (affecting all other node types) is set to "Full HTML". That's the way I have done it.

You are right. I will make a new topic the next time!
Thanx for solution!

the issue is allready fixed.