Designers and developers to those does not suffice id and classes in tags, this patch solves this problem in the node.module.

CommentFileSizeAuthor
node_52.patch587 bytesB.X

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
Version: 4.7.2 » x.y.z

features go into development version.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Same thing here... a couple things:

1. Attributes need to go in quotes: id="something" -- all Drupal output has to be valid XHTML.
2. the t() function should only contain straight-up text whenever possible. So in this instance, you'd do something like:

$output = '<div class="nodeadd">'. t('Choose the appropriate item from the list:') .'<dl>'. implode('', $item) .'</dl></div>';
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs work
Stefan Nagtegaal’s picture

Stefan Nagtegaal commented

I'm not seeing why we need another <div> here..
It would be better and symantically correct to put the text between <p>aragraph tags..
The new div just doesn't make sense for this small sentence..

A big -1 on this..

Steven’s picture

Steven commented

He posted a reply as a new issue, but without a fix:
http://drupal.org/node/79840

ChrisKennedy’s picture

ChrisKennedy commented
Version: x.y.z » 6.x-dev
Status: Needs work » Closed (won't fix)

Text removed by http://drupal.org/node/125092