Closed (fixed)
Project:
Project
Version:
4.7.x-1.x-dev
Component:
Issues
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
10 Jun 2006 at 00:30 UTC
Updated:
3 Aug 2006 at 14:33 UTC
Jump to comment: Most recent file
as per http://drupal.org/node/23311 it'd be nice if there was an "issues" tab on the default search page on a site (e.g. http://drupal.org/search). the rest of #23311 is still drupal.org maintenance specific stuff, so i'm not moving it. instead, i'm filing this separate issue about this 1 part, since this is a feature for the project module to provide. we basically just need to register some extra stuff in project_menu(), i believe. should be pretty easy.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | project_search_issues_tab.1.patch | 3.21 KB | dww |
| #2 | project_search_issues_tab.patch | 3.04 KB | dww |
Comments
Comment #1
dwwi'm now working on a patch for this. i ran into a slight snag w/ a little confusion about menu callback arguments, but i'll be glad to fully understand how that all works, anyway. ;) so, this will be a learning excercise... patch forthcoming, stay tuned.
Comment #2
dwwComment #3
dwwin case it's not obvious just from looking at the patch, this also gets us a step closer to sanity in the project code regarding the
project_issue_page()method. currently, a ton of menu call backs (e.g. for search, subscribe, add, etc) are all filtered through there, and it's doing wonky stuff viaarg(), then calling another method to do the real work. there's no need for this anymore. we can just register each menu item to directly call the appropriate methods, and we can use default arguments filled in automatically by the menu system to get the optional parameters (e.g. project name). this way, we don't have to mess witharg()to find the "operation" as well as the project name. eventually, i'm planning to fix this for everything handled inproject_issue_page(), and completely remove that function.also, this patch reformats the menu declarations so the individual attributes are on separate lines, to make things more readable... another thing i'm eventually planning to clean-up in the whole module.
Comment #4
dwwwhoops, the previous patch removed a little bit of access checking. previously, you could only do advanced search on a specific project if you had access to view that project (imagine the case where a user has "access own projects" but not "access projects" permissions). new patch restores this behavior...
Comment #5
dwwapplied to HEAD and 4.7. backported to 4.6 (since it was so easy). ;)
Comment #6
(not verified) commented