This is the last piece of logic that is unique to project-release-serve-history.php under the new stats that can't be easily simulated by VCL.

Having a check like this in would make it possible to continue serving updates before and during the complete xml regeneration that making a change to the file format would entail. (THAT part I would recommend deploying alongside #380814: Duplicate entries in some release history XML files)

This patch is needed if #683152: <?xml should be in the release xml files, not the serving logic. is going to be deployed to updates.drupal.org without shutting it down completely during xml regeneration. (Otherwise it will be serving invalid xml during that time.)

CommentFileSizeAuthor
serve-history-xml-tag.patch960 bytesbdragon

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Needs review » Needs work
Issue tags: +needs drupal.org deployment

Committed a modified version of this to HEAD. We needed this:

substr($file, 0, 5) != '<?xml'

instead of this:

substr($file, 0, 4) != '<?xml'

;)

Tagging for d.o deployment... I've got a bunch of other project* stuff I'm hoping to get done today, so hopefully I'll rev d.o SVN and deploy later today.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Fixed
Issue tags: -needs drupal.org deployment

Deployed, although I ran into some trouble: #687064: /var/www/updates.drupal.org/htdocs/project-release-serve-history.php is not properly in SVN

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.