submission guidelines/node help not translatable and displaying

having the same issue. subscribing.

I have just run into the same problem.

I was not sure how things worked as it looks like a few things have changed since I last had to use i18n, so I investigated by walking through the code. I still don't fully understand, but based on what I have learned I think this is a bug.

What I found is that my node help text was being saved into locales_source but not into locales_target for any language so when i18ncontent_help() tried to display the help text i18nstrings_ts() always returned nothing.

What puzzles me even more is that when I search using "Translate interface" page I am unable to find the help text. The name, title and description come up but not help, even though I can find a record for IE: type:page:help in the locales_source table.

I don't fully understand the mechanics of how things work, but should the default help text not be displayed when their is no language.

Ok, I think I worked more out.

i18ncontent_node_type() saves "nodetype:type:$info->type:help" using the default and the default language does not seem to get saved to the locales_target table.

None of the other node type variables (Title, name, description) get saved using the default language, I don't understand why.

And i18nstrings_translate_string() returns the passed in string if no translation is found and i18ncontent_help() does not provide a default string.

I don't understand why i18nstrings_translate_string() does not try and select from locales_source when nothing is found. Or maybe

Chanage the SQL of i18nstrings_get_string() to use an outer join and then loop through the returned languages. Not as slick but could work.

EG:
SELECT s.lid, t.translation, t.language FROM locales_source s LEFT OUTER JOIN locales_target t ON s.lid = t.lid WHERE s.textgroup = '%s' AND s.location = '%s'

I hope that all makes sense. Please note that I don't understand the mechanics of it all, I am just throwing suggestions out there.

I really hope somebody proves me wrong and it ends up being some silly config problem so I can move on from this issue.

The attached patch worked for me. I also made it display the node help in the node type edit form which seemed have the same issue hook_help had.

@miro_dietiker

Yes I can confirm that the help is coming up in l10n_client. The only odd thing is that it is also coming up for the default language. This is the only text coming up for the default language in l10n_client. On all the other langauges every thing works for me as expected.

I think we need to do some sort of check for the default langauge and not to use i18nstrings_ts() when it is the default.

Here is an updated patch. Only 2 things have changed since the previous patch.

In hook_form_alter() the help source is passed directly to the form instead of passing it through i18nstrings_ts(). This would then be the same as if the help was stored in the node_type table.

In hook_help() the help source is passed through t() instead of 18nstrings_ts().

With these changes l10n_client works for me as expected in all languages including the default language.

subscribing

An updated patch that uses i18nstrings() instead of t() as per miro_dietiker

+1

This may be a duplicate #793996: Content of 'Explanation or submission guidelines' can't be saved in edit mode.

I have applied the patch from #10 here, and it seems to work for our default language (english) after re-entering our submission guidelines. Havent tested other languages though.

I tested the patch in the following context:
In an organic group content type, the field value for ‘Explanation or submission guidelines’ in the ‘Submission form settings’ was being ignored.
cd /modules/i18n/
wget http://drupal.org/files/issues/node_help_source.03.patch
patch -d i18ncontent < node_help_source.03.patch

Then enter the submission help text (in English), and use the Translate GUI to add a German string.
Both English and German strings now appear correctly.

So it worked fine.
When might this patch be rolled in to a dev or new release?

Sorry, it's my first patch ;-)

What do I have to do on a Linux Suse 10 Server to get this work?

I have tried the following:
Downloaded the patch file from above and saved it in sites/all/modules/i18n/i18ncontent. And then
patch i18ncontent.module < i18ncontent_685788_nodehelp.patch
resulted in the following error:

patching file i18ncontent.module
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file i18ncontent.module.rej
patching file i18ncontent.module

Please - can anybody help me? Thank you!

Oh, sorry, meant the type should show the type of only my enter and this surely "only was a harmless support request" and no bug report - my intention was not to push it up too high... ;-)

Thank you very much for your reply!

subscribe
waiting for next stable release!

Does i18n 6.x-1.6 fix this?

I should mention that the patch fixed this bug for me. But I recently pulled out i18n and replaced it with GTranslate, and the bug is back. Is it possible i18n had made some change that is causing it to re-occur?

I've reopened, because simply disabling i18n has cause the error to recur, and I suspect its related to this issue.

I have installed Internationalization 6.x-1.7 (within Drupal core 6.16). (In my environment) the problem isn't fully solved:

Now "Explanation or submission guidelines" can be filled for the first time and can be changed as often you want. And now each of the changes takes effect when creating new content. :-)

But when you edit existing content then no text is shown on the top of the page.

Would be very nice if it would be possible to create a new release including a solution for this problem. Thank you very much!

I use internationalization 1.9 in combo with Drupal 6.22.

When I fill in 'Submission guidelines' (in English) and do "Translate Interface" > "Refresh strings", all Submission guidelines are emptied.

I verified this behavior on a clean install:
- Drupal 6.22
- i18n 1.9, no other languages activated

Hi
I just posted this issue :
http://drupal.org/node/1230278

i don't know if it can have something to do with the problem talked about here, but i think it's good to have the information in this issue.

Cheers.

#26
I have the problem: When I refresh the strings of the content types all submission guidelines are deleted.
I use the latest version 6.x-1.10.

I have the same issue as #26, and #28, where help text is being deleted when refreshing content type strings.

I've attached a patch file to address this issue.

Not sure why this is flagged as blocks. Shouldn't this be strings?

Not sure why it's not passing simple test. The patch is working great for our site. Feel free to use it if you need it.