newsletters are not saved in db

no, i dont use any taxonomy access control.

can you explain in a few words how simplenews is hooked into the taxonomy system? i am asking because the title i choose for a newsletter is saved as a taxonomy term in term_data but is not assigned to any vocabulary (vid in database is 0). as far as i can see the title is not saved anywhere else.

another thing i wonder about is the function simplenews_insert(). it is defined in line 408 in simplenews.module, but it NEVER gets called...

i uninstalled and re-installed the module, with the effect that now i have a vocabulary named Newsletter in my taxonomy system which wasn't there before.

When i set up a new newsletter, the title still gets saved as a term but is not assigned to any vocabulary. the vid is still 0. the tid in term_data is 751 , and the edit-newsletter-link points to ?q=admin/content/newsletters/types/edit/751, which looks pretty okay to me, still the edit-link leads to a 404 error.

hm.
the general settings page is ?q=admin/content/newsletters/settings ? i am asking because i don't see anything about vocabularies there... please check the screenshot attached.

another thing i tried is this:

the vocabulary added automatically is called 'newsletter', with the vid 30. so i went into the db and changed the vid (which was 0) of the term used for the newsletter title (tid 751) to the vid 30. what happens is:
- there are no newsletters available anymore (in ?q=admin/content/newsletters/settings)
- ?q=admin/content/taxonomy/30 contains one term, tid 751.

this leads me to the conclusion that the simplenews_vid variable you mentioned in #4 must definitely be causing the error. but where can i see what value is now set as simplenews_vid?
the variables table shows values for :
simplenews_time, simplenews_throttle, simplenews_test_address_override, simplenews_test_address simplenews_sync_account, simplenews_send, simplenews_receipt, simplenews_priority, simplenews_from_name, simplenews_from_address, simplenews_format, simplenews_debug. simplenews_vid is not set.

simplenews_vid is SUPPOSED to be set in in simplenews.install, lines 113 ff:

else {
    // Create the simplenews vocabulary if it does not exist.
    $vocabulary = array(
      'name' => t('Newsletter'),
      'multiple' => '0',
      'required' => '0',
      'hierarchy' => '0',
      'relations' => '0',
      'module' => 'simplenews',
      'nodes' => array('simplenews' => 1)
    );
    taxonomy_save_vocabulary($vocabulary);
    variable_set('simplenews_vid', $vocabulary['vid']); // <- ??? $vocabulary['vid'] has not been defined up to here... or am i missing something?
  }

at this point i am absolutely willing to add the variable manually to the database to get things up and running. can you please provide an example of how the db-field 'value' in the 'variable' table should look like (for vid 30)?

thanks a lot!

okay, my post #6 led me to this:

i just called variable_set('simplenews_vid', 30); in a drupal node with php input format

database now shows the variable simplenews_vid i:30;

everything seems to work :-)

i am not so sure, either. what i found is what i posted above (#6): during setup (in simplenews.install, lines 113 ff), the array $vocabulary is defined, then you go taxonomy_save_vocabulary($vocabulary) (which is just fine and obviously working) and after that variable_set('simplenews_vid', $vocabulary['vid']); (which is obviously NOT working).

as far as i can see, the $vocabulary['vid'] as called in variable_set() must be empty at this stage, for taxonomy_save_vocabulary() will not return any vid.

this would be a suitable explanation for my problem as described above.

a solution would be to replace the above code (#6) with

else {
    // Create the simplenews vocabulary if it does not exist.
    $vocabulary = array(
      'name' => t('Newsletter'),
      'multiple' => '0',
      'required' => '0',
      'hierarchy' => '0',
      'relations' => '0',
      'module' => 'simplenews',
      'nodes' => array('simplenews' => 1)
    );
    taxonomy_save_vocabulary($vocabulary);
    //reload the relevant vocabularies to get the new vid
    $new_vocabularies = taxonomy_get_vocabularies($type = 'simplenews');
    //vid's are auto-incremented, so the newly set vid must be the largest index here:
    $new_vid = max(array_keys($new_vocabularies));
    variable_set('simplenews_vid', $new_vid);
  }

i am not sure is this is the complete solution, but it will get the right simplenews_vid set during install.

hi sutharsan,

well i checked the taxonomy_save_vocabulary() before, actually that's what led me to the approach above. this function only returns a status (which in this case is 'SAVED_NEW'), but nothing else.

anyway, when i perform

<?php 
$vocabulary = array(
      'name' => t('Check'),
      'multiple' => '0',
      'required' => '0',
      'hierarchy' => '0',
      'relations' => '0',
      'module' => 'simplenews',
      'nodes' => array('simplenews' => 1)
    );
    taxonomy_save_vocabulary($vocabulary);
    print $vocabulary['vid'];
?>

in a drupal php-node, i get '31' printed out, which proofs that your original code is definitely correct and working - i don't really see why, maybe module_invoke_all() inside taxonomy_save_vocabulary() does the trick or it's pure voodoo :-)

so, as a conclusion: the error described in this thread is NOT inside the module's code but somewhere else in my individual drupal setup. anyway, i got around it by re-setting the simplenews_vid as described in #6.