CVS edit link for jarek

I need CVS access in order to maintain issues and bug reports for my Drupal theme. In the near future I will be also porting some GPL-ed Wordpress themes to Drupal.

http://drupal.org/node/686410

CommentFileSizeAuthor
#11 titan.zip59.09 KBjarek foksa
#4 KiwiCore.zip120.86 KBjarek foksa
#3 KiwiCore.tar_.gz110.42 KBjarek foksa

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I need CVS access in order to maintain issues and bug reports for my Drupal theme.

To maintain an issue queue is not necessary a CVS account, especially if the theme is going to be added in Drupal.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

If the theme is going to be added as a Drupal 7 core theme, then you don't need a CVS account because the commits will be done from the current Drupal 7 maintainers, not by you.

If then you need a CVS account to create a Drupal 6 version of the theme, then you need to provide the actual code, or there would not be anything to be reviewed.

jarek foksa’s picture

jarek foksa commented
StatusFileSize
new KiwiCore.tar_.gz110.42 KB

I have attached my initial theme implementation for review. Yes, I'm also planning to port it to Drupal 6, although this will start after Drupal 7 version is fully finished.

jarek foksa’s picture

jarek foksa commented
StatusFileSize
new KiwiCore.zip120.86 KB

Sorry, looks like previous file did not upload correctly.

naheemsays’s picture

naheemsays commented

@kiamlaluno - Jarek was requested to develop the theme he is building in cvs, so that others can help pitch in and get it up to date.

(just a fancy subscribe message.)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs review

Remember to change status, when you upload new code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

As per Apply for contributions CVS access the motivation should be expanded, and reports the features of the proposed theme, and include a screenshot of the theme.

jacine’s picture

jacine
she/her
Location New York
commented

Hi, can you please reconsider approving Jarek's CVS account?

He has been busting tail working on Corolla (#686410: New core theme for Drupal 7: Corolla), mostly solo, and it would really help if he was able to use CVS as opposed to GitHub. Whether or not the theme ends up in core, he will need a CVS account to contribute the theme, so unless there is a problem with the code, it serves no purpose to hold up the approval process here.

Code:
http://github.com/jfoksa/corolla/archives/master

Demo site:
http://www.kiwi-themes.com/demosite-1/

Thank you.

jarek foksa’s picture

jarek foksa commented
Status: Needs work » Needs review

Here is another theme that I would like to host on Drupal.org. It's a port of the Titan theme from Wordpress.

Features:
- fexible layout with up to 4 columns
- columns can be freely reordered
- 9 regions
- customised stylings for all core modules, this includes (but is not limited to): forums, polls, books, profiles, nested comments, contextual links...
- additional toolbar button for toggling visibility of contextual links
- clean and well organized code

Tested on following browsers:
- IE 8
- Firefox 3.6
- Chrome 4
- Opera 10.10

Download theme
Demo site
Browse source code on Github

License:
All files are licensed under GNU GPL version 2

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

@jarek: The archive containing the module, or the theme still needs to be uploaded in a comment here.

jarek foksa’s picture

jarek foksa commented
Status: Needs work » Needs review
StatusFileSize
new titan.zip59.09 KB
jarek foksa’s picture

jarek foksa commented
Issue tags: +Theme review

Added a review tag.

yoroy’s picture

yoroy commented
Priority: Normal » Critical

Oh, bumping this for a quick fix. See #8. Jarek has put in a lot of effort in getting a solid Drupal 7 theme done. As we're seeing with Bartik, it makes sense to start in contrib, because finishing a theme doesn't fit in a single core issue #686410: New core theme for Drupal 7: Corolla

Would be nice to let jarek join the club asap. Thank you!

Jeff Burnz’s picture

Jeff Burnz commented
Priority: Critical » Normal

I have reviewed the Titan theme code and I cant see anything that would preclude its inclusion in CVS. The theme looks nice and is certainly a match (code wise) for any other theme in contrib.

I think Jarek will make a fine contributor to the Drupal project.

The original theme is GPL so no problems there also.

Jeff Burnz’s picture

Jeff Burnz commented

dam priority option... apologies, setting back.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Priority: Normal » Critical
Status: Needs review » Fixed

Some big name sponsors there... Approved.

Michelle

jarek foksa’s picture

jarek foksa commented

Thanks, I have successfully created new project page but I can't login to CVS, changing my CVS password did not help:


~/themes/cvs export CVSROOT=:pserver:jarek@cvs.drupal.org:/cvs/drupal-contrib
~/themes/cvs cvs login :(
Logging in to :pserver:jarek@cvs.drupal.org:2401/cvs/drupal-contrib
CVS password:
cvs login: authorization failed: server cvs.drupal.org rejected access to /cvs/drupal-contrib for user jarek

Update: problem solved

jacine’s picture

jacine
she/her
Location New York
commented

Hi Jarek,

Hmm, did you run this first?

export CVSROOT=:pserver:jarek@cvs.drupal.org:/cvs/drupal-contrib

Then:
cvs login

These two are good resources to follow: http://drupal.org/handbook/cvs/quickstart#basics & http://drupal.org/node/262432

jarek foksa’s picture

jarek foksa commented

@Jacine yes, I'm following instructions from this manual, after several attempts cvs login command started working.

jacine’s picture

jacine
she/her
Location New York
commented

Ah, ok. Well I believe it takes about 5 minutes for password changes to take affect, so maybe that is what was going on.

Anonymous’s picture

Anonymous (not verified) commented
Priority: Critical » Normal

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Theme review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes