(Using the v 1.11.2.14 2006/05/31 21:41:06 version, which is what I got when I downloaded the '4.7.0' version, dated 6/3/06, today - same as cvs version, from what I can tell.)

I configured my site to use the forward module, and set it to forward a dynamic block containing "Most Popular Content". The emails that are sent do not include functional URLs.

For example, if I forward this page:
http://www.roadcarvin.com/virginia-city-nevada

The "Most Popular Content" dynamic block in the sent email looks like this:

<div class="dyn_content"><br /><h3>Most Popular Content</h3><ol><li><a href="//node/Virginia+City%2C+Nevada">Virginia City, Nevada</a></li><li><a href="//node/About+RoadCarvin">About RoadCarvin</a></li><li><a href="//node/Assault+with+a+deadly+weapon">Assault with a deadly weapon</a></li><li><a href="//node/Rock+and+Roll">Rock and Roll</a></li><li><a href="//node/RoadCarvin+planning+meeting">RoadCarvin planning meeting</a></li></ol></div>

I've looked at forward.module, and it seems like the forward_top5_list() function isn't building the urls correctly - $base_url is not being initialized in forward_form_submit(), for starters - but that's not all that's wrong. It appears that the URL contains the node title, not the node URL.

So, it seems that the dynamic content function isn't working (for me, anyway). Has anyone else seen this behavior?

CommentFileSizeAuthor
#5 forward_top5_link_v2.patch.txt1.18 KBphuc77
#2 forward_top5_link.patch.txt1.22 KBphuc77

Comments

citizendc’s picture

citizendc commented

Hello,

I am having the same problem. The link becomes the title with+spaces+replaced+by+plus+signs.
I think its a minor bug, as forward does get it right for the main article heading/link.

Unfortunately i know little about PHP. Mr Author, please would take the trouble and time to help your fans with this problem :)

Additonal info:
Fresh install of drupal 4.7
Setting friendly links enabled.
Default drupal template.

phuc77’s picture

phuc77 commented
Status: Active » Needs review
StatusFileSize
new forward_top5_link.patch.txt1.22 KB

Hi,

Wrote a patch for this bug.
Try it out and perhaps we can have this fixed in next version.

- p

mcurry’s picture

mcurry commented

I applied the patch manually (hand-editing forward.module, as my version of the patch utility kept crashing - but it's the UnxUtils variant for Windows...)

Anyway, this seems to fix the problem on my installation.

Thanks!

mcurry’s picture

mcurry commented
Status: Needs review » Reviewed & tested by the community

Switching status to "Ready to be committed"

phuc77’s picture

phuc77 commented
StatusFileSize
new forward_top5_link_v2.patch.txt1.18 KB

Tried applying the patch to the downloaded source and it crashed my windows patch client as well.

Try this patch file if the first one doesn't work for you.
Might be some line endings or line numbers that differ.

mcurry’s picture

mcurry commented

Worked like a charm! Houston, we have ignition!

marcoBauli’s picture

marcoBauli commented

tryed patch V2 above and worked sweet!

thank you!

dzivkovi’s picture

dzivkovi commented

I've applied the patch forward_top5_link_v2.patch.txt (manually) against the latest "forward.module,v 1.11.2.22 2006/09/17 19:47:47" development snapshot from 4.7 and now the "Most Popular Content" e-mail section contains correct links on my site http://jasminahomes.ca/. Thank you Phuc!

john.oltman’s picture

john.oltman commented
Version: 4.7.x-1.x-dev » 6.x-1.21
Status: Reviewed & tested by the community » Closed (fixed)