Needs review
Project:
Petition Node
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Jan 2010 at 16:50 UTC
Updated:
12 Dec 2012 at 19:54 UTC
Jump to comment: Most recent file
Comments
Comment #1
VirtualNorman commentedThis is still an issue in 6.x-1.5.
In 6.x-1.5 permissions are defined as follows:
function petition_perm() {
return array("sign petitions", "create petitions", "edit own petition", "edit petitions", "administer petitions", "administer own petition", "clear petition results", "view signatures");
}
As noted by the original poster, "administer petition" (singular) is used in two spots instead of "administer petitions". As a result, for roles with that permission:
The above patch was filed against 6.x-1.4, but I couldn't get it to apply to that version. I re-rolled the patch against 6.x-1.5.
The above has been fixed in 6.x-2.x.
I also found four locations where the permission "edit own petition" was checked incorrectly as "edit own petitions". The patch corrects these four typos as well. These typos still exist in 6.x-2.x.
Correcting "edit own petition" allows the "Result" and "Clear" menu items to appear on these pages for users with "edit own petition".
Comment #2
VirtualNorman commentedProblem/Motivation
See #1 for description and how to reproduce.
Proposed resolution
Here is a patch fixing the "edit own petition" typos in 6.x-2.x-dev.