Working on it.

Comments

quicksketch’s picture

Version: 6.x-1.x-dev » 6.x-2.x-dev

Just a note that there is a 2.x branch (not finished yet). It would be preferable to finish 2.x or at least port from that version rather than having a 1.x version for D7 and a 2.x version for D6.

chx’s picture

If it's not finished yet but I need a working fivestar now, what then?

BenK’s picture

Subscribing....

chx’s picture

StatusFileSize
new35.7 KB

I am not even setting this to CNR/CNW because all I got so far is that admin/settings/fivestar does not blow up. But as I have converted everything in sight, I have a strong hope that most of the work by now is done.

chx’s picture

Status: Active » Needs review
StatusFileSize
new67.01 KB

Here we go for a review. Note that you must have a very fresh votingapi checkout due to http://drupal.org/cvs?commit=320212

chx’s picture

Note that the JS does not submit back. Oh well. The non-JS version works.

pasqualle’s picture

StatusFileSize
new69.24 KB

1. js vote seems working: drupal_set_header() changed to drupal_add_http_header()
2. fixed css class
3. fixed link to admin/structure/types

coltrane’s picture

Status: Needs review » Needs work

I don't understand the fivestar field. When I add it and try and create a node it is not created after submitted. I get page not found for the node ID and the node isn't showing up at admin/content.

If I ignore adding a field, and instead just enable fivestar via the content type tab "Enable Fivestar rating for the "vote" tag" I'm able to vote.

Non uid 1 users are getting these errors though:

Notice: Undefined index: value in fivestar_static() (line 747 of /Users/Ben/dev/contributions/modules/fivestar-HEAD/fivestar.module).
Notice: Undefined index: value in theme_fivestar_static_element() (line 1208 of /Users/Ben/dev/contributions/modules/fivestar-HEAD/fivestar.module).
Notice: Undefined index: #title_display in theme_form_element() (line 3039 of /Users/Ben/projects/d7/head/includes/form.inc).
tanoshimi’s picture

Yeah, I'm getting the same problem. Disappointing to see that the D7CX pledge has had to be removed from the fivestar project page (and I notice that this module is classed as 'seeks co-maintainer' as well), but judging from the size of the issue queue it's hardly surprising!
I'm starting to work on D7 projects now that will need a fivestar-esque voting system - is anybody willing (and able) to step up and finish off the work that chx started? If not, I might have to start wading in myself...

andypost’s picture

subscribe

Nick Robillard’s picture

subscribing

dgastudio’s picture

+1

chawl’s picture

subs

cleaver’s picture

I'm digging in to this patch now to do a review, but don't let that stop anyone else... the more eyes on this, the better it will be. (Not to mention sooner.)

andypost’s picture

We could use settings for formatter as for image #812688: Organize image formatters around settings
But hw to make a field without a storage (use votingAPI storage)

paul.lovvik’s picture

StatusFileSize
new71.47 KB

Updated the patch from #7. Moved the settings page under Configuration/Content authoring. Also did some testing.

willmoy’s picture

Issue tags: +D7 porting

Tagging

lpalgarvio’s picture

subscribing

zandros’s picture

subscribing

gausarts’s picture

Subscribing. Thanks

chx’s picture

Assigned: chx » Unassigned
Coupon Code Swap’s picture

+1 subscribe

rfage’s picture

subscribing

int’s picture

Now that the Drupal 7 Beta 2 is out and the RC1 is near it's time to port this module (the votingapi is readly for d7)

davidzz’s picture

subscribing

Azol’s picture

Subscribe

GerdC’s picture

subscribe

chriz001’s picture

Subscribe

int’s picture

Drupal 7 Beta 3 is out

Azol’s picture

Patch in #16 works for me, at least it is a good start to begin a 7.x branch with. Waiting for module maintainer to make a final decision.

int’s picture

Status: Needs work » Needs review
mthart’s picture

subscribe

NathanM’s picture

subscribing

ealfert’s picture

subscribing

pcambra’s picture

suscribe

anavarre’s picture

Subscribing

int’s picture

Priority: Normal » Major

Drupal 7.0-rc1 out

dave reid’s picture

Priority: Major » Normal

We're all aware. Stop mass-bumping D7 porting issues.

ezra-g’s picture

I'll commit to a D7 branch on or by 11 Dec at the NY D7CX Code sprint :)..

NathanM’s picture

Woohoo!

Andy B’s picture

subscribing

Andy B’s picture

Title: Port to D7 » Port to D7 for Fivestar module

Changing title to make it easier in the dashboard.

TimelessDomain’s picture

subscribing

ezra-g’s picture

Title: Port to D7 for Fivestar module » Initial Port to D7 for Fivestar module
Status: Needs review » Fixed

I created a 6.x-2.x branch. HEAD is now the D7 branch. This patch is committed and a dev release will be available when the packaging script runs.

Thanks everyone for their work here, and I apologize for the delay in branching & committing (#506700: Fivestar module needs a co-maintainer (for 6.x) ;) )

Let's continue this work in new issues against 7.x-2.x.

http://drupal.org/cvs?commit=462938

Azol’s picture

Thanks!

TimelessDomain’s picture

Thank You! This is the first D7 Voting API integrated module to be ported. To see updates on other similar modules go here #990382: Voting/ Rating Modules that work with D7

Status: Fixed » Closed (fixed)
Issue tags: -D7 porting

Automatically closed -- issue fixed for 2 weeks with no activity.