Needs review
Project:
Multiple Image Upload
Version:
6.x-2.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
23 Jan 2010 at 23:07 UTC
Updated:
7 May 2010 at 22:19 UTC
Dear Simon,
I`a one of the comaintainers of the node_gallery module. We are searching for a bulk upload posibility and I found your module. I wrote a module for the node_gallery that uses part of your code and your postlet for bulk upload. I would like to know if we can use the module I wrote for the node_gallery.module, or if we can join forces to write one module that integrates with image.module and node_gallery.module.
I would provide the code for the new module integrating both modules.
You may check a thread of the node gallery to see our discussion http://drupal.org/node/689490
Thanks
Dirk
PS the module is attached as zip for you to check.
| Comment | File | Size | Author |
|---|---|---|---|
| node_gallery_imagex.zip | 45.73 KB | designwork |
Comments
Comment #1
sdrycroft commentedHi Dirk. This all sounds great. Given that the code I've released is GPL (as is Postlet), I actually can't say no to your request. I personally would prefer a single combined module (i.e. join forces) for this. I'll have a look at your code ASAP (a little bogged down with work at the mo' I'm afraid though), and will get back to you.
Simon
Comment #2
designwork commentedHi Simon,
I will wait........
Comment #3
markpenny commentedHi, guys. Thanks for the module and fork.
I'm using Dirk's fork with Node Gallery and am having a problem. It seems to strip a forward slash from the upload path.
My upload path in Node Gallery is sites/default/files/u%uid/images. It works great with Imagex disabled, but once Imagex is enabled, files go to sites/default/files/u%uidimages.
I've tried a double slash and a trailing slash, but something in Imagex just doesn't like slashes after files/ and takes them all out. Powerful stuff, but not what I'm looking for. Any ideas?
Comment #4
designwork commentedHi mark,
install the transliteration module please.
Dirk
Comment #5
markpenny commentedFantastic. Now it's working as hoped. Thanks a million.
Comment #6
markpenny commentedDirk,
I have a couple of problems when uploading with the fork.
1. Not all the images get thumbnails.
2. The carousel (AD Slideviewer) sometimes gets jammed: two rows of images, no motion and, occasionally, links that don't open images in the viewer.
Are these fork issues or Node Gallery issues?
Comment #7
designwork commentedHi Mark,
1. Not all images get thumbnails, maybe an imagechache problem, or memory problem from the server!
2. What is the carousel (AD Slideviewer)? This has something to do with node_gallery_display?
Please describe a bit better the problems...
Dirk
Comment #8
markpenny commentedSorry, Dirk. It's called AD Gallery. Yes, it's one of the optional viewers in Node Gallery. The carousel is the strip of thumbnails below the viewer. The images slide left and right when you mouseover the arrows to left and right of the strip.
It's quite possible that I am loading too many images for the server to handle at once. I'll try a smaller number next time. Just let me report that the drag-and-drop upload doesn't always end with the manage images link. Sometimes it stalls on the upload progress strip.
Comment #9
markpenny commentedI've just uploaded seven images using drag-and-drop. Three of them don't have thumbnails under Sort Images. Only one of them showed a thumbnail in the Finished display at the end of the upload.
Comment #10
markpenny commentedUploaded three. One didn't get a thumbnail.
Comment #11
markpenny commentedUploaded 66. 37 without thumbnails under Finished. 25 without thumbnails under Sort Images.
3:7, 1:3, 25:66... 198:462, 154:462, 175:462. No consistent ratio of failed thumbnails to uploaded images. Not that there would be, but I thought I'd check.
Comment #12
markpenny commentedUploaded 10. 5 without thumbnails under Finished. 1 without a thumbnail under Sort Images.
Deleted and re-uploaded same 10. No Finished display. Only 7 images uploaded, 1 without thumbnail (same one).
These warnings for the three that didn't upload:
The files exist on my hard drive.
Comment #13
H3x commentedThe postlet applet is really great. However, I'm having much difficulty getting the maxpixels parameter to work. I've set it to 270000 (600*450) and I don't get an "maxpixels is not a number" error like I did when setting maxpixels = "600x450", but it seems like postlet is simply ignoring the resizing altogether.
Any help would be appreciated. If this function works then Node Gallery would be a simply elegant solution to my gallery problems.
Comment #14
H3x commentedAlso, when setting maxpixels param, postlet stalls after uploading +- 2 files (UNresized). I read about something similar on SourceForge, but the problem still remains unsolved... any help would be greatly appreciated.
Comment #15
H3x commentedThe resizing problem seems to be Java related. Here's part of the console output:
Exception in thread "Thread-15" java.lang.OutOfMemoryError: Java heap space
at java.awt.image.DataBufferByte.(Unknown Source)
at java.awt.image.ComponentSampleModel.createDataBuffer(Unknown Source)
at java.awt.image.Raster.createWritableRaster(Unknown Source)
at javax.imageio.ImageTypeSpecifier.createBufferedImage(Unknown Source)
at javax.imageio.ImageReader.getDestination(Unknown Source)
at com.sun.imageio.plugins.jpeg.JPEGImageReader.readInternal(Unknown Source)
at com.sun.imageio.plugins.jpeg.JPEGImageReader.read(Unknown Source)
at javax.imageio.ImageIO.read(Unknown Source)
at javax.imageio.ImageIO.read(Unknown Source)
at UploadThread.setInputStream(UploadThread.java:329)
at UploadThread.uploadFile(UploadThread.java:131)
at UploadThread.upload(UploadThread.java:94)
at UploadThread.run(UploadThread.java:71)
Anyone know how to increase the memory available to Java?
Comment #16
H3x commentedOk, I think I have successfully increased the heap size, also, setting a lower maxthread number, also seems to help:
However, even with maxpixels set:
Only some of the images are getting resized! Does anyone have any clue as to how to solve this? It's driving me crazy!
Comment #17
gregglesI've created a similar patch to provide integration for imagefield #329339: Imagefield support in imagex.
As I built it I thought about making it a more pluggable system so that other modules could use it - I guess that if someone wanted to add a third module (like Node Gallery) then it would make a lot of sense to make it more hookable. Something like: