Closed (fixed)
Project:
Follow
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Jan 2010 at 14:20 UTC
Updated:
27 May 2010 at 21:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
q0rban commentedWhat would it link to, a sign up form or something?
We also need to change the default text for something like this, b/c 'Follow on Newsletter' doesn't read very clean..
Comment #2
robloachYeah, or maybe even a contact form through Contact module, or a Webform, or Simplenews. Since it's just a link, you could make it point to anything.
Regarding the "Follow on" title prefix, hmmmm. Have any suggestions? Follow on mailing list?
Comment #3
q0rban commented"Since it's just a link, you could make it point to anything."
That's kind of the problem I foresee. Right now we are using regex to ensure that users are using their follow links appropriately. In this case, someone could put anything in there. I understand some may want this kind of flexibility, but for us, we are exposing this form to users we affectionately call "dumb". Dumb users need a bit of handholding when it comes to stuff like this…
…just thinking out loud.
Comment #4
robloachMaybe if we provided more information about the hook instead?
Comment #5
q0rban commentedHmm, when pwolanin said he wanted to remove the hook in 7, I figured he'd clean up a bit better than that! Here's the discussion: http://drupal.org/node/619276#comment-2218064
What are your thoughts on it?
Comment #6
robloachI think Peter is being silly. Lots of contrib modules implement their own hook. Nodequeue, Imagecache, gmap, views, these are all pretty large in popularity and all implement their own hooks. If we're just going down the alter only route, then we should document accordingly that in follow.api.php.
Comment #7
q0rban commented> I think Peter is being silly. Lots of contrib modules implement their own hook. Nodequeue, Imagecache, gmap, views, these are all pretty large in popularity and all implement their own hooks.
I said the same thing, but then in IRC he made the point that these modules expose API hooks b/c it is very likely other contrib modules will use them. In this case, it is very unlikely that a contrib module will be implementing hook_follow_networks. The only time anyone would likely be doing that is in their own site module, and in that case, using hook_follow_networks_alter offers more flexibility anyways.
Comment #8
robloachLike this?
Comment #9
q0rban commentedLooks great! Thanks for spending the time on this Rob..
Comment #10
robloachCommitted to HEAD.... http://drupal.org/cvs?commit=326130
Here's a port for the Drupal 6 branch. Not sure if switching over to the alter is the right idea for 6 though.......
Comment #11
q0rban commentedThanks, committed! http://drupal.org/cvs?commit=366660