Just scratching an itch...

I've written a patch to collapse all fieldsets on the theme settings form, not just the ones presently being targeted.

I wanted my Touch Icons fieldset to be collapsible when used with AdaptiveTheme, but this patch will also benefit other modules like DesignKit.

The existing code doesn't put a <div class="*-settings-wrapper"> wrapper around the theme_specific fieldset (I'm not sure why... any special reason?) I've kept that behaviour with my patch, though there doesn't seem to be any harm putting the wrapper around the theme_specific fieldset, too.

CommentFileSizeAuthor
#1 adaptivetheme-696686.patch2.4 KBandrewmacpherson

Comments

andrewmacpherson’s picture

andrewmacpherson commented
Status: Active » Needs review
StatusFileSize
new adaptivetheme-696686.patch2.4 KB

here comes the patch...

Jeff Burnz’s picture

Jeff Burnz commented

Great, you beat me to it, was thinking we should do this also, will review soon (on holiday right now).

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs review » Fixed

Committed!

Awesome man, I actually simplified it to allow the <div class="*-settings-wrapper"> wrappers for everything, may as well be consistant and this was just an oversight on my part that it wasn't already, good work dude!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.