There are some -0.x releases.

project_release_check_supported_versions() needs to have a more specific check to avoid attempting to insert duplicate rows.

Noticed while testing my update for #649254: version_extra can't just be string sorted.

    * user warning: Duplicate entry '25274-78-0' for key 1 query: INSERT INTO project_release_supported_versions (nid, tid, major, supported, recommended, snapshot, recommended_release, latest_release, latest_security_release) VALUES (25274, 78, 0, 1, 0, 0, 444722, 444722, 0) in /home/bdragon/devel/project.littlethings/release/project_release.module on line 286.
    * user warning: Duplicate entry '49436-87-0' for key 1 query: INSERT INTO project_release_supported_versions (nid, tid, major, supported, recommended, snapshot, recommended_release, latest_release, latest_security_release) VALUES (49436, 87, 0, 1, 0, 0, 378304, 378304, 0) in /home/bdragon/devel/project.littlethings/release/project_release.module on line 286.
CommentFileSizeAuthor
mumble_branch_zero_mumble.patch938 bytesbdragon

Comments

dww’s picture

dww
we/he/they
commented

bdragon mentioned that the following should trigger this bug on d.o:

project_release_check_supported_versions(25274, 78, 0, FALSE);

I'll try that on d6.p.d.o before I commit. Otherwise, this looks like a good fix to me.

Thanks!
-Derek

dww’s picture

dww
we/he/they
commented
Status: Active » Fixed

I couldn't actually reproduce this on d6.p.d.o, but the code is clearly wrong in this case, and the patch visually looks like it should be fine. ;) So, I committed to HEAD and DRUPAL-5. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.