We have a problem getting an error message "Page manager module is unable to enable taxonomy/term/%term because some other module already has overridden with i18ntaxonomy_term_page."
We use latest version of Page Manager: 6.x-1.2.

See issue taxonomy/term/% overwritten by another module:
This seems not to be a problem with Panels, or ctools (where it technically should be filed). Either Taxonomy Translation has to play nice with Page Manager, or it won't work. There's nothing we can do; you've gotta file the issue over there.

What can we do here?
Thanks in advance,
Ralf

CommentFileSizeAuthor
#2 i18ntaxonomy_page_manager_v01.patch1019 byteskars-t

Comments

5n00py’s picture

Same problem.

At this moment I connemt this lines in i18ntaxonomy.module:

105  //$items['taxonomy/term/%']['module'] = 'i18ntaxonomy';
106  //$items['taxonomy/term/%']['page callback'] = 'i18ntaxonomy_term_page';
107  //$items['taxonomy/term/%']['file'] = 'i18ntaxonomy.pages.inc';
kars-t’s picture

Status: Active » Needs review
StatusFileSize
new1019 bytes

Here is a patch for the problem:

  // If ctool's page manager is active for the path skip this modules override.
  if (variable_get('page_manager_term_view_disabled', TRUE)) {
    // Taxonomy term page. Localize terms.
    $items['taxonomy/term/%']['module'] = 'i18ntaxonomy';
    $items['taxonomy/term/%']['page callback'] = 'i18ntaxonomy_term_page';
    $items['taxonomy/term/%']['file'] = 'i18ntaxonomy.pages.inc';
  }

variable_get('page_manager_term_view_disabled', TRUE) is only set to FALSE if the panels override is enabled. This patch lets i18ntaxonomy respect that the panels override might be more important.

I know this is some kind of special hack to make this work with "some" other module and maybe the other module should provide a workaround. But as it's THE ctools / panels module it might be a good idea to add those three lines.

eliosh’s picture

Patch in comment #2 work good for me.
Thanks

Drupal 6.15 (Pressflow 6.15.65)
Panels 6.x-3.3
CTools 6.x-1.3
i18ntaxonomy 6.x-1.2

and others...

Wappie08’s picture

I can also confirm that Kars-T's patch in #2 works on letting Panels override, thanks for fixing this Kars-T!

Greetings Wappie

srsbl’s picture

The patch also worked for me.
Thanks.

jose reyero’s picture

Status: Needs review » Fixed

Well, it looks harmless, so if it's any use...

Committed, thanks.

kars-t’s picture

Hey great! Thank you Jose! :D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nedjo’s picture

Status: Closed (fixed) » Needs work

While a specific test for page manager is fine, it would be better to provide as well a more generic test (like page manager does) by testing the existing 'page callback' and skipping if it is not 'taxonomy_term_page', meaning it's already been overridden by another module.

jose reyero’s picture

Status: Needs work » Closed (fixed)

Only critical bug fixes for this version.